From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arkadiuszx.kusztal@intel.com> Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8CBAD1B1A0 for <dev@dpdk.org>; Wed, 20 Mar 2019 18:28:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 10:28:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,249,1549958400"; d="scan'208";a="308869533" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 20 Mar 2019 10:28:33 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 10:28:33 -0700 Received: from hasmsx114.ger.corp.intel.com (10.184.198.65) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 10:28:32 -0700 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.144]) by HASMSX114.ger.corp.intel.com ([169.254.14.210]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 19:28:30 +0200 From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com> To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Trahe, Fiona" <fiona.trahe@intel.com> Thread-Topic: [PATCH v3] cryptodev: make xform key pointer constant Thread-Index: AQHU3yGTXUcHbyob/EG49+ILU4EFw6YUxkBg Date: Wed, 20 Mar 2019 17:28:29 +0000 Message-ID: <06EE24DD0B19E248B53F6DC8657831551B14CD55@hasmsx109.ger.corp.intel.com> References: <20190319094340.31198-1-roy.fan.zhang@intel.com> <20190320133207.58826-1-roy.fan.zhang@intel.com> In-Reply-To: <20190320133207.58826-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.104.12.183] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 20 Mar 2019 17:28:35 -0000 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Wednesday, March 20, 2019 2:32 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Trahe, > Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX > <arkadiuszx.kusztal@intel.com> > Subject: [PATCH v3] cryptodev: make xform key pointer constant >=20 > This patch changes the key pointer data types in cipher, auth, and aead > xforms from "uint8_t *" to "const uint8_t *" for a more intuitive and saf= e > sessionn creation. >=20 > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > --- > v3: > - rebased on top of latest dpdk-next-crypto >=20 > v2: > - fixed a missed memory free for ixgbe ipsec > drivers/common/cpt/cpt_ucode.h | 14 ++--- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 8 +-- > drivers/crypto/qat/qat_sym_session.c | 8 +-- > drivers/crypto/qat/qat_sym_session.h | 4 +- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 23 ++++++-- > drivers/crypto/snow3g/rte_snow3g_pmd_private.h | 1 + > drivers/crypto/virtio/virtio_cryptodev.c | 30 +++++++--- > drivers/crypto/virtio/virtio_cryptodev.h | 2 + > drivers/net/ixgbe/ixgbe_ipsec.c | 35 +++++++++--- > drivers/net/ixgbe/ixgbe_ipsec.h | 3 +- > drivers/net/softnic/rte_eth_softnic_cli.c | 74 ++++++++++++-------= ------ > drivers/net/softnic/rte_eth_softnic_internals.h | 4 ++ > examples/ip_pipeline/cli.c | 74 ++++++++++++-------= ------ > examples/ip_pipeline/cryptodev.c | 2 - > examples/ip_pipeline/pipeline.h | 6 ++ > examples/l2fwd-crypto/main.c | 40 +++++-------- Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 30D33A00E6 for <public@inbox.dpdk.org>; Wed, 20 Mar 2019 18:28:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F6D21B1F8; Wed, 20 Mar 2019 18:28:36 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8CBAD1B1A0 for <dev@dpdk.org>; Wed, 20 Mar 2019 18:28:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 10:28:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,249,1549958400"; d="scan'208";a="308869533" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 20 Mar 2019 10:28:33 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 10:28:33 -0700 Received: from hasmsx114.ger.corp.intel.com (10.184.198.65) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 10:28:32 -0700 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.144]) by HASMSX114.ger.corp.intel.com ([169.254.14.210]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 19:28:30 +0200 From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com> To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Trahe, Fiona" <fiona.trahe@intel.com> Thread-Topic: [PATCH v3] cryptodev: make xform key pointer constant Thread-Index: AQHU3yGTXUcHbyob/EG49+ILU4EFw6YUxkBg Date: Wed, 20 Mar 2019 17:28:29 +0000 Message-ID: <06EE24DD0B19E248B53F6DC8657831551B14CD55@hasmsx109.ger.corp.intel.com> References: <20190319094340.31198-1-roy.fan.zhang@intel.com> <20190320133207.58826-1-roy.fan.zhang@intel.com> In-Reply-To: <20190320133207.58826-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.104.12.183] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190320172829.Sec6ao6saPx75RBFIWen9UwFZ_--RGkbOQpGqzfORBU@z> > -----Original Message----- > From: Zhang, Roy Fan > Sent: Wednesday, March 20, 2019 2:32 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Trahe, > Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX > <arkadiuszx.kusztal@intel.com> > Subject: [PATCH v3] cryptodev: make xform key pointer constant >=20 > This patch changes the key pointer data types in cipher, auth, and aead > xforms from "uint8_t *" to "const uint8_t *" for a more intuitive and saf= e > sessionn creation. >=20 > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > --- > v3: > - rebased on top of latest dpdk-next-crypto >=20 > v2: > - fixed a missed memory free for ixgbe ipsec > drivers/common/cpt/cpt_ucode.h | 14 ++--- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 8 +-- > drivers/crypto/qat/qat_sym_session.c | 8 +-- > drivers/crypto/qat/qat_sym_session.h | 4 +- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 23 ++++++-- > drivers/crypto/snow3g/rte_snow3g_pmd_private.h | 1 + > drivers/crypto/virtio/virtio_cryptodev.c | 30 +++++++--- > drivers/crypto/virtio/virtio_cryptodev.h | 2 + > drivers/net/ixgbe/ixgbe_ipsec.c | 35 +++++++++--- > drivers/net/ixgbe/ixgbe_ipsec.h | 3 +- > drivers/net/softnic/rte_eth_softnic_cli.c | 74 ++++++++++++-------= ------ > drivers/net/softnic/rte_eth_softnic_internals.h | 4 ++ > examples/ip_pipeline/cli.c | 74 ++++++++++++-------= ------ > examples/ip_pipeline/cryptodev.c | 2 - > examples/ip_pipeline/pipeline.h | 6 ++ > examples/l2fwd-crypto/main.c | 40 +++++-------- Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>