From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2241A0471 for ; Wed, 17 Jul 2019 10:39:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 557E61B53; Wed, 17 Jul 2019 10:39:42 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7D75D2082 for ; Wed, 17 Jul 2019 10:39:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 01:39:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="172803636" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 17 Jul 2019 01:39:39 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 01:39:38 -0700 Received: from lcsmsx153.ger.corp.intel.com (10.186.165.228) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 01:39:38 -0700 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.134]) by LCSMSX153.ger.corp.intel.com ([169.254.8.138]) with mapi id 14.03.0439.000; Wed, 17 Jul 2019 11:39:35 +0300 From: "Kusztal, ArkadiuszX" To: Shally Verma , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about primes Thread-Index: AQHVPAe6p25A7MwovEyN/ae+xbNE2abOOSOAgABC7dA= Date: Wed, 17 Jul 2019 08:39:34 +0000 Message-ID: <06EE24DD0B19E248B53F6DC8657831551B280871@hasmsx109.ger.corp.intel.com> References: <20190716185304.12592-1-arkadiuszx.kusztal@intel.com> <20190716185304.12592-2-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about primes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Shally Verma [mailto:shallyv@marvell.com] > Sent: Wednesday, July 17, 2019 9:32 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments > about primes >=20 >=20 >=20 > > -----Original Message----- > > From: Arek Kusztal > > Sent: Wednesday, July 17, 2019 12:23 AM > > To: dev@dpdk.org > > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma > > ; Arek Kusztal > > Subject: [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments > > about primes > > > > External Email > > > > ---------------------------------------------------------------------- > > RSA modulus cannot be prime as its security basing on integer > factorization. > > > [Shally] I think you mean here that "RSA modulus input cannot be prime as= it > is multiple of 2 primes" [AK] From Menezes, van Oorsc, Vanstone - Handbook of applied cryptography - 8.6 - Fact The problem of computing the RSA decryption exponent d from the = public key (n, e), and the problem of factoring n, are computationally equivalent. Besides RSA supports multi-primes (product of more primes than two) which w= e currently don't. Although yeah I could describe it bit clearer. >=20 > > Signed-off-by: Arek Kusztal > > --- > Other than minor rephrasing requirement on commit log, change is > Acked-by: Shally Verma >=20 > > lib/librte_cryptodev/rte_crypto_asym.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > b/lib/librte_cryptodev/rte_crypto_asym.h > > index 8672f21..02ec304 100644 > > --- a/lib/librte_cryptodev/rte_crypto_asym.h > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > > @@ -199,8 +199,8 @@ struct rte_crypto_rsa_priv_key_qt { > > */ > > struct rte_crypto_rsa_xform { > > rte_crypto_param n; > > - /**< n - Prime modulus > > - * Prime modulus data of RSA operation in Octet-string network > > + /**< n - Modulus > > + * Modulus data of RSA operation in Octet-string network > > * byte order format. > > */ > > > > @@ -409,7 +409,7 @@ struct rte_crypto_rsa_op_param { > > * over-written with generated signature. > > * > > * Length of the signature data will be equal to the > > - * RSA prime modulus length. > > + * RSA modulus length. > > */ > > > > enum rte_crypto_rsa_padding_type pad; > > -- > > 2.1.0