From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0A4BA0471 for ; Wed, 17 Jul 2019 18:01:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B11BB1BE63; Wed, 17 Jul 2019 18:01:16 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C4BA61BE48 for ; Wed, 17 Jul 2019 18:01:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 09:01:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,274,1559545200"; d="scan'208";a="319354982" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 17 Jul 2019 09:01:13 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 09:01:13 -0700 Received: from hasmsx105.ger.corp.intel.com (10.184.198.19) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 09:01:12 -0700 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.134]) by HASMSX105.ger.corp.intel.com ([169.254.1.231]) with mapi id 14.03.0439.000; Wed, 17 Jul 2019 19:01:10 +0300 From: "Kusztal, ArkadiuszX" To: Shally Verma , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [EXT] [PATCH v3 02/11] cryptodev: add cipher field to RSA op Thread-Index: AQHVPAe9kvYzT0APPEatm8IpkjuK9abOOyMAgAC7mwA= Date: Wed, 17 Jul 2019 16:01:09 +0000 Message-ID: <06EE24DD0B19E248B53F6DC8657831551B280C21@hasmsx109.ger.corp.intel.com> References: <20190716185304.12592-1-arkadiuszx.kusztal@intel.com> <20190716185304.12592-3-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 02/11] cryptodev: add cipher field to RSA op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Shally, > > > > Signed-off-by: Arek Kusztal > > --- > > lib/librte_cryptodev/rte_crypto_asym.h | 26 > > +++++++++++++++++++++++++- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > b/lib/librte_cryptodev/rte_crypto_asym.h > > index 02ec304..16c86c9 100644 > > --- a/lib/librte_cryptodev/rte_crypto_asym.h > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > > @@ -397,9 +397,33 @@ struct rte_crypto_rsa_op_param { > > /**< > > * Pointer to data > > * - to be encrypted for RSA public encrypt. > > - * - to be decrypted for RSA private decrypt. > > * - to be signed for RSA sign generation. > > * - to be authenticated for RSA sign verification. > > + * > > + * Octet-string network byte order format. > > + * > > + * This field is an input to RTE_CRYPTO_ASYM_OP_ENCRYPT > > + * operation, and output to RTE_CRYPTO_ASYM_OP_DECRYPT > > operation. > > + * > > + * When RTE_CRYPTO_ASYM_OP_DECRYPT op_type used length in > > bytes > > + * of this field needs to be greater or equal to the length of > > + * corresponding RSA key in bytes. > > + */ > [Shally] this overall look repetitive here. Since now this buffer is both= input > and output depending on op_type. > How about , if we just change description to: > Pointer to plaintext buffer. This buffer is input to > RSA_CRYPTO_ASYM_OP_TYPE_ENCRYPT/ SIGN, VERIFY And Output to > RTE_CRYPTO_ASYM_OP_TYPE_DECRYPT [AK] - I have missed this mail. You right, but instead of sending v5 just f= or that I could change this in future patches? >=20 > > + > > + > > + rte_crypto_param cipher; > > + /**< > > + * Pointer to data > > + * - to be decrypted for RSA private decrypt. > > + * > > + * Octet-string network byte order format. > > + * > > + * This field is an input to RTE_CRYPTO_ASYM_OP_DECRYPT > > + * operation, and output to RTE_CRYPTO_ASYM_OP_ENCRYPT > > operation. > > + * > > + * When RTE_CRYPTO_ASYM_OP_ENCRYPT op_type used length in > > bytes > > + * of this field needs to be greater or equal to the length of > > + * corresponding RSA key in bytes. > > */ > [Shally] So is my suggestion here. Change to like "Pointer to Ciphetext b= uffer > ..." >=20 > > > > rte_crypto_param sign; > > -- > > 2.1.0