DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: fix doc build failure
@ 2020-05-19  7:36 Raslan Darawsheh
  2020-05-19  7:39 ` Ray Kinsella
  2020-05-19  8:03 ` David Marchand
  0 siblings, 2 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-05-19  7:36 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, mdr

doc/guides/contributing/abi_versioning.rst:416:
 ERROR: Error in "code-block" directive:
1 argument(s) required, 0 supplied.

.. code-block::

   use_function_versioning = true

Fixes: 45a4103e680d ("doc: fix default symbol binding in ABI guide")
Cc: mdr@ashroe.eu
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 doc/guides/contributing/abi_versioning.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst
index ef881877f..f4a9273af 100644
--- a/doc/guides/contributing/abi_versioning.rst
+++ b/doc/guides/contributing/abi_versioning.rst
@@ -413,7 +413,7 @@ Finally, we need to indicate to the :doc:`meson/ninja build system
 library or driver. In the libraries or driver where we have added symbol
 versioning, in the ``meson.build`` file we add the following
 
-.. code-block::
+.. code-block:: none
 
    use_function_versioning = true
 
-- 
2.26.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: fix doc build failure
  2020-05-19  7:36 [dpdk-dev] [PATCH] doc: fix doc build failure Raslan Darawsheh
@ 2020-05-19  7:39 ` Ray Kinsella
  2020-05-19  8:03 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: Ray Kinsella @ 2020-05-19  7:39 UTC (permalink / raw)
  To: Raslan Darawsheh, ferruh.yigit; +Cc: dev

strange - I didn't get the error, but the changes makes perfect sense. 
Thanks, 

On 19/05/2020 08:36, Raslan Darawsheh wrote:
> doc/guides/contributing/abi_versioning.rst:416:
>  ERROR: Error in "code-block" directive:
> 1 argument(s) required, 0 supplied.
> 
> .. code-block::
> 
>    use_function_versioning = true
> 
> Fixes: 45a4103e680d ("doc: fix default symbol binding in ABI guide")
> Cc: mdr@ashroe.eu
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
>  doc/guides/contributing/abi_versioning.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst
> index ef881877f..f4a9273af 100644
> --- a/doc/guides/contributing/abi_versioning.rst
> +++ b/doc/guides/contributing/abi_versioning.rst
> @@ -413,7 +413,7 @@ Finally, we need to indicate to the :doc:`meson/ninja build system
>  library or driver. In the libraries or driver where we have added symbol
>  versioning, in the ``meson.build`` file we add the following
>  
> -.. code-block::
> +.. code-block:: none
>  
>     use_function_versioning = true
>  
> 

Acked-by: Ray Kinsella <mdr@ashroe.eu>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: fix doc build failure
  2020-05-19  7:36 [dpdk-dev] [PATCH] doc: fix doc build failure Raslan Darawsheh
  2020-05-19  7:39 ` Ray Kinsella
@ 2020-05-19  8:03 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-05-19  8:03 UTC (permalink / raw)
  To: Raslan Darawsheh; +Cc: Yigit, Ferruh, dev, Ray Kinsella

On Tue, May 19, 2020 at 9:37 AM Raslan Darawsheh <rasland@mellanox.com> wrote:
>
> doc/guides/contributing/abi_versioning.rst:416:
>  ERROR: Error in "code-block" directive:
> 1 argument(s) required, 0 supplied.
>
> .. code-block::
>
>    use_function_versioning = true
>
> Fixes: 45a4103e680d ("doc: fix default symbol binding in ABI guide")

> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
Acked-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-19  8:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19  7:36 [dpdk-dev] [PATCH] doc: fix doc build failure Raslan Darawsheh
2020-05-19  7:39 ` Ray Kinsella
2020-05-19  8:03 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).