From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xueming Li <xuemingl@nvidia.com>, Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, Asaf Penso <asafp@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] vdpa/mlx5: hardware error handling
Date: Thu, 29 Oct 2020 09:29:27 +0100 [thread overview]
Message-ID: <06ad6d76-64fd-ea24-1c56-a7620765ef84@redhat.com> (raw)
In-Reply-To: <1603787325-13707-2-git-send-email-xuemingl@nvidia.com>
On 10/27/20 9:28 AM, Xueming Li wrote:
> When hardware error happens, vdpa didn't get such information and leave
> driver in silent: working state but no response.
>
> This patch subscribes firmware virtq error event and try to recover max
> 3 times in 3 seconds, stop virtq if max retry number reached.
>
> When error happens, PMD log in warning level. If failed to recover,
> outputs error log. Query virtq statistics to get error counters report.
>
> Acked-by: Matan Azrad <matan@nvidia.com>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
> doc/guides/rel_notes/release_20_11.rst | 6 +-
> doc/guides/vdpadevs/mlx5.rst | 8 ++
> drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +
> drivers/vdpa/mlx5/mlx5_vdpa.h | 37 +++++++
> drivers/vdpa/mlx5/mlx5_vdpa_event.c | 144 +++++++++++++++++++++++++
> drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 61 ++++++++---
> 6 files changed, 242 insertions(+), 16 deletions(-)
>
Applied to dpdk-next-virtio/main.
Thanks!
Maxime
prev parent reply other threads:[~2020-10-29 8:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 7:16 [dpdk-dev] [PATCH 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26 7:16 ` [dpdk-dev] [PATCH 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-26 9:12 ` [dpdk-dev] [PATCH v1 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26 9:12 ` [dpdk-dev] [PATCH v1 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-26 11:14 ` [dpdk-dev] [PATCH v2 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26 11:14 ` [dpdk-dev] [PATCH v2 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-26 15:04 ` [dpdk-dev] [PATCH v3 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26 15:04 ` [dpdk-dev] [PATCH v3 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-27 8:28 ` [dpdk-dev] [PATCH v4 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-28 13:59 ` Maxime Coquelin
2020-10-29 8:29 ` Maxime Coquelin
2020-10-27 8:28 ` [dpdk-dev] [PATCH v4 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-28 14:19 ` Maxime Coquelin
2020-10-29 8:29 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ad6d76-64fd-ea24-1c56-a7620765ef84@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).