From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30043.outbound.protection.outlook.com [40.107.3.43]) by dpdk.org (Postfix) with ESMTP id 1430E5F33 for ; Mon, 17 Sep 2018 14:20:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xWGeigZM+FvIq8u61Nf4IG8yAxcXD9GMu5gHa4ZiPis=; b=JxRjMfn81OFhfH6RvqmMX87LD5PK76k3v9yzwTvFqEXdxHcRn8yqNUrjLidmN6LWBthEFI4VbqBfb2UHucxwl9lXWrrgB83UyOBC3sLQtUgwWQe7Jc1YeW8kMMnEYtHNIQ0f1l4MWiEEq3PnjGVSdLn1mMCpVJZgPhxUgpFYtbE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by DB7PR04MB4891.eurprd04.prod.outlook.com (2603:10a6:10:18::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Mon, 17 Sep 2018 12:20:34 +0000 To: "Joseph, Anoob" , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Ankur Dwivedi , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-2-git-send-email-ajoseph@caviumnetworks.com> <8421735d-1357-e444-9924-390f23827f3e@nxp.com> <95e172a1-2f81-3e8f-7fba-8373e64428d8@caviumnetworks.com> From: Akhil Goyal Message-ID: <06b2d39f-5d9a-d1e2-f3bb-5238e40e6406@nxp.com> Date: Mon, 17 Sep 2018 17:50:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <95e172a1-2f81-3e8f-7fba-8373e64428d8@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BM1PR0101CA0036.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::22) To DB7PR04MB4891.eurprd04.prod.outlook.com (2603:10a6:10:18::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45531cce-1863-48eb-b7b0-08d61c97f99d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4891; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4891; 3:Dr7IV0AGL0ntoE497KpmzsPi29R97iHuu/sLGKcn7CPjuB1t07vsuVSFtvPus/kYotWaKdrVix+XNG6ST/uLSdqxxLlh30mtw28b3m0WMICVLfREzthvefR4Mn7PTTw/RVEQBkwGPNGFVZVTUIVK2LgyfA3UfFwQYdiMzwrJfnA+d1i6C3VWVjyAiowmmrrC0Cwx5u20WSP9uVDAyJvLMW/9/MsxFRQpi32ULYcxTjuFDy7HNJ3F5C+9JhslNFPE; 25:EIRKNOuVkCg1l8HZZ1Y2hJt9RUGqd1UtfVuaejLYz6E9UIFw39GeOtLRjnNsrOl0pu3tbfo883hrNBIMdgDvwJDzNa3ZIQeXslpVMELxqxkDyup4eCcz5gO7JyRm1hIZip+LwFUKbSNmMZ1P5gr1fLxrhMiNLokzPDoeKDENmcGtHbnkWsMl3vThMRKmdQMdSl3XXmt8FtesDOLAkJprgsY3gZJEzFhSjo1GVlqzPfNzn+cln01u/UJtexMbgZwKjUseUUPa7B2cjN1+1zrWm4xtLvXlGKs7RDMFMbOizOGHa473rgPn3uHkoeWbL6rlvuyKahIlCI9jo2WvZACAyQ==; 31:c+ZEYtgAeOyGU0KIBkJwE7tO2SF4ouHTqD21tgeHpYDbDphOMmqsU64lUye9HGLgw1ljUT/mSNESM/O1nZf98Yn08c6rfNcr7vatGr5qWRQ5PBJEzYLLAD+9/TOp0dA7BjAeYR3L3XYU5HeMS2BOuXZGne5PbVcMQOVW5K/uCmtgvvQDyQIUWFbqt44jzJpJ+RI8t4iavlq5unJAEBUj64qAM3+o1c6LUxLcsUl24EQ= X-MS-TrafficTypeDiagnostic: DB7PR04MB4891: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4891; 20:jXUov7k+L4/GipoIMq7pc2f/WqK2hiPjvQFfgFBpqzALzQFxOOPHa0S9hMdZ5QTewO8gwvKOnmhEEw30wzSWlSbU77H08UGBYn5HMYHjsYmlqu1MQZV6AJmC2zzXnxcEwOf4pTDhPr8K+1qqwofBaui+3Nu4pPPcrzIOn5QQTcI0m5exiwNPWy7tU07RNPiN27lAeTBs19K0VTNlC8sCowbUjTSlaqkHh1W+DISccj6HzHYaD8Y377/Pdvk1Q48DfE+5I20zKV04I/kdtuvApI1ibISjFvhkALAoFDM25xbSyA5LniH7f9PClRDmZu08LKK/f76qM+mGFNsYX9kgDSAmvaB1ty+zzNp8zC5l52IFOhVB0ZHvL/mTTbQ+jgHoWJ/pa8SOJNiwTmsJmtTl6vJOJWuUDP5AMuhBwA+ADW+ZC2CZHlcHpFUeVvXL4aa7zI+W2G6flVtUjh8znDCQiTol3kuht2aLWsdZEfJmjDtNOnJaKnRZ2rsXzWpzj5sj; 4:LtplmQKm9zwv1hxeEYLty+wrPKDhCbAphLo8wh5Cik81ySRQIadd4n3SUUimMT68Gfzguf8jPvrKvWwJX9nTxBASxC/7ICL0KTi8oIMkqz/jDmSWt6KnMTrLJmSP8JFZzQIYH+C9M7Sfj23Cek9VDJcL8CVyNfNUlmmS3TBy8ALaVxtEdfhDpKQzUIRaza+ZOE8rRT+icgV44wJkAePT4yMW1QjLlFxtJKnw5OrXdeDFT29myBULoYMYgaukV7qaM8JW31HMD19iv9C+otAB7w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699050); SRVR:DB7PR04MB4891; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4891; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(346002)(376002)(136003)(396003)(366004)(51444003)(199004)(189003)(3260700006)(25786009)(26005)(8936002)(31696002)(55236004)(64126003)(478600001)(11346002)(486006)(446003)(956004)(2616005)(476003)(16526019)(8676002)(186003)(77096007)(5660300001)(4326008)(65826007)(81166006)(86362001)(81156014)(44832011)(6666003)(2906002)(2870700001)(14444005)(93886005)(47776003)(68736007)(50466002)(31686004)(65806001)(65956001)(66066001)(105586002)(305945005)(16576012)(229853002)(54906003)(97736004)(2486003)(52116002)(52146003)(23676004)(58126008)(53546011)(76176011)(316002)(7736002)(7416002)(386003)(67846002)(3846002)(6116002)(36756003)(53936002)(110136005)(6486002)(106356001)(5009440100003)(6246003)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4891; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjdQUjA0TUI0ODkxOzIzOjRWVUltWHdjQlp1blRMd2FhTUg3NDd2L2Rp?= =?utf-8?B?VmdlSWNraDhIM3oreG01dDh2QllmK21HYjFsMGhmWEtmTy9Ec0hTTjR1QU91?= =?utf-8?B?YXNYVVo5QUlYTVY2TGdrdHdmOUlpSVkxaStCQlZ1MkxLZklXVzlwTkNMSGlF?= =?utf-8?B?bDJwMzdoOTZYY0IvUS9jQlFlZStNYXBIZlJsd3JhTWF2Rml1TDNpenkwUnJH?= =?utf-8?B?YWV6cUMzcU9Bb3Z0Z0dqZlgrMXlUVlF2NEc4aHpEWmNKVmFFNnZWbnpIcTBY?= =?utf-8?B?d3d5NHpGc25jWDQrUWgzVE5DNko4SWRhZWRZWEI4SGoxWEVxUGowYXhTRU9Y?= =?utf-8?B?ZWx5RXVhM2dLclh1RTltYVBlWWgvVGVKaG5LUVJaYU5aeW9aT0pVOUtXZ1pr?= =?utf-8?B?L25INzJnc1RXc3h2WU9sU2dQVEU0amt1UnNnTlhpQW1jdFdwUGpGdXlSNjd6?= =?utf-8?B?eUlJdEFNTjJGeGR3MTN4SmYveVNlSHo5OFBDUXk2MXJUZGtjcnJnL1duUUN0?= =?utf-8?B?dlo1M01tUVJveHF2eE0vcEhNZlcrZ1IrNkg1MXpSdGVDeFR0QzlQUngvcmNp?= =?utf-8?B?bnZjN1RWL1N3TjNIR2pQdFUwS2VDV2JMdXFPTzBjSmlteU5SUit3dFFPV2l2?= =?utf-8?B?WGRmSWdxNXNYdS9ZS3liMDZZdXpMNjRCamt0NDE0Y0xOUEhWaHRUYktmQ1pU?= =?utf-8?B?WkY5SDcyZjZRaTVRa3lBOFdUbFFOWjhKWHkzQlIrbklCK01iSERSeVpDVDJ5?= =?utf-8?B?a3ByemhOaXVKU0ZXQTdxeDdUVmZubEFKK3lXMWc2YVpUWmF2bXNEbHZMVlJC?= =?utf-8?B?SCthZGRNcmo2dlVyMFdqSDFCa2tuZGNiMStIMjN0WVdGdVd3NWJoMXpQcnEx?= =?utf-8?B?Q21idHpvUjU0RVltV2E4bWpkK2FEMTdiUk5sN2REZDBwYm8wM1MrRGhwMldk?= =?utf-8?B?K2I4dXR2V1JTOU51WVBENlpEOGM2RzFJTGswM0I1UG1JSHZPNS81VW5yclVu?= =?utf-8?B?U3d3VWJOZmdZbitxYzRPQ083Z003MnJBSVJnL1FXdnhqcG5VRVlPdVFhdHVh?= =?utf-8?B?WStSYTlnYWlPWGVMclVWQUNVc1VpZ0FoanVHNFF2R2NFNmgrTE85dDNHaTFs?= =?utf-8?B?aXJUS01PaEZrazlTZmM0TVFNTkFNbU5mQVZFaXdhU3EwMHk3aGU4dWZSbXJr?= =?utf-8?B?bVdNOVQvOWluTDREZmxucDVhdHUydEg4RERGSXBncDhNcC9rWmh3TEVsWGFx?= =?utf-8?B?cDlIVEJHNmlNVXljNGpiallFczRKblpITTJUeVEveitaN1gwV2VmTEJLV1cv?= =?utf-8?B?QW04YkpMOTdrbDRBUWh1WXFXM3ZVSmt2YUFKSHl0bm9FRnZRMkx2M0dwZ1lQ?= =?utf-8?B?REVJNS9wQnllN2pCVGdURkF2MFQ5dzJpY3hNSUhhY3hnTitjOEpiZXFHMVpk?= =?utf-8?B?MTZ0d0xXNWFVdVFCRjZ0bjBGbWF3TGxVRm1jYkdTekpzd29SNjR3TmR6Rkp3?= =?utf-8?B?ekc0eHluMmp4Znp2Sm85T2FtckJBczZuWUJvdGJFYTJyVzRrMjRFREkyWWhW?= =?utf-8?B?TzhubTJOdzVXMGhmY1dxMEtXejJ2bVQ1bGplMStZaDVRa0hmWmNSOG4va3Zv?= =?utf-8?B?dVR6STV1Rnl6Y1JVTnVzNWFpSFh0bjlFclZadHVPeFk2K3ZXV2VXQmU2SXp0?= =?utf-8?B?RDVIVVg5eFJQWHhEUlZjdjducDY4MkFjMHJ4bjI5SElLc0s5bk9rNlFpM2dz?= =?utf-8?B?NHowQmZaNGRpNGRmK1JEZnNrZktpOFVIL2wwUW9MNEtsZ2U3RzMwSGZkWGFi?= =?utf-8?B?NTgrRS9GK21HemEzYktES3lMYzRzWEFMN2E3andxRWZTWVFDdEFSNmx1Z1ov?= =?utf-8?B?ZWE4SjRwOTFJTEw4RFlPSVFaQWNvVEVFNE1vZldTZmtzcGZUY3VNelJFbnJt?= =?utf-8?B?U20zYW9Kc24xM014TGVCeEFnSnRzRDlLL0FZMkNpUHlIYmlsTkNYRXlzSUwz?= =?utf-8?B?TXpEOXR6b0VJVEpHMHM5ZVlxRGE3MzYyc0o2YVNyRXliYXFRVmg5Y3ZrajZq?= =?utf-8?B?S0xrZEZOZkpySFBWNmN4bHRCaWhJSXVvaFliTHpmWXNzTWQyMWZTd1dqU09N?= =?utf-8?B?OFEzQlhMQ2tPSnlqclVHVW5JNFFSOGxscUkzQldyNEZhMXhOenZya2diV0hj?= =?utf-8?B?UDRaZ0tPUWR2VTQ4V2VqYlphVHk1QjV4V1pPakQ2djNaMVJTN29ZZmFXdVlX?= =?utf-8?Q?g1Ascvz9B933au6pe6?= X-Microsoft-Antispam-Message-Info: BlokVg8I6cf9un1lxCGQHOsGVK5cyPwsiIf0lOSEiqZjLJ8QoCPBPFA5dw3AR2SHfpcdUmwhagEcgTapuuFIqG8Mgnepe9axCRLufjXYPO1elyriWepP5PdwtkFwCzp6XOU/WHrkLPTNV0esuh5TkSj69k7NUb3tdruBOz6sibzUIlzzKxtLGF/kqixpAtiiMlXlciI2JverGwIzkglS7Vfyrk/rqJIfJgevD/7ZL3cR8/GWYL2bNKA5NY94X+U1SL+SOnU0URA32g1NxR/lPUjpQrf5BuB05LzA6ltfLBX74GR+HKxEg3oS5g1bIs8wzdoe//g4e8c/Oi8/0mb4oITEVfFIXPT30cX0MH9sSxU= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4891; 6:S85YJlW7Ad1nTUNqW2Y2YmX8LiIVlFTXBZkY0MsF6JZ5pL5HhMZ1oZdM7ccMVzDQEfI24eZKp3Y2cQPap0aXVPBale82XmjySJYoDQUrp/DUES8lkxCE6s9ZxvF3nvZcy/gwTK4VkczbQFcYIGs00NSDNlNdUXtO11qTqKNmMm9Kc3dNWb5HaiWYzeHdu8DIGh7xuJB/qVR8YYBybAvGcZv89MBD1uDWRcZDfMbD/NgFFpKKIDKPgovxliHPmMDDjdD0W5tOCBSKW5D0h/pfUQBHweqtAPgGhjtM1U4v9kFUJtL0K7OWhX+nFoxaoNFKt+oqqJ/vsS6uDnM5W9YSRHh+MhfTwPgb1VuxdRMVoYw9sijJZkES64B5lziy+McytFOWDh3csh9cygbZK7ZjvQe1MymJws6pnl8JzwqFaMyunPCzSDPEHgkVONP/9Au/HZ9t0xgJ8G7AL3wij7hw5A==; 5:V5Ajr9S8BSaQ/Oa4JLs6hVfU5YzRtIsRMlzaMb63NEAFlWNjDxiz7R0501+L4EyKXNIwWTvZVTSfK9Az7hOHT/nh424mY19/j2I1/ZsSHCjTN94VCTqV3fNC3eqeiXgVD68njsJdEeodBaEdSTk/HdfJ/jgoHPqQA9qE/++c6fg=; 7:zGMrI/QolciZjPaGbriMU7bsPmkxtpN8YEZr/qsNofGNPrAq+uOrQbmLwGyf2pq0qI7tX34Qzs/gvjwvezYq/2GuGNtWGyh7EpxMKMdn1aAIjG04vWSHq4kdz/1QXpvCRxspq/1/Od0hECzKyGVCORIHHPjOrjnzL4UKcV42ud+N7kRwcFiz6s5tIGeEzk39MiYmpGk+nWpsKeu52ycaTwWNOEAerggJTEDDNtLu1Bnxo7cyNrp9Q/tdNoWpFHEj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 12:20:34.8631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45531cce-1863-48eb-b7b0-08d61c97f99d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4891 Subject: Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 12:20:38 -0000 On 9/17/2018 5:12 PM, Joseph, Anoob wrote: > Hi Akhil, > On 17-09-2018 16:07, Akhil Goyal wrote: >> External Email >>>> I think it would be better to squash the makefile related changes in >>>> the 3/33 patch as the code >>>> is actually added in that and here the code is not getting compiled >>>> here. >>> So the changes in the following files has to be moved to patch 3/33? >>>   drivers/crypto/Makefile >>>   drivers/crypto/meson.build >>>   drivers/crypto/octeontx/Makefile >>>   drivers/crypto/octeontx/meson.build >>>   mk/rte.app.mk >>> I think this patch will just have MAINTAINER edit (even that might be >>> required to be moved to 3/33?) & changes to config/common_base, after >>> that. Is that fine? >> In my opinion, you do not need this patch as separate one. >> config/common_base can also be added in the 3/33. > In that case 02/33 patch would become the first patch right? The same > problem would be there too, I guess. The macros added in that patch gets > used only in 03/33 patch. Is that fine? I think that would be fine. Better to have a 03/33 patch before 02/33 if it doesn't have dependencies. > The first patch would be a shell patch for most PMD additions. That's > the reason we started this way. If you want it changed, will do so. > Please do let me know what will be the right approach. For the makefiles, you would be compiling the empty files which does not have any code. That does not make any sense to me. Normally, when we submit a new PMD, we add the basic PMD probe/remove in the first patch and add it into build system. Maintainers is also updated for the new PMD. Further ops are added later in the patchset. Hardware specific header files/ functions are added before they are used in the driver in a single/multiple logical patches. In the end, documentation is added along with release note and MAINTAINERS update for documentation files. - Akhil