DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>
Cc: Declan Doherty <declan.doherty@intel.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	Chas Williams <chas3@att.com>,
	kiran.kokkilagadda@caviumnetworks.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers/bonding: fix bond mac address reset
Date: Fri, 15 Jun 2018 14:26:32 +0100	[thread overview]
Message-ID: <06b8f88d-a256-d3a0-69db-52e2d38ec31c@intel.com> (raw)
In-Reply-To: <CAG2-GkmHr5EyFGJd-nLfecEikW-t8U9Yv106EoY8qLPqG-8QqQ@mail.gmail.com>

On 6/14/2018 9:38 PM, Chas Williams wrote:
> 
> 
> On Thu, Jun 14, 2018 at 12:49 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 5/23/2018 10:11 AM, Kiran Kumar wrote:
>     > Currently when resetting bond mac address, we are getting the
>     > persisted mac address from slave info considering primary port
>     > as index. But we need to compare the port id from slave info
>     > with the primary port to get the primary slave index and get
>     > the persisted mac address. Without this fix, persisted mac addr
>     > will be zero and rte_eth_dev_default_mac_addr_set will fail.
>     >
>     > Fixes: a45b288ef21a ("bond: support link status polling")
>     >
>     > Signed-off-by: Kiran Kumar <kiran.kokkilagadda@caviumnetworks.com
>     <mailto:kiran.kokkilagadda@caviumnetworks.com>>
> 
>     Hi Declan, Radu, Chas,
> 
>     If there is no objection, the patch will be merged as it is.
>     Can you please check?
> 
> 
> No objections. This patch looks correct.

Applied to dpdk-next-net/master, thanks.

      reply	other threads:[~2018-06-15 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  9:11 Kiran Kumar
2018-06-14 16:49 ` Ferruh Yigit
2018-06-14 20:38   ` Chas Williams
2018-06-15 13:26     ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06b8f88d-a256-d3a0-69db-52e2d38ec31c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=3chas3@gmail.com \
    --cc=chas3@att.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=kiran.kokkilagadda@caviumnetworks.com \
    --cc=radu.nicolau@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).