From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E030A00C4; Fri, 1 Jul 2022 15:43:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED6A442670; Fri, 1 Jul 2022 15:43:07 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 059E74069D; Fri, 1 Jul 2022 15:43:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656682986; x=1688218986; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=/vroO98/xAQQa3qRkv9dWLeExxVoMTCxt1eCmMKw+hQ=; b=S/Dq63LIH03RHAwO3yu3NOIroBptGcbYoHTeZLQrXLaphJyQt8ZTbIYe a7bnpW5maFpAiZhQvc0blCTr7wZ7yzboBuAGHgs3lITBN/m5vj046lmxT iRUTCFvsOC8hJghw/RudCW9onxna/BLctuxUgniTJthKk7xBMLAMSL5Nk I4QBuqLkVfcnfMdbNxNRuKNfYwhUDQUSppEtsNBqdGSD1c9uFrY7KIdQL B1Jn0weH4yBXzeH9TKc6F16AwAWqzwdi0XFeSxC/kd3WuswqVddurDnEW ZCnbbO9iUnBvVo550eXXCcZRvi9mK+IeSWLjtw5Q0g5Iv6NM7kvfepTRe A==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="283386815" X-IronPort-AV: E=Sophos;i="5.92,237,1650956400"; d="scan'208";a="283386815" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2022 06:43:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,237,1650956400"; d="scan'208";a="648351357" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 01 Jul 2022 06:43:04 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 1 Jul 2022 06:43:04 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 1 Jul 2022 06:43:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 1 Jul 2022 06:43:03 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 1 Jul 2022 06:43:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KCqeUeQByKrZ5c21kB8J5SiXtaHqZLNgQgPUl3FRz2oteyiANYjRfnnMzHTDZP9tjV8QF/r9ZberemMCkXBT6MDvZGaimlwD+SCCuKjRaV+ztqi3W1IlpBse6pphf1za5MdRYM8J5yHsNpFqJIL+9L6jg6lq6w5mSJBUuFJndbiMLcqMT8h82LDdFyhqvp12p87NNuzPP2Xf7GZEw/AhfQhZc6FS4rxxR+LdeM/LqxkHtxVTsjnpEQjlCdoPyvVVnCWUwbbWLCA37YJ/VadMTVVs/Wqznjnxa7Tx3zPruquFadHmspJzn8I4zsv4Fcd+Tb1qVPsbwHoXr+KKZpAK1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VOccXpDe1gaYDwmpUjKNzEBcmSnM7tIpyJnLImZmgIM=; b=Ackt0RV1cQRuNJ+pg7ujWZLNTp1XhEtJHoFGNPCz9KJnSkoKO+PrNkRjTsqFNurw9rXgUQr3GEWpRPfWwASPH/FBI2FIIpLLghPM/aF/ZsUSeyEw1DoXTwv//K13NJ+gntKfLtrAdG64M4BQb7A9FUHzGn9Hy/oX1T0V9HHy48GvOHZTOwr7aiZJNa/swBDeLEzVNXmwN0mQezFshbiMVO4PDYwlq9v6bAQ+toCIUiIfGxZXllD07gu/teBM9obXhfkDam7/mTJOxnSI6DQCTSox6q0ifCsVPW0r020LnioV+aKFUFmxQ7hJx68ddYpMbyeJ7YMe/xzC+2iko79SLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by CY4PR11MB1495.namprd11.prod.outlook.com (2603:10b6:910:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 13:43:00 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::2890:cc50:6923:e01d]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::2890:cc50:6923:e01d%6]) with mapi id 15.20.5373.018; Fri, 1 Jul 2022 13:43:00 +0000 Message-ID: <06cc95e0-c186-3827-26a3-5efb809f73ee@intel.com> Date: Fri, 1 Jul 2022 19:12:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] app/testpmd: fix GTP PSC raw processing Content-Language: en-US To: Gregory Etelson , CC: , , , Ori Kam , Yuying Zhang , "Viacheslav Ovsiienko" References: <20220630125055.19719-1-getelson@nvidia.com> From: "Singh, Aman Deep" In-Reply-To: <20220630125055.19719-1-getelson@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0070.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:23::15) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 840ad142-773b-48c0-cff1-08da5b679d6f X-MS-TrafficTypeDiagnostic: CY4PR11MB1495:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hERiryNmJAbPtt3FraYxiJpRCB8mSJMEn3DsNKD4eYITPyH+BrEbu/mCaqAf0nVZyf3Y7ENM0n+bdhNa5lfr++L0Zi1VWM12fj+jOygpAntArD7/tvegHrvqfWgYfANO5Fxb+KNh0+XpW+3qqf7VH3EYiW6f1CDckrlCojOvW+fUci1A75YYYIvGNaiqSHVMeaf80FsVBqtEv+sGnHnVHa78Voe0eihoSG2MtUPf6eqV/Ob+YYT4ubjI0LLq07NTbqm5230mK5EWHzvF/JBPZLKuoz8anrUqr3e7EAfe55nKqClYXHoG1DvvE6HU+1h/rhMapRa7fEJQCSosvIVZ4Tev/RPr8EIInB3+kBqvAkx6jc0uTwZvjg3Q1ug/Le7m6dI04wBoaKWmYLEwqrhB5NjnJSjFoYN90iSAEaaGKeDrbOMrqQlOtdLnO2GMi4Wsy3MfPdCr6x+M6Q4hvkN7VIzi2E715ROTK7GyMAQXcnVO9DgQnpCnpCU5hwVNTpujMZnieyQ+fM8ksoUmneh8WUrz+jQT4yCE1csycI5z983IVZDXhiEPy7Xz2EZ4e7HVb8QVif5qGIfchRJqY6qKX2gyxX1/FhS+2t2nIeZB3UxkyM+d1Co4ugLZQLp9cMzlZnbVfBPzJCqhy0H6LSICdnWKVdoX+xJ4j50UNqwrAPDqTh18jItnFH5jZaZVVe79TfLSy/qwktgDd2an5IERXGTRz2qemudTYpR0ryt0Hlb5Eq5erc9sbmu2/fXyOD6NPj9+4uGegT7RHrcLzy8Fux6a9y4Y3hmCsI6SEJrHdztyPMgrei0+LjSYzmfwvHThGCgpSd7+5IMJyv5jiFxj+i5gEdCM0bon0A3H2WzavMM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39860400002)(136003)(376002)(396003)(346002)(2616005)(8676002)(4326008)(66556008)(66476007)(66946007)(5660300002)(86362001)(186003)(8936002)(41300700001)(6486002)(82960400001)(31696002)(6666004)(478600001)(53546011)(316002)(6512007)(26005)(6506007)(54906003)(83380400001)(2906002)(36756003)(38100700002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWhqQVJ5WUtjMHBMd1lBdEY5OWxYZGNxcHVFdlJCT3lqTUQwZkNvc0tDdjFy?= =?utf-8?B?SWdYQmlUSW9Sb3JPQkJkeEhqYytNV2l5MlJiVExuM1U5WC9saEJNS1hsR2tB?= =?utf-8?B?dFMwLy9NR0h3VFNucDJOOVc3TVFYNWZaYlNRWlpFZzQ1dWZqRWQwQlF4eHpT?= =?utf-8?B?eTVNblRnblVnL1htRnEwM3pvajZZVGRsN1dNR1hLVkxYV3pKOHhvTjdkTDhh?= =?utf-8?B?Ym1xUG5sZGJ6cy9XUUJzYVhBeGJ3WGpwa3kweDNnQjZ1TExMM3cxQWpJT3Rn?= =?utf-8?B?aFg0N1NJanBxbmh6Sk1Sb2hNQmhvZXhkSndmdk5GOUgwK1lGVTRWaFdaV25l?= =?utf-8?B?SDdjbnNXZ3p4ZyttODMzT01VcVgreThUbndBMlkvUXhIenlmREp0S0gxRnZH?= =?utf-8?B?Q2E0cUM2SHF0OWlxYzl3aGtkcjJ3TW1kVHkzWitITktGWktHM2FRd1lSYzlk?= =?utf-8?B?bkVCeWlNbm9hYWY3ZTc3S3Z6Vy9pL0NLbTg1R1dRNFZISFlURVNXb2djenMx?= =?utf-8?B?R0QxYVhNaWdNY2cwUFRoRzh3OVRzQVZsYW5WNGNxRGlITHlUQ2o1MkUxSDNz?= =?utf-8?B?T1dDOGxod2tLQ0RPcjh3WDMvR3VDZ2w5T21jSVc2RUlQSGN1aDRUR3dab1J2?= =?utf-8?B?NytLWXhBelh5NElmS1l0VkdpWlVKdi81dENoQWgreE94b3d4WEplQlhwc0VK?= =?utf-8?B?cVB1NTV2dTVOVDJLYzBZQ1QyQzVsMGltUFdqdVJWY3AxQXZ0MDlkZktOZCs2?= =?utf-8?B?b0l4Q2dVcjZTeG05bWsvS1pKT0lwVjA1UFMwK2xsOTM0dFhvMHNQOGRQZGdn?= =?utf-8?B?dUtVS09vck0xS1c2NXZQR1c4bCtxdVJYcWFJdnVQZTJDRDJHcG1iSnFBSjBN?= =?utf-8?B?THVRSmRWMUVZTWZPVTRYdzBKSm9ueUo1MXd5aE5obGtLRS9xdkQ5eHlCakp0?= =?utf-8?B?LzdxQjZtM0JVR0M0ais3MUxOKzYxV0JoRzIwSlR1Wit1cytTejZqKzR4MVVO?= =?utf-8?B?MnBkSkwvUlEvYlZqblIwNlMwSVdZQVorNHlpMDZvY3FINGI2Q1ROeG9PQjhJ?= =?utf-8?B?UHBPMHhkelJQTVJrUW0raE4wSi8wYUF6TFY0ejRLU0Y1Y2NYMDcrYnVMeG9V?= =?utf-8?B?Rk9zbUI5V1FjRHV3VEtYNkxabE0vZkdqbERLOGJSZ3NpWkpudjcvVFdrN0oz?= =?utf-8?B?U3FkblNJcW9MbzhhVTN3bzhsN1N6Z1dUM2U5ZW8wcE5XUW1nT1ZHaTViTit6?= =?utf-8?B?Y3FwOEdVRk9hV0w0TW84WGwyNjlDVmYrR2FWandxZ3RQTFVIcFpWNThvM25P?= =?utf-8?B?K1YrZVBNU05qSytHaDhQbjQwRmpMWHIrYXozbFBMS1NOdmVnUkpwWjh2bXBY?= =?utf-8?B?UDJWOThmVG04SUlPcDdSVG9IQVMzcWNOUmUvMkZ6V1Y0WENaS1ZLWHNDOTdS?= =?utf-8?B?VWJ3WXJsNldIcEpwc2RhY0k2eUtXSkYwMWxKUnZ0d1BxalZwbHJFNUxWTTlD?= =?utf-8?B?cDJZY2tXaU9pMUIzYVJIeWJjVHh5aE5sL2MrNUpFMHozNmJGK0NVRS8wSmhL?= =?utf-8?B?eG9FSDA2MkpCenpKb1dJaXgxZ3dvelhEZDdibElnV0NXMjVOSUZta25KNTBJ?= =?utf-8?B?UjBGcWdTcmh5ZksyZGZzTTY0cVRNUHNyMklBZWxSSGs4SjBGVUpYVzNzSVQ3?= =?utf-8?B?aTlJWGlpT1JmWXBkblpyMGR1NDRqc215OWptTzluUEoxN1lEdnNkRlVaM0V5?= =?utf-8?B?THlOKzUvcXJsMkpwc1Jjdml2SEpDb0JnOHl4bFovRG5pdi9oTTczbFBjbXgr?= =?utf-8?B?NG12dnBHcUM2NDNkR3A2TjNQRzB5S1ZIdFowS0lIQjN0c1dLM0k1UG9VMEtp?= =?utf-8?B?ZUh6QjFOWWV0SzdmdVcwRGMvcURtamdZRFN0QmtMYUxOb0hZcUtnOHlqQmJh?= =?utf-8?B?dE9rZDJEbEpkSDRFVG9tMEcxTTQ0blJiVG1BYTB5UlhNZXZITHpoVkZwdHBl?= =?utf-8?B?QjU5SGhWOFZ1WUlrOFM4bGZlb3ZlOHhSY3lRbkVoN096TFBWN25JSlovVm9E?= =?utf-8?B?a3VjVVpTZ1FpM0IxbU1DY2Vxd3R6ZGZNeDdHWGR2eTlEMkpLQzNvWm5XdE42?= =?utf-8?B?WWtkeG9zblBLY25OeDB5cDJtanVtd2x0YlF0UksycU8zTUFDcmUzYmhPbnZY?= =?utf-8?B?bXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 840ad142-773b-48c0-cff1-08da5b679d6f X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 13:43:00.8549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1DqFnzJYhQjb5TAqLRHWPuwHTq++uuob5Ssiqj6P+cKcgA0KpkwjobetLli56yR86cK2p22hySGY2SnLL/VyaEYchSQwFBzyY+z2Xwxt8fY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1495 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gregory, On 6/30/2022 6:20 PM, Gregory Etelson wrote: > Fix GTP PSP extension size initialization. > Clear input buffer. > > cc: stable@dpdk.org > > Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing") > Signed-off-by: Gregory Etelson > --- > app/test-pmd/cmdline_flow.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 6cb1173385..7f50028eb7 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -11030,10 +11030,12 @@ cmd_set_raw_parsed(const struct buffer *in) > const struct rte_flow_item_gtp_psc > *opt = item->spec; > struct rte_gtp_psc_generic_hdr *hdr; > - > - *total_size += RTE_ALIGN(sizeof(hdr), > + size_t hdr_size = RTE_ALIGN(sizeof(*hdr), > sizeof(int32_t)); we missed sizeof(*hdr), last time. Ok now. > + > + *total_size += hdr_size; > hdr = (typeof(hdr))(data_tail - (*total_size)); > + memset(hdr, 0, hdr_size); Is this memset adding a value here ? > *hdr = opt->hdr; > hdr->ext_hdr_len = 1; > gtp_psc = i;