From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 752CD2BB1 for ; Thu, 2 May 2019 10:33:08 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 065235EA570885867021 for ; Thu, 2 May 2019 16:33:06 +0800 (CST) Received: from [127.0.0.1] (10.177.131.206) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Thu, 2 May 2019 16:33:00 +0800 To: "Varghese, Vipin" , "dev@dpdk.org" CC: "Burakov, Anatoly" References: <1556624124-54930-2-git-send-email-mousuanming@huawei.com> <1556774432-59147-1-git-send-email-mousuanming@huawei.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D340270@BGSMSX101.gar.corp.intel.com> From: Suanming.Mou Message-ID: <06d176dd-19f7-4aec-fe5f-8c7018359c07@huawei.com> Date: Thu, 2 May 2019 16:32:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D340270@BGSMSX101.gar.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.177.131.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 08:33:08 -0000 On 2019/5/2 16:04, Varghese, Vipin wrote: > Hi Suanming, > > snipped >> /* true if x is a power of 2 */ >> #define POWEROF2(x) ((((x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct > Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`? I'm sorry, but that line is not add by this patch this time. Maybe another commit is more suitable to fix the previous code. > >> parse_val { } >> >> static void >> +monitor_primary(void *arg __rte_unused) { >> + if (quit_signal) >> + return; >> + >> + if (rte_eal_primary_proc_alive(NULL)) >> + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, >> NULL); >> + else >> + quit_signal = 1; >> +} > This is suggestion, why not omit else part with > > ` > if (rte_eal_primary_proc_alive(NULL)) { > rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary,NULL); > return; > } > ` Thanks for the suggestion. It's OK for me. If there's one more vote, I will do it. > > Snipped > > As suggested in v4 can you update the `pdump.rst` on the new behaviour? As noted in the cover letter in v5. The `exit with primary` configuration should be made as default or not is still not confirmed from the maintainer. Since `exit with primary` is now removed in the patch and made as default per Anatoly's suggestion and not get more information from the maintainer, the update of the doc is also got hung up. > > Thanks > Vipin Varghese > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 29569A0AC5 for ; Thu, 2 May 2019 10:33:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0863F2BC1; Thu, 2 May 2019 10:33:10 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 752CD2BB1 for ; Thu, 2 May 2019 10:33:08 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 065235EA570885867021 for ; Thu, 2 May 2019 16:33:06 +0800 (CST) Received: from [127.0.0.1] (10.177.131.206) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Thu, 2 May 2019 16:33:00 +0800 To: "Varghese, Vipin" , "dev@dpdk.org" CC: "Burakov, Anatoly" References: <1556624124-54930-2-git-send-email-mousuanming@huawei.com> <1556774432-59147-1-git-send-email-mousuanming@huawei.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D340270@BGSMSX101.gar.corp.intel.com> From: Suanming.Mou Message-ID: <06d176dd-19f7-4aec-fe5f-8c7018359c07@huawei.com> Date: Thu, 2 May 2019 16:32:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D340270@BGSMSX101.gar.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.177.131.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502083249.X5xuzhCzebMLQ_yurMIZKKGfwSbDr0Tx4pl5WTPJiAU@z> On 2019/5/2 16:04, Varghese, Vipin wrote: > Hi Suanming, > > snipped >> /* true if x is a power of 2 */ >> #define POWEROF2(x) ((((x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct > Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`? I'm sorry, but that line is not add by this patch this time. Maybe another commit is more suitable to fix the previous code. > >> parse_val { } >> >> static void >> +monitor_primary(void *arg __rte_unused) { >> + if (quit_signal) >> + return; >> + >> + if (rte_eal_primary_proc_alive(NULL)) >> + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, >> NULL); >> + else >> + quit_signal = 1; >> +} > This is suggestion, why not omit else part with > > ` > if (rte_eal_primary_proc_alive(NULL)) { > rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary,NULL); > return; > } > ` Thanks for the suggestion. It's OK for me. If there's one more vote, I will do it. > > Snipped > > As suggested in v4 can you update the `pdump.rst` on the new behaviour? As noted in the cover letter in v5. The `exit with primary` configuration should be made as default or not is still not confirmed from the maintainer. Since `exit with primary` is now removed in the patch and made as default per Anatoly's suggestion and not get more information from the maintainer, the update of the doc is also got hung up. > > Thanks > Vipin Varghese > >