From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 73F582C24 for ; Tue, 2 Oct 2018 15:20:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 06:20:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,332,1534834800"; d="scan'208";a="267753350" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 06:20:00 -0700 To: Xiaolong Ye , dev@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang Cc: xiao.w.wang@intel.com, Rami Rosen , Wang Haiyue References: <20180928112344.42791-1-xiaolong.ye@intel.com> <20180928214747.48938-1-xiaolong.ye@intel.com> <20180928214747.48938-2-xiaolong.ye@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <07075871-63c3-7773-ba89-00155cc7cba7@intel.com> Date: Tue, 2 Oct 2018 14:19:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928214747.48938-2-xiaolong.ye@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 1/2] vhost: introduce API to get vDPA device number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 13:20:04 -0000 On 9/28/2018 10:47 PM, Xiaolong Ye wrote: > It's used to get number of available registered vDPA devices. > > Signed-off-by: Xiaolong Ye > Acked-by: Xiao Wang > Reviewed-by: Maxime Coquelin > --- > lib/librte_vhost/rte_vdpa.h | 3 +++ > lib/librte_vhost/rte_vhost_version.map | 1 + > lib/librte_vhost/vdpa.c | 6 ++++++ > 3 files changed, 10 insertions(+) > > diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h > index 90465ca26..b8223e337 100644 > --- a/lib/librte_vhost/rte_vdpa.h > +++ b/lib/librte_vhost/rte_vdpa.h > @@ -84,4 +84,7 @@ rte_vdpa_find_device_id(struct rte_vdpa_dev_addr *addr); > struct rte_vdpa_device * __rte_experimental > rte_vdpa_get_device(int did); > > +/* Get current available vdpa device number */ > +int __rte_experimental > +rte_vdpa_get_device_num(void); Hi Xiaolong, Is rte_vdpa_get_device_num() an public API? (It should be since it will be used in an application in next patch.) If so, header needs to be part of API documentation: 1- Update doc/api/doxy-api-index.md to include this header. 2- Update all APIs comments to be an doxygen comment. 3- Add doxygen comment to all data structures. I can see rte_vdpa.h not documented at all, it is not just this API, so it can be better to send a new patch to address above items. Thanks, ferruh