From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AEBFF108A for ; Tue, 7 Mar 2017 14:21:21 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2017 05:21:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,258,1484035200"; d="scan'208";a="233232671" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.191.241]) ([10.254.191.241]) by fmsmga004.fm.intel.com with ESMTP; 07 Mar 2017 05:21:19 -0800 To: Andrew Rybchenko , dev@dpdk.org References: <1488470591-5853-1-git-send-email-arybchenko@solarflare.com> <1488470591-5853-6-git-send-email-arybchenko@solarflare.com> Cc: Roman Zhukov From: Ferruh Yigit Message-ID: <070b835f-918d-da6a-8aef-a658606e066a@intel.com> Date: Tue, 7 Mar 2017 13:21:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1488470591-5853-6-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 05/11] net/sfc: add flow API filters support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 13:21:22 -0000 On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: > From: Roman Zhukov > > Only pattern items VOID, ETH and actions VOID, QUEUE is now > supported. > > Signed-off-by: Roman Zhukov > Signed-off-by: Andrew Rybchenko <...> > diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c > new file mode 100644 > index 0000000..0590756 > --- /dev/null > +++ b/drivers/net/sfc/sfc_flow.c > @@ -0,0 +1,693 @@ > +/*- > + * Copyright (c) 2017 Solarflare Communications Inc. > + * All rights reserved. Missing "BSD LICENSE" line. This is same for all new files. I think this discussed before, I don't know if that line is mandatory, but can be good to have at least to be consistent to rest of the codes. <...> > +/* > + * At now flow API is implemented in such a manner that each > + * flow rule is converted to a hardware filter. > + * All elements of flow rule (attributes, pattern items, actions) > + * correspond to one or more fields in the efx_filter_spec_s structure > + * that is responsible for the hardware filter. > + */ > + > +enum sfc_flow_item_layers { > + SFC_FLOW_ITEM_ANY_LAYER = 0, > + SFC_FLOW_ITEM_START_LAYER = 1, > + SFC_FLOW_ITEM_L2 = 2, > + SFC_FLOW_ITEM_L3 = 3, > + SFC_FLOW_ITEM_L4 = 4, > +}; No need to explicitly assign default values. <...>