From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB903A0C43; Wed, 20 Oct 2021 11:56:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A1E640687; Wed, 20 Oct 2021 11:56:00 +0200 (CEST) Received: from mail-108-mta141.mxroute.com (mail-108-mta141.mxroute.com [136.175.108.141]) by mails.dpdk.org (Postfix) with ESMTP id 200AB40142 for ; Wed, 20 Oct 2021 11:55:59 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta141.mxroute.com (ZoneMTA) with ESMTPSA id 17c9d20edbf0000b55.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 20 Oct 2021 09:55:53 +0000 X-Zone-Loop: f457afe25aa435980de766486fb2ded71c21fb7c78ce X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc: To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5GQQ0gDZGCZ//Vx7eqvfH9pVrmx3F6t39Oi71fcRH5E=; b=Z0544PeU7SYnDh0LfgGWlQNv/s 0kcFgqEMT/XmyeJGoChj8N9KpmTSH19uRp8U/uoDuSE0q4v6kKeFSarjW3ceH1kdBoVfxl6L4clMh IzwBraLhdoJV3HCqTuPJ2iPWhKFYGohgEjHAaIpYspely0wwRVGcaeb/7jlUBlRKqw7mkT0QEa2ry VnV58lqxjzR29nuCZyjS05I0xjJkRSnkKAWVU9RngqxbdMsv82nSKyiutynzrZ1ol+itmZ0qyiOBO K65DvDhUgvP9xmreDsTpEETd9Yg+TUSFPnSeyg8rGoW8g88uO3mZtBCsRuDgAiJjRxAkuzJoRY27D j8GxeLMw==; Message-ID: <070e57af-75e2-12f9-df54-ca0736051dcd@ashroe.eu> Date: Wed, 20 Oct 2021 10:55:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-US To: Thomas Monjalon , David Marchand , Rahul Shah Cc: dev@dpdk.org, Cristian Dumitrescu References: <20210909164008.343712-1-rahul.r.shah@intel.com> <1646223.B9qMf3zQby@thomas> From: "Kinsella, Ray" In-Reply-To: <1646223.B9qMf3zQby@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, URIBL_BLOCKED=0, FROM_HAS_DN=0, TO_DN_SOME=0, MIME_GOOD=-0.1, FROM_EQ_ENVFROM=0, MIME_TRACE=0, RCVD_COUNT_ZERO=0, RCPT_COUNT_FIVE=0, MID_RHS_MATCH_FROM=0, NEURAL_SPAM=0] Subject: Re: [dpdk-dev] [PATCH] port: eventdev port api promoted X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/10/2021 13:12, Thomas Monjalon wrote: > +Cc Cristian, the maintainer > > 10/09/2021 15:40, Kinsella, Ray: >> On 10/09/2021 08:36, David Marchand wrote: >>> On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: >>>> On 09/09/2021 17:40, Rahul Shah wrote: >>>>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, >>>>> rte_port_eventdev_writer_ops symbols promoted >>>>> >>>>> Signed-off-by: Rahul Shah >>>>> --- >>>>> lib/port/version.map | 8 +++----- >>>>> 1 file changed, 3 insertions(+), 5 deletions(-) >>>> >>>> Hi Rahul, >>>> >>>> You need to strip the __rte_experimental attribute in the header file also. >>> >>> That's what I first thought... but those are variables, and there were >>> not marked in the header. >> >> My mistake - should have checked. >> >>> At least, those symbols must be alphabetically sorted in version.map. >>> >>> About checking for experimental mark on variables... I had a patch, >>> but never got it in. >>> I think we should instead (forbid such exports and|insist on) rework >>> API / libraries that rely on public variables. >> >> I'll pull together a script to identify all the variables in DPDK. >> Are you expecting the rework on the port api to be done prior to 21.11? > > Does it mean we should not promote these variables? > > So the net-net is that variables are almost impossible to version. Think about maintaining two parallel versions of the same variable, and having to track and reconcile state between them. So variables are make ABI versioning (and maintenance) harder, and are best avoided. In this particular case. I would suggest leaving these as experimental and improving the API, post 21.11. Ray K