From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: fix permissions when using make install
Date: Thu, 9 Aug 2018 18:10:44 +0100 [thread overview]
Message-ID: <07127a19-8300-8c0c-41d1-2ec35bf36bbd@intel.com> (raw)
In-Reply-To: <2177083.Ak4RRs4Y8F@xps>
On 8/9/2018 5:16 PM, Thomas Monjalon wrote:
> 09/08/2018 17:22, Bruce Richardson:
>> When using make install, the permissions of the resulting file should be
>> those of the user using make install, not those of the user who ran the
>> build. This would not be the case when a user explicitly runs:
>>
>> "make && sudo make install"
>>
>> Fix this by changing "cp -a", which preserves all attributes, to
>> "cp -dR --preserve=timestamp", and by adding the flags
>> "--no-same-owner --no-same-permissions" to the calls to tar.
>>
>> Fixes: 1fa0fd9d6b42 ("mk: allow to specify DESTDIR in build rule")
>> Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree")
>> Fixes: 576de42b83e5 ("doc: render and install man pages")
>>
>> CC: stable@dpdk.org
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>>
> Applied, thanks
Already applied, but to keep record:
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2018-08-09 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 15:22 [dpdk-dev] " Bruce Richardson
2018-08-09 16:16 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-08-09 17:10 ` Ferruh Yigit [this message]
2018-08-09 17:38 ` [dpdk-dev] " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07127a19-8300-8c0c-41d1-2ec35bf36bbd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).