From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BAD1A0350; Mon, 29 Jun 2020 10:21:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BEC551B13C; Mon, 29 Jun 2020 10:21:06 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6254D2C01; Mon, 29 Jun 2020 10:21:04 +0200 (CEST) IronPort-SDR: kPq5tCR90w0EkrXS2wTWTO8g8daGF20U+6zClaoWEJoRkurVZ9A222QEJ7HMu9/AEBuz5CUP38 S22Wx3CxyUnw== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="125555390" X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="125555390" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 01:21:02 -0700 IronPort-SDR: nVXuMnzCf1BnIKD6CqFVqx3Tnl9x3Un6QC/yb5y+NzowCwrGnpr9uDCW+HYmsrbLvUSMPS0/gf Kgn/LwXHLwzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="280791820" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.178]) ([10.67.68.178]) by orsmga006.jf.intel.com with ESMTP; 29 Jun 2020 01:21:00 -0700 To: Wei Zhao , dev@dpdk.org Cc: stable@dpdk.org, qi.z.zhang@intel.com, ferruh.yigit@intel.com References: <20200628061255.68963-1-wei.zhao1@intel.com> From: Jeff Guo Message-ID: <071506a2-87c4-a94b-7f7c-d5100cb3f801@intel.com> Date: Mon, 29 Jun 2020 16:21:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200628061255.68963-1-wei.zhao1@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: enable 10Mb/s speed for x553 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, wei On 6/28/2020 2:12 PM, Wei Zhao wrote: > For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M > link speed, so enable it for the kind of ixgbe nic. This is not an enabling patch i think, it just add the support link speed info for specific nic, so suggest you refine the commit log and bring my ack at coming version. > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Wei Zhao > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index f8a84c565..d812579fe 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, > link.link_speed = ETH_SPEED_NUM_100M; > break; > > + case IXGBE_LINK_SPEED_10_FULL: > + link.link_speed = ETH_SPEED_NUM_10M; > + break; > + > case IXGBE_LINK_SPEED_100_FULL: > link.link_speed = ETH_SPEED_NUM_100M; > break; Acked-by:  Jeff Guo