From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "pascal.mazon@6wind.com" <pascal.mazon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] test/tun: add new test for tun
Date: Tue, 22 May 2018 21:39:53 +0100 [thread overview]
Message-ID: <07323b6b-58bf-87c1-7cdc-1b88eb895280@intel.com> (raw)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1D592B@BGSMSX151.gar.corp.intel.com>
On 4/19/2018 4:39 AM, Varghese, Vipin wrote:
> Hi Ferruh,
>
> <snipped>
>
>> Hi Vipin,
>>
>> Thanks for providing unit test for the feature you have added. *I believe we
>> need more unit test in DPDK.*
>>
>> Only a few questions:
>> 1- Should this be part of auto test?
>
> It would be really nice to do so, but only constrain is ping command requires least 5 seconds to get back command prompt.
>
>> 2- Second running of the tun_autotest is failing, exit test and re-run works,
>> any idea?
>>
>
> I am not sure, I will check and update.
Patch pushed to next release, patchwork status updated as deferred.
>
>>
>> Overall I am for merging this unit test if there is no objection.
>>
>>
>> Thanks,
>> ferruh
>>
>
prev parent reply other threads:[~2018-05-22 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 8:31 Vipin Varghese
2018-04-17 18:02 ` Ferruh Yigit
2018-04-19 3:39 ` Varghese, Vipin
2018-05-22 20:39 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07323b6b-58bf-87c1-7cdc-1b88eb895280@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=pascal.mazon@6wind.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).