From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0061.outbound.protection.outlook.com [104.47.40.61]) by dpdk.org (Postfix) with ESMTP id E830E2BE1 for ; Thu, 29 Jun 2017 16:46:16 +0200 (CEST) Received: from CY1PR03CA0026.namprd03.prod.outlook.com (10.174.128.36) by BN6PR03MB3267.namprd03.prod.outlook.com (10.174.233.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Thu, 29 Jun 2017 14:45:54 +0000 Received: from BN1BFFO11FD024.protection.gbl (2a01:111:f400:7c10::1:182) by CY1PR03CA0026.outlook.office365.com (2603:10b6:600::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11 via Frontend Transport; Thu, 29 Jun 2017 14:45:54 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD024.mail.protection.outlook.com (10.58.144.87) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1199.9 via Frontend Transport; Thu, 29 Jun 2017 14:45:53 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v5TEjoLM010562; Thu, 29 Jun 2017 07:45:51 -0700 To: Ferruh Yigit CC: , References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <1497591668-3320-25-git-send-email-shreyansh.jain@nxp.com> From: Shreyansh Jain Message-ID: <0768ce6e-e23d-0562-fe34-b9e8dd908a45@nxp.com> Date: Thu, 29 Jun 2017 20:25:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131432211539287539; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39850400002)(39400400002)(39860400002)(39410400002)(39450400003)(39380400002)(39840400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(199003)(377454003)(189002)(24454002)(9170700003)(8936002)(65826007)(47776003)(85426001)(498600001)(2906002)(104016004)(77096006)(4326008)(86362001)(83506001)(53546010)(230700001)(4001350100001)(65806001)(65956001)(189998001)(8676002)(5660300001)(31696002)(81166006)(356003)(64126003)(106466001)(6246003)(229853002)(110136004)(38730400002)(23676002)(69596002)(50466002)(305945005)(31686004)(6916009)(6666003)(8656002)(2950100002)(33646002)(36756003)(105606002)(54906002)(54356999)(76176999)(50986999)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB3267; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFCRkZPMTFGRDAyNDsxOmh4Mk5sQ0cyeEt2NDQrMDZ2bkJJNGQrLzl5?= =?utf-8?B?RmFQR2FkMWVCNi9wdVIyRGNjd09odHlaWDJnLzlpeGZLbThNWkhGbXhZTStL?= =?utf-8?B?K2ZqUTdOeStncjRsUkVDekNSdlBLQXdJT1hVQkRyTTBUenVBektzaExCcVZM?= =?utf-8?B?U24zQmhBYmtFZUFhSWpHMkxMRTkvNVNwa21GcXZwSm1ublF3WHBGaVlCL0t5?= =?utf-8?B?UlN3VVFteUpmUFhrRUNBUnpPcTF3b1AwV2RoRm9reHE4TENNbU9iL0o4N054?= =?utf-8?B?RXJqbytTdjlPR3M0Z0p1WVJwbnhHSllweERZbHJkRDJ4ZklnYjh5RHdDOGNB?= =?utf-8?B?enRacVc2bnpuVG5FelEramZ5K0IrM25DdlR3OFZHS0VGeEZMRkNwTVZsM1N3?= =?utf-8?B?ejNhRWtmdlIvNVNEU2pKc24vZnVWc2hGdFFTcEJHL3o0TVNvQ01zNFlHbVVF?= =?utf-8?B?eUdBeXJvTVVLU0czYUF0R0Y4Unh6VGl1QTcvK1pNWktMNFFXNzBLNUxDamgw?= =?utf-8?B?SnNyaDFUYjA0NnpBTG1FZzhkTmc1YmdEZVJkbkFjQVcxdFBxSHRjbWVieTJs?= =?utf-8?B?ZFZ3RlVwaWlDbzN6K09zbjYwSnoyRFkrQ2dZN2w4NEdubjQzb3FEZzBTZzkx?= =?utf-8?B?VGQzMU5EMVQwWGJrV3FLY1ZxK1IrU29RaTJFZVZjbmdCK0Z0WWc2NTFyY0h5?= =?utf-8?B?N21xaEFrRFJoS0JjZkdiOUdPU1RONEdWQzI2bDJLYi9GZXZWcGE3RnlLTmxa?= =?utf-8?B?Mm1vV2hVWUk1SnNzbUpkOUFxWElIVjRHU3h0NmtmclNjbUhCdU9ndDhlMDNy?= =?utf-8?B?OVRlYjQxN2RFRmdneHRqNXRVblZ3TnJRNmlyRDVJKzIzeWpRRDBWR0QvOWpT?= =?utf-8?B?YjR5Umh5QXhrZW5UdHc1S1FTN0dHUDlTeXdEVlBmWlhGaiszN2VWQmJ3T3h5?= =?utf-8?B?VXExR0J2dndvM0d2dG9mTWU1UUh1MHJyTUtNQ2JKRXlxTHE5dGFFeTZRWGtj?= =?utf-8?B?ZU5zNlBic2xSQXppV0JYRHZvL3hXSHp1aEsrbmU1cWIwbHVUMmVaMU1USzFR?= =?utf-8?B?VThyU3JqY3hFeGNmNzd5T1RCUlpQcWp0ZjVQV0Y1QWVBTnU3MGczbFNrRU8z?= =?utf-8?B?UjNXTG9QL2xMQjNwbHU3ZTVtckcvdmdqS2M4bzFvRVhZeUs0MzVqQ1NLN2tB?= =?utf-8?B?Sit3QlhSY09UL3QxVFRoaDlHYnptMjd5OE14eUNuZ1BWK3hwS2xrNzB1NTJV?= =?utf-8?B?Q3lqK3V0TWJtb2NkQlBuVmpET1VKSUgyZGVZaWtETldLV1A0NlkxT2Fjd0ZZ?= =?utf-8?B?by9CY0hzdmNYUnc9PQ==?= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2d6b46a-84b0-4049-d2f3-08d4befd8b3b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR03MB3267; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3267; 3:E/W9whlfuj2Jcc30XXsR9fjRWZlMXIdtYKR6xQt6/sIXiKsrTD1MBREAKRiBO4DVO4N4PvdLCxVsDJHB9+5EEadeQmRyGlMswWkxB5kpNhk41Y+92PliugzoGVhWlyGGqrz9pIaJhoFMVKQhKQO0KCcIxtI7s3WdO3d52aBz+cHzhdvGzSMJigx+ooQ39ZbafRNuZbj4Q2J6kASsT4nwSxTc3URfjUg0jKzIfj+F/XTlznIgNGMHV34zU/vPqngYFsbExNG5mk7VZDhSHOaC+dle8N2UpE7bfzYeLW/0gK7dFfKOAB1fVui3Bz2HhDV3HjSc/oy6eRUoQkyBf0CMuK7vgBzwZBjwlRTsF4ScG6dCgDKWA7aj4bsa2JpPLV448YCxgLJ6pHjU/r0Vct/Gh9SNacX0NYFVGec9j4EGR7dk77U5irw1XSIEDqpA1gXZxI6StDhnGFvgcSx5KX+HIMP9Yp8LvEP9DELmwwXm0oI6RPKcOo101K9RCLbzxDbaGW0Clw7Lx3SaCGeLgjqju/x4WfUB8NF8jFH/laKt1TEpTcBdO7yADNKhkwsEmOBZ/dvGm73jcc8pJrPPJYak+f0usnnKot9QkTliFpr+LhQ8yjloEchwjcEmIl8UlfJNxJyTMrrwylodV3RzjOlRuYUSNkDJjk+WebJbnlOncsDrMxD+Dnn5q+Pc5UH6jIpkqclTLN0RqnkTaPGgyYlYRkG1o+nSHtqsR+l7LxLgBhGyV9a9XSyaW0Qf1e0bweq++pQE9blH2qgW+lc26S1+wmciIoNO6HgjB4F7kSch+y08cJTIBNzNPp0oI352qFN72XWHNoi6UTrhbKtD7fBw+Q== X-MS-TrafficTypeDiagnostic: BN6PR03MB3267: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3267; 25:8LMakbvBcC3ZDcAlwafwGWCJx4ukOHHjuqRXEzj9JPWmiSLwebyrZWM2Vjc/UVjsHzYn5M93j3yHQOTy92twTUryA+qA7u2vYZeWJ/Xb9EOumSfIukYS147lrUPsyrbkpteZoSrRu4Y9VeJj4wK5gITu1pNNCMsiM6Vht0+1yZ25+c47BESHRKFbVKx0hvBQH40Sc5RKyYe26DRNhgfzIBnHTTthsoGH4Ys1t5nrbxEk8FV0nh4Aoq2s+UribvgqLBCqelf1TWLoCzJZJ5m6Iqg8HsiljINsva0IdjcvL37tiMleKS927/1dt4iUcYTjtB4Lw9QrQSi547Tzst4qtBsN1fXJizeWM89hxmE6J93fNMVNAa1KUJ7Cx3xOLThHcS9M2sXz0MjIRMvg4M321edIVX+hrGuXI68thfKyqnKuxu3yPKN6kGtRuX2ung+IHzTraqU3YLcIpYCbkCjShm3JyM1V4Bwul0R5FIUhkDSJIWnD1e5wyo9lSA0agCbDkFLYFbU3QvzRYyGANcBncgQ3i7m0UPJrWn41H7i/tnrRYUrEDgyvv/dUK8WEHEWwRYB/cJ/+p8qmL0WTH23ESSc+ioOhAfjxrTnzpBxfaBWiXWeX3V9jhwZA/zyl5zPSp6fbtUPnZlVWCIbDgzsXBZiC4vBc25ZHBZnui8PbL506/5ZBfwwBLZfq3rQZgfepQA9MQUnoB6etam8aNLNNUDx/vaoZ/M6TthjuEgBd9EYcps3EXueAqaGgmKDu1jqc1p3pGvyVCXqxSAqiX5W089tL+o1S46Trlid61amNf+3qVuCJ/QuRJZRfFdlDBDj9TSt+vcblmYd8ixgWkuwckVVJ52nIYA/nX/yw+JgKzBUO2s4XsBNN10K2/niqaiJmTgnQn13VCmm0wREmmAg9rBXoIiMMHfxjSDxNQfg9R10= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3267; 31:qkZZg1T/peOImPTQw4ik3gfgojS8ZADPjYAnEMNx6d9wmNYHoPl6hssnHcN+a4jiegLO3Hwa5OxqmJ7zPVbiQ3/rwz3ZfldiE7o95V1cACHXnPvVbXaDZbidgfWRSzlb1SKxOuaLdxfMT07GW73IamXTHSdvVrDrUQTtggAr5K1ZqT821BqJA1vJwARx9tVRAFNWcFh4UsHUZV+5ywnaesLD6AY/jnhauBGUktIHMjXzFQGpuxJdF3ZNfz8DrgVEfgUI1S8m9ZxZjTs0GaH8EBBqoqXy86XQfAKTWHSrTuJMyQ4qpko0vrgtO6QjtlCxa6nQksvxakTc8h8fAL28Z7uwSGTeyUFgTDxesiw2qGZmt/7hqDURPex16eoExZQCTutp4zaNtOOc2C0b/l4iKXX1oh0Lpk4VMwbhnjWdiI/nkPAAnW1KWvqvniNwBSf3hijUafMd+dG/8fBQGwOsNwx63VZerhULdxsZrDTvMedUW8EvJBssAOVQk65rwXZhQEldHy0HsIDFcz/InVOpltRNHiQuj9z/keF66vWgVmF2h3sAZQLuqmR2lSD2n4g/M1h+R38tG+tu/9iRDcyN2P3XQQu69Q0ZwBeUUDwjmZy3CNPbYrIm30R0AHsBGSRua9eCYhEwjD4ysUFPoJDw0Xwx1X+qu9NNZt9a/3QUlBpYPOOxiBktFvp4/b9a4iootT84GDxRwTz4J/za5TLt6A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(133145235818549)(236129657087228)(185117386973197)(48057245064654)(275809806118684)(167848164394848); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13018025)(8121501046)(13016025)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6096035)(20161123556025)(20161123565025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025)(20161123559100)(20161123561025)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR03MB3267; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR03MB3267; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIzMjY3OzQ6a01uNGNRanM4U1h5NG5NTWRuY0VmaWpHV3h6?= =?utf-8?B?dmNwRHY0UEpaYktVdGVQWWNYSUVTR2FmVTAzM0d6ZU5TWGZhQ1FMQ1I3SnhM?= =?utf-8?B?Y2kyS2xXdkl0V1VDV1pQdFAxZUo1UjJFdzlxN2JPWW5icC9aVVJiSDdpVFFU?= =?utf-8?B?S3pxS2drWG1CTXd6TjAySXdTemc4Wmc0WnUxWEYrOStYRDVEVzRBbUtydnQr?= =?utf-8?B?RmtsMWd1R1h1UlgvbVFxakNaRG94SzQ3alRrUmh1L3R0K2Y2LzNlS1lISE1Z?= =?utf-8?B?TnJ1YW5qVUR4aGJrUjVBWEpwVTNROHhFTDhJVHFmSXk2L0FHOGJFZGZFNld5?= =?utf-8?B?cEU1eVhPUlcrUEpVbERtT1Nqamd4LzJneEJRenZIM1hLdWp6c0ppTUZJWDF2?= =?utf-8?B?VWd6clZUS3l3YVdiV0RPNmd0eldwU1pDQURHQkpOQllIdUFNQWNUbENzVjBz?= =?utf-8?B?cXpncGxHVjhkVXlCNU45TWx5TDRtWWJpUEVpQzF0UUJrMEc1MTdnOTVFekVR?= =?utf-8?B?eGhiQm5pSmlkb1RrVW43dDhhMW1YT2kyYWluMnBPZ1hmOGh4UnErYm5tYXF6?= =?utf-8?B?UVhqUUZsei94YUhwZjdvM3dUeFQyMVRuZm1YVjQwNjM3RmpKYTRnNlBhVGJZ?= =?utf-8?B?NnZId2NxYjRQekVzWnBkMTMrSnN4RnRnSXFOaWFxMytvcVNWdURQRzArbDlY?= =?utf-8?B?a0JBRmJaSGxMQUZMd0RFVDdzY0pUbURiYzdwS3ZTd3U1ZGF1WXM2SWZJSkQv?= =?utf-8?B?Q0lSYUk4d3BqTlpwaDJCb05XcGlqaC9rZ1lFNHVjWHRkNEtydkNpWmNNd0Qz?= =?utf-8?B?dXVYeFZJNFRWdHhqNXFMOERlanNjNE1FajRXd2hLdFFpWVBCZHJtbm5OU1c5?= =?utf-8?B?S2pEbkdCd01rV1ZxcnFuZ0VkRzRBSnpSbkgrRkFqS0oyQTR1NTVrdFB0b2dv?= =?utf-8?B?dXdHTWhRVGl3aVhjOTFlZ3Z2d1ZoOWFvV3F5MW9ZS3RRb2haRlpUWVJtRkVS?= =?utf-8?B?U3ROdWl2N0RzbENuTWdyMnExLzV0aTdtRDBXcHdXNjVZL2IyUlFxb0pGbWJj?= =?utf-8?B?TVdRT2J4UW9PVTdzL3FMZkVuUXZBeG9WTWZyM0svampVQnhvREl6OEpOMEtX?= =?utf-8?B?TjBlUWozai9kb09vQ3BuT1pseDVpaExaVnFQd3J1bVhxUXZxaWtRQkt6cjFP?= =?utf-8?B?dHB4U3EySFVMb2VDa0RKUVcyWEhDTnRZaGoySEJFeUMxRVA3ZlJkUEJnK0Vi?= =?utf-8?B?bnBSTVJFTlJzTUx6TDVkazdRVTBjaUdpekxSRjJGYnM0eFRWSmhVcE44c2I5?= =?utf-8?B?NnR4K2VBSkxzU1hrdlJoVktVR2JWVXlucGtJZ1FwcUg2NXkwZ25HRlNEUDU3?= =?utf-8?B?a3M4WHhKZWlLUkRyMDVyU1dkWkN6YWlRTmtHdmNGUW5rNlVpc3dYQWhRR1oz?= =?utf-8?B?dnRxcXlqdFh6WURBOVJJL0tFZ0ZURWVHc1JFN2YvYTdjVklUZ0NVdUgxS0xZ?= =?utf-8?B?TTJ4N0tXQnlaVUdmNWg0VjRWcGlEazNuLzIyV2oxSlplUjg1NDFobGpTT1FS?= =?utf-8?B?NXRQdERWOTkwc3dYMFJDa2U4L1ppbzMzOXcvVGxRNlphQXpsYkR5dlZubDdQ?= =?utf-8?B?eHNvVEZUUmRrM0gwaU5QMFh1Nk93Y2c0Smt0Wjh4cjVld2VsMnJoVk1TL1RB?= =?utf-8?B?VXRnVStwWnpxMTdNTEdnVFU4OFpxcUx2UURnZlBpNGU4M05Fb0VTU0ZoQnk3?= =?utf-8?B?ekM0SXUyZTUranB2SVAwSEZhaS9Fc3U1d0VFNGg1T04yMncwVFczYUpqUWIx?= =?utf-8?B?OTduTlhBeHJzaEVFN2pGR2hxMUMvMHEvV2U3YWhiVEJsK21RWjFqVXdyMXR4?= =?utf-8?B?ZDUwT2tjR3ZaTm1lQnFZRm5kWDBkR3BOUExiV0NPTDBTaGdBMzBFczhrRDN5?= =?utf-8?Q?Ul7TQSg6o0tJK3GzbQRxkrcJOQVQc=3D?= X-Forefront-PRVS: 0353563E2B X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIzMjY3OzIzOmRJVE5QUkZXNUVaYVZRb2NzRWJISUVEOXdS?= =?utf-8?B?YUVPYWFsaHBVd1B5T0I3eDFNUGppQlJkOUJOU3lhN1QzU0FnZHpUZm52UDlD?= =?utf-8?B?ajVVQnYwUW5zZFZqT2o2MWN1YTlsL2dnNW9YNllDY1Z5VVpnZHB4UUVBdm9R?= =?utf-8?B?QmphOTRPdkNlYjFkVENuNHFBTzN4NXdMV0xXL3d1U00wbmU3SUxDTGhNSDNX?= =?utf-8?B?RjZ3VzdJQnZWaHVFTUJVQitDZi9pTjY5WTRLUkNDQ1dLcFJYTlFlVHZIR2dO?= =?utf-8?B?M2FPdUR1UnB1RG00STUzZkppcGpLeWI4S0NOVC9JUTBvM3lUWEE4bmpocTBN?= =?utf-8?B?Q2hkazB2MW00dVFrZDZuay9DbDZrSjQ3ck11VnVnYWplNnJ4eC9ZSmtSNlpX?= =?utf-8?B?V3E0RDRjK3BaS1dBRHVuTEZMeHdnWDl5NDBVa29lSlJSdWdMVmxobHJKa1Nk?= =?utf-8?B?bnkyUDRpSndNVjI3R0N6SDV5Y0x3U3pHNzFLOUozLzlGK2Z1Um9sRVZQS0Fr?= =?utf-8?B?YUJLblM0emdVdW0yVVJOMGNIUUZSbWFpODBKV0tHNTNBK1FsS0RGQ2xvcHI0?= =?utf-8?B?S3RpV2FGZUZNaUhXK2wvR3NGaUp0L2xENE9BTTdKTVdwT0tJaVltM2RNYXVS?= =?utf-8?B?V0xrYVhVWmV4UFNtek5JNk42WG1pMHI5NVFOT0orWWl3VldRbTc1dW8wY3Fj?= =?utf-8?B?emx2TkEwbGFVNHlQMXoyYzZPZCtYc0MycG5jYXRZbm9lc1JLWHpIV0QzMWVI?= =?utf-8?B?NUg5TStkbEREL1RDenUybnpqQTN6N3pBdks0emdGRmJHVWNaZFlpTWl0L1N1?= =?utf-8?B?YWNkUmxwUjRBUXhKYTE5aVRMWTZwM3FmUGVQdG9kQXVRKzRLSDNOUmN5ZzlP?= =?utf-8?B?aEFpYmt6S3M1UFAzSWc3SjhBdjY3cTRWcEU0c0M3ZlBqUjFmMWt1QmxBZ0lE?= =?utf-8?B?dGhRTnR4cnhFY0kwNU13WWNsalB4TkEvTStvZEtBODJsMWFsS2tWSklpOEY2?= =?utf-8?B?TGVveEhVNm9pUzh4VTBSK0QxZTYwRlJVVHE2UVNoc3hOYXJ3YUtRTUxkV0Zl?= =?utf-8?B?YUlWdkpZdXVtQWtoK1hrUk5tcXo1dHdyN24wb1pjTURwOS93Tm5sWW4wNGMy?= =?utf-8?B?VFgrQkZDWU1YSTBlS1oyaU1mdyt5d2FYQ05TSUxlYVVmYlhUeDFJTmdlNGJ2?= =?utf-8?B?djZIY21reTh5cWprLzRNZVpCZ3U0dnl6QUp1UG5GWlVVcGIzN3pFKzZ4U1BW?= =?utf-8?B?NEVrblFhb1FuTEZKdjlPSEppS1NVNVIwdVhEYmFTZi9LaU9YcFlPckRSTE5o?= =?utf-8?B?Y0x4Nm1LVVBJM3BoRWw2UVprQXBrZUpFRkhKV1k2eGc0UUR6N3ZiTERGenJU?= =?utf-8?B?cDQ1anY5R2FmSzk5QkVSSnE1SWk0UTJVVytkcTcyckpQQ1B2cUphVGorc2dR?= =?utf-8?B?ait1VEx2aEVDRHZMeGtxR0lFcHE1WkNPeDVWUjhRVEFLQysyTzVWN05Dak9o?= =?utf-8?B?TVNQTFZFbFArZVhGT3FFWW5CTlVscnF3RndIejhtWVNHMXNTV1FsM1YwcGN2?= =?utf-8?B?VStFVlNGL1d1RCtZQWFRbHNIUzZKcHAzSWFtRTRnalV3SVYwWmVGWTg3bk4z?= =?utf-8?B?cDhTbE11cnZVaVdNYnYzTVlRTktTd1daNU5WTHRDRnh2YlNJeE1sZjB3Qmhv?= =?utf-8?B?MXdoQURHS20vTFJNMWR1NFZIQmgxVXU0Z2RvMkJIQkhHM2c1RERvdGZMSDNu?= =?utf-8?B?eWtmbk11TEZBUVNLcGJaSVNXeHVmYXRPRGNYeFIxTi9HOHYwWVN3MXZnNmFS?= =?utf-8?B?U1FkeWV3WFZKYTZhVW4zQUNHUFpoSytPZk5BTFN6bFhBei9BSUZSQ1hzRC8z?= =?utf-8?B?NXpoQktNam1ISVh1OEdIUUhBc1JqcEhaZ1lPRGdLSVoxQXhHL2IxWWF0Q0xO?= =?utf-8?B?TDQ0bjNXOUl3L0Myak8xamJ0RmI4T2g5L3JaRlNJNm5zcW1ncGd3cEVidjNW?= =?utf-8?B?MGxZd2hWSlhtM2hla0RZRHhUSVdVcXkvVzVQMFFsdXc5V1R4UVIxbjN4bVI0?= =?utf-8?B?VzN6V1BNU0FPYzFGeDNyMklPdUo0RmN1REhLdUFrSVdwRzE5SW1EZ05kRHZW?= =?utf-8?B?NXc9PQ==?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIzMjY3OzY6Vy9uc21qWkFkcEFrMzYxeUw5eGdxZERSaGxu?= =?utf-8?B?aUpvR2RNYXU0ZHN1Tm9tUTRORWxjVk1Ka2g5cnphcHg4WlBlK0JRYklidmE1?= =?utf-8?B?T2ltb2trdlJDY0pHaFpuT1pqbEMzWUlFdEoyakFSUmxwTkQ0MFRjU2ozL0Nt?= =?utf-8?B?bnJIbUJvaFluTzRjUmkzVVlyRmsySm0xUTdwRU5EZXFhUDNYeUUvRzlhSXJG?= =?utf-8?B?ck9vclVzdnZYZUFta2xHVmNrdVE5OXBMQjhiM0J2TE1lRWhVak40bHkrZTlH?= =?utf-8?B?eHFpMDhSaWx4cStINXRBUUhtWmNMZDdOTjUvVFp3RlI1SHZOenFyUjR5Ky9j?= =?utf-8?B?Si93WUtzK1hZV083UUw5RzQ0elBYTEFLUGtmNlNsNTdxeWZhTUxuRWdneU5s?= =?utf-8?B?U0lBd1laS0VnVVN3dTRqRnpzRmNYRzV2OTBoVDdZZUNKcWxJbytqSUVEZmRx?= =?utf-8?B?N0NJV2NQNXAvbXd4SDhzdmN6Y1dLWTl2VWU5Z2cyeHZUaFpzRExldWJPU0tQ?= =?utf-8?B?VlgrZURCZ09wUm93bHNERFJkdFY2L2V4anYwaFlaSzM0WlBOQkVHYnUvS0lk?= =?utf-8?B?b0tCOWRHbFNMZ2tHelJweHpGZ05ITzFmOTZBV1dMckdBdGVoZnlJVEU3YUx6?= =?utf-8?B?ZEhUakpTRFpHV2xTRUhjb1ZycmJ6TU9paW9QK2pHT1lQVk9kUFZmMU9iUko1?= =?utf-8?B?RGl5SlpkTDNnWGZOaTk1OEd3eVZLSUFJQTVFbXNzNW45T2ljalVVYUtJV2kw?= =?utf-8?B?QUd4ZUV4QzZsS3J1RTRBaTVUWDIxbHBMWldnMmpuRWpONjFkWWpXZGZHT0dO?= =?utf-8?B?UEpXU1prczNkamV1NWlhNllheFRMT3pON0J4dkZMY0NyTEc5bk5ETU5jZVVR?= =?utf-8?B?bHZBT0wwc1pwN2lxTlAzWFJ2MllIZmNyNzBrV0w3b0VrOXFpUlhkMVc0SFlr?= =?utf-8?B?cnZZWGxNVEMvY3dSRGtCMUYrb1RBWGNseDlIMy9kVVhzQXJoR1VJUzIyeSsy?= =?utf-8?B?R3FWV2FvSzJWM2VmUkNOM3hLVWZyUlljQWxIK1g5VGJsSGxtM3RpOUxRZzIy?= =?utf-8?B?ZnRPa0dnTVFMdzlHc21DdGllbmF1Q0VQTFZ6dHBuWmQ1N0lrSzR4OHFlN2FZ?= =?utf-8?B?K1JQWkVPVWJhaTF4Vks4bXBWRTFYUzFLTTdKRzBrTTBORk84YjJTRDVEMC82?= =?utf-8?B?YTRqem1abVNtRXl0ZEQxbnUzTmZKbDVNR2pISkMzZzdKNWNiTkwwVjFwcWNC?= =?utf-8?B?aDNUbkxwVWdkVnNOZ2IyWUZOVGMvbzMyY3RqWVdBOVkvM1FMMU9xMjFPOHFh?= =?utf-8?B?U1NuUHBuN2lJZz09?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3267; 5:PHByBKeh7WHOwB1rHJR3ZkNAUBW9BWZbZqTfmFdLooU8iEIqQYjl1m8voBX3hpbXL4WE9GyWd8x23LYno6Pdm6W+EmjwiK2qj/4Io583M39WgJ5GooOQzrghAN+vmpd+uvycdvbQ/zKZip4pmqaBDTkytAfLx4UoA9S/bC6GjBVcwu42R52PWf+eMs6yteq/z/Q04JUPMYhsASWWpc9tdO7G8lwvoPyWA7ZvtnmKXF/y3UOdqa6AbA/1L0EmgUxdX5pdQV+/Fv6QNBjluqcTPuyrmWWZD2O6qQNa5+2C58FunaJL0ymtqsEavTJdJnPPLZj0YZWtP7OU6V2xUWRz4ej2dJIUaYJghrZ+EO4TmYvEzhr5+qD1Ri7rYULaodQbOuXe23h5pwcB7D5wPmvVF8CCR44Thagc9rP9A8dcxO0gWBZT/NmHkq06TUnoeWVYfK+iUdm6NvCIcEdcdBwwuDrRvHssl1ve6Hp/8WojzvOK66l+bWK6DKUr2LE1QfkttWnfkmT/YJJgVlts60Jo6g==; 24:XLw0RjoSp7EaqlLeZ6CutDfgwC+YFNE6pH+a0+CSDk92qhDQRncZICsbsWuAZA2NRq8FlzIpPSd7PyhZxZY4H1vxtgVWQ4a9N4Ln4yl3P0g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3267; 7:FJhWLuiY7ocEcytvC4ZNwpl03IasPKjwxVv/hkGDYL3r0FG8awIYRO76A+OJRyMwKP16DBbUCNKCOw62Aan3G+fOPmW7a6qp3SOc/viXjvGRumSn1tMqpnb4sUt07q46xUY4DpTsbkPUDZZXQsdF/ux3VYJCYmgVUWs+y4tsbB591fARS4/ZcEwgMGZ0rt6xM2gOrf0vg6nu8NS/gBAzuH+JtvZCPJGV5EPeC9/RAATI6l4J+D8XsE8YFqUj7/hllGuGo7Y+jejZkPZhKm1hdfUfkUlzJTIjM2b3WutBs3pQ4xg5PO1I+VGqrNT6CcmawHjqtLbMSWkeUC/b7dav2TOoJM1gZSCsPLme56HCntzgfB1bWZrw0F4QxQladJx2//Qw6VqBBdYDoIljAOhN/HX8GmQ57aCx0WxAPbDR/RxDtBnnOfIGyYDXYnYxFEyXFpMJ2HcTUZOr8gQwF7giSZqJ+W6hlYrPjeF7whjJqXlMQVLYRAtoNuBRJNvldmx21Y+eeh6gZ845YF1w88a8A2hrF7QUG9SR3X1eYgghk9ohKQH2F3sIR4f4Z8XEa6vnMNrDDJ7Fa+Q4XzKrjAtjwKtcsfRbrpeQnhDAMzbOJzFqbO2XdU4MUrhRzPdUR5drYgO9CRcrEWw5XrMOIOldbsxcbT0LTZtwTiX3sNDJMqQ9WuWW11Kohyr3UA/BBDesBXuNlp79N5MYaJA6RCfoi8ZsSAfN//wWkXbD2j7G9KxkFwwHqahoi8M4aXDesG+yEhVAaapRmT9iGQEiTYrDgavDQqNjqx8edvX0v9TXQME= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2017 14:45:53.5699 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3267 Subject: Re: [dpdk-dev] [PATCH 24/38] net/dpaa: add support for Tx and Rx queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 14:46:17 -0000 On Wednesday 28 June 2017 09:15 PM, Ferruh Yigit wrote: > On 6/16/2017 6:40 AM, Shreyansh Jain wrote: >> Signed-off-by: Hemant Agrawal >> Signed-off-by: Shreyansh Jain >> --- >> doc/guides/nics/features/dpaa.ini | 1 + >> drivers/net/dpaa/Makefile | 4 + >> drivers/net/dpaa/dpaa_ethdev.c | 279 ++++++++++++++++++++++++++++++++- >> drivers/net/dpaa/dpaa_ethdev.h | 6 + >> drivers/net/dpaa/dpaa_rxtx.c | 313 ++++++++++++++++++++++++++++++++++++++ >> drivers/net/dpaa/dpaa_rxtx.h | 61 ++++++++ > > This patch adds initial rx/tx support, as well as rx/tx queue support as > mentioned in patch subject. > > I would be for splitting patch, but even if patch not splitted, I would > suggest updating patch suject and commit log to cover patch content. Ok. I will fix this (splitting if possible, else update to commit). > > <...> >> --- a/doc/guides/nics/features/dpaa.ini >> +++ b/doc/guides/nics/features/dpaa.ini >> @@ -4,5 +4,6 @@ >> ; Refer to default.ini for the full list of available PMD features. >> ; >> [Features] >> +Queue start/stop = Y > > This requires following dev_ops implemented: > rx_queue_start, rx_queue_stop, tx_queue_start, tx_queue_stop Ok. My understanding here was wrong - I incorrectly matched this to queue setup/teardown. I will remove this feature listing. (and a couple more as per your review comment on other patches). > >> ARMv8 = Y >> Usage doc = Y > > <...> > >> + >> + /* Initialize Rx FQ's */ >> + if (getenv("DPAA_NUM_RX_QUEUES")) > > I think this was disscussed before, should a PMD get config options from > enviroment variable? Altough this works, I am for a more explicit > method, like dev_args. Well, I do remember that discussion and still continued with it because 1) I am not done with that dev_args changes and 2) I think this is more non-intrusive as this is specific to DPAA without need for expanding it towards dev_args (and impacting application arg list). You think this is no-go? If so, I will fix this. > > <...> >> + >> + dpaa_intf->rx_queues = rte_zmalloc(NULL, >> + sizeof(struct qman_fq) * num_rx_fqs, MAX_CACHELINE); > > A NULL check perhaps? > > And if multi-process support desired, this should be done only for > primary process. I will fix both the above. > > <...> >> + /* Allocate memory for storing MAC addresses */ >> + eth_dev->data->mac_addrs = rte_zmalloc("mac_addr", >> + ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER, 0); >> + if (eth_dev->data->mac_addrs == NULL) { >> + PMD_INIT_LOG(ERR, "Failed to allocate %d bytes needed to " >> + "store MAC addresses", >> + ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER); > > Anything to cleanup before exit? bad miss from my side. *_queues should be released - I will fix this. (I will run some static analyzer and fix any other similar before next version) > >> + return -ENOMEM; >> + } > > <...> >> +uint16_t dpaa_eth_queue_rx(void *q, >> + struct rte_mbuf **bufs, >> + uint16_t nb_bufs) >> +{ >> + struct qman_fq *fq = q; >> + struct qm_dqrr_entry *dq; >> + uint32_t num_rx = 0, ifid = ((struct dpaa_if *)fq->dpaa_intf)->ifid; >> + int ret; >> + >> + ret = rte_dpaa_portal_init((void *)0); >> + if (ret) { >> + PMD_DRV_LOG(ERR, "Failure in affining portal"); >> + return 0; >> + } > > This is rx_pkt_burst function, right? Is it Ok to call > rte_dpaa_portal_init() in Rx data path? Yes, actually, a portal needs to be initialized if not already - for all I/O operations to succeed. rte_dpaa_portal_init segragates calls if multiple entries are made for initialization. rte_dpaa_portal_init `-> _dpaa_portal_init() if not already initialized > > <...> >> + buf = (uint64_t)rte_dpaa_mem_ptov(bufs.addr) - bp_info->meta_data_size; >> + if (!buf) >> + goto out; > > goto is not required here. :) yes, I will remove this stupid miss. > >> + >> +out: >> + return (void *)buf; >> +} >> + > > <...> >> +uint16_t dpaa_eth_tx_drop_all(void *q __rte_unused, >> + struct rte_mbuf **bufs __rte_unused, >> + uint16_t nb_bufs __rte_unused) >> +{ >> + PMD_TX_LOG(DEBUG, "Drop all packets"); > > Should mbufs freed here? > >> + >> + /* Drop all incoming packets. No need to free packets here >> + * because the rte_eth f/w frees up the packets through tx_buffer >> + * callback in case this functions returns count less than nb_bufs >> + */ Ah, actually I was banking on logic that in case a driver doesn't release memory, the API caller (on getting less than nb_bufs) would do that. This is case for stopped interface. But, I agree, this is dirty fix. I will change this. >> + return 0; >> +} > > <...> > >