From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36C2DA0A03; Tue, 19 Jan 2021 02:52:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9A49140D5F; Tue, 19 Jan 2021 02:52:23 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 07B74140D35 for ; Tue, 19 Jan 2021 02:52:21 +0100 (CET) IronPort-SDR: 0lXsSP29LQlhTeUGmkDDAJES9Ga9AXNbl+WU1pEfWx0fwnIS1DnIawoCgzgaGvbrjMtbPO/tGf V4CJZEoiuCew== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="166533192" X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="166533192" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 17:52:20 -0800 IronPort-SDR: QtMgnJyRbs9uRiiJ+dMcLOlgFQ5n006cK5Uh69i0JEYb6R/Y+F8o1yl+vPvFVWuQQzbAy8HACR tpyeIztK5S3w== X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="383747452" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.222.154]) ([10.213.222.154]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 17:52:19 -0800 To: Rahul Lakkireddy , dev@dpdk.org Cc: kaara.satwik@chelsio.com References: From: Ferruh Yigit Message-ID: <076ff234-1bab-8075-b608-132204a34214@intel.com> Date: Tue, 19 Jan 2021 01:52:16 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/2] net/cxgbe: minor fixes for link related changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/15/2021 5:19 PM, Rahul Lakkireddy wrote: > Patch 1 fixes issue with link status always getting set to down by > driver for every link config change request. This is not required > for some link config changes, like Tx/Rx pause on/off. Instead, > driver should rely on actual link status returned by firmware in > link config change reply. > > Patch 2 fixes issue with link FEC retraining during probe. If > firmware had already saved FEC before probe is completed, then > use the saved FEC for further link configuration, instead of > triggering link retraining. Also simplifies get fec ops. > > Thanks, > Rahul > > Rahul Lakkireddy (2): > net/cxgbe: do not link down for every link config change > net/cxgbe: avoid link FEC retraining during probe > > drivers/net/cxgbe/base/t4_hw.c | 17 ++++++++++++----- > drivers/net/cxgbe/cxgbe_ethdev.c | 21 +++++---------------- > 2 files changed, 17 insertions(+), 21 deletions(-) > Set squashed into relevant commits in next-net, thanks.