From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34124A0032; Wed, 14 Sep 2022 13:46:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C82BE4021D; Wed, 14 Sep 2022 13:46:25 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2047.outbound.protection.outlook.com [40.107.243.47]) by mails.dpdk.org (Postfix) with ESMTP id 4B8D940156 for ; Wed, 14 Sep 2022 13:46:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L6tojZ2g9q3qNgxnWxxKqtsC0ks0lcxU+OdYIJMY8cP9zwB6axRpXrbhHkMXxCP+0Saz9tnVkiEMj1WgWiQokFd4SxgGe6gK/DmiozJZ9/J5hbnCF18UJBx+z9jxxgwDjtgggsUcljtLOIRwfMKKtv3a261/gGdaSo0Bbf77HRpLNupJxf0eOw3QMO2LfHsrVSjILaoU0dAFJjAbWGjFw5WiLWDHIwmaVyM62Lj2OS8vkXqPwWjUTqoYePNIfLxpoS3P+h6Dtu1bsMB/aC+XRZVxpkWhE4SsU7cvytZdBKfTYZWur5gcZLtcTIfH9N+F5zx+8STDicBttJTG/R4uQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TxMv7VFxumVctTB5fL/a+CyweBKxWgKYkyS9/taj+lM=; b=OoOBf6Qh0XyCmqTsAdWAWrLM8WbZEPFV9rUXKOSaL4bdt1rDmKS9qjgn3fgGMC8YFM29qt+t35NLqMEP5pICbLsBzUjI5cZa48SxigEW1ggk7/zTwm8MZI4I7WU40su6u7bWnragT7yztkWTzKgIyx1zpbxDY9cREwqUezNF/9VxAYkrtElv472zgNrgf86fobk3PrF70p7qPj6rWLpPj3YKHZd4AcHaM4RBW4Vhm3+kuGleZ8KZEET+NAZxnMVcDktmFv+qmFflPLqDFN6nh1J2iUeg7mnJTEhvQkqJ5gz3yZyzGMOC+Vl+mZvUj2VM+v14TX/l/p2KYiT3d0fRBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=redhat.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TxMv7VFxumVctTB5fL/a+CyweBKxWgKYkyS9/taj+lM=; b=PKh2FISjQepbNtPR1ZFWosY+bO8fKIbEwkGKvdnKOqvnwvc7oAmGjd5YBSPSAiVigo8kpn+FrrXsBgOGdsbW4dMC68ealHB5fGCb5zpeK08P1oIGdGk7QMP4EnyLznCZ8UpnUukpaEPgHFcz/GiZCJ4FiaSZKGRdkKRWp8vHA+k= Received: from SA0PR11CA0060.namprd11.prod.outlook.com (2603:10b6:806:d0::35) by PH0PR02MB7128.namprd02.prod.outlook.com (2603:10b6:510:17::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 14 Sep 2022 11:46:21 +0000 Received: from SN1NAM02FT0022.eop-nam02.prod.protection.outlook.com (2603:10b6:806:d0:cafe::78) by SA0PR11CA0060.outlook.office365.com (2603:10b6:806:d0::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Wed, 14 Sep 2022 11:46:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0022.mail.protection.outlook.com (10.97.5.0) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Wed, 14 Sep 2022 11:46:20 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 14 Sep 2022 12:46:07 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 14 Sep 2022 12:46:07 +0100 Envelope-to: rjarry@redhat.com, olivier.matz@6wind.com, bruce.richardson@intel.com, dev@dpdk.org Received: from [10.71.194.74] (port=15873) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oYQqE-0002bb-ND; Wed, 14 Sep 2022 12:46:07 +0100 Message-ID: <0771f0b6-1cb2-ddd0-964b-d33c78786ba5@xilinx.com> Date: Wed, 14 Sep 2022 12:46:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] usertools: rewrite pmdinfo To: Robin Jarry CC: Olivier Matz , Bruce Richardson , References: <20220913105811.84384-1-robin@jarry.cc> <20220913194208.125793-1-rjarry@redhat.com> <133f24b5-9565-d274-dc5b-c6942ad7f356@xilinx.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0022:EE_|PH0PR02MB7128:EE_ X-MS-Office365-Filtering-Correlation-Id: e92b9242-568b-4035-33aa-08da9646be47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mrgn56sDCoEx5axqZrndt+iBgpFQcjOLqvmuw4L1vGE8Ulm4eqBqngSbLPM+/ELj39sjVjHONApD641SxqDddofOABveKnZfsHavhaMBFOsXtQNgRXclFYpx3sNjR/6g6hJgHZeIx4/8OIb+1Urn9v5zyW/pm8XvatgGMGGdMM8Pej677THrxBJ+8/SYepvtp5Kyb/ZWtSBPNaB4Ls93j/YQcBcJF5dkFLrCz8gv9sIKQBKaW3fWp/+C66yfBCqqJJPz6GLjq1w8hdMjC8aBInyFDdb7XuhQF56J4DpKba8TK7ykFPLlsWjAQsogY9JagyHk/T/XjzynmUt+r1FlWIgRCtEF0vBQx7Z8x7ioT29eWJEwLTc2w8ADXPwLcfyvAs3c+5kECKLE07w7K0a6uNhqvkt4v0oQM0GsjaJtrOcwXGfbXr71kCOc+lzbTT7FCE4m5CHa/YBQ2r59pxHLjiUWO1uAqqHKrJFT5Zr5kGslhE/6DfkjaFn+KlvjbKP+1vjzOUw5AzbWKcu6+Y6HPH7LIrFZ0xtfWk62ooLKUC7L8GEEX+KNERqL+iUhYDML36AuoYNGwqOUNh7Qul3X66MO4GVnFvx1C5sOkZe+xJAiI0RuyyAd+bapNN5bKB4KPmanXileH5egFm/Dn6b8bDsnsaCT9b4O7BwohIcDlaRMBqmmSW+DDTjRRsssx7Boxxd3yqfLUuXtNLzjhvYGV7lpDCfjj5wcZy97fLLCFkW7dpFDXigU8IP/i8Ddsc5Oi+7SnMFrGpJx7lugymWVu540wyNs55wb0oNfm+RAiXqfiyeoE3F/kz+3IUkdfW//2w3MYCpK2fPd/NF3cd7fDg== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199015)(46966006)(36840700001)(40470700004)(47076005)(82740400003)(7636003)(53546011)(36756003)(356005)(426003)(336012)(6916009)(316002)(31696002)(2616005)(40480700001)(82310400005)(8676002)(2906002)(40460700003)(186003)(70206006)(26005)(478600001)(31686004)(83380400001)(54906003)(41300700001)(70586007)(9786002)(44832011)(5660300002)(4326008)(36860700001)(8936002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 11:46:20.8217 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e92b9242-568b-4035-33aa-08da9646be47 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0022.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7128 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/13/2022 10:22 PM, Robin Jarry wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > Ferruh Yigit, Sep 13, 2022 at 22:54: >> Some of the drivers doesn't provide PCI ids, but script is listing >> them empty, like [1], is it better to omit the output for that case, >> as done to 'params' & 'kmod'? > [snip] >> [1] >> { >> "name": "net_enetfec", >> "pci_ids": [] >> }, > > I could indeed omit the drivers that only report their name. > > However, this raises another question: why do these drivers report > a PMD_INFO_STRING in the first place? Should buildtools/pmdinfogen.py be > modified as well? > I think better to display name, if there is nothing else to display, comparing to not display anything at all. Command can be run on the driver object, .so, so user expects to see some output. For above enetfec driver, it is virtual driver and doesn't support pci_ids, and it seems doesn't have parameters or kmod requirements. So in this case it is OK to have only name.