From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1E6AA0351; Thu, 6 Aug 2020 12:40:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2156A1C0BC; Thu, 6 Aug 2020 12:40:19 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 65D1F1C0B6 for ; Thu, 6 Aug 2020 12:40:17 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from dekelp@mellanox.com) with SMTP; 6 Aug 2020 13:40:11 +0300 Received: from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx [10.228.134.250]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 076AeBhg030209; Thu, 6 Aug 2020 13:40:11 +0300 From: Dekel Peled To: ferruh.yigit@intel.com, arybchenko@solarflare.com, orika@mellanox.com, thomas@monjalon.net Cc: asafp@mellanox.com, matan@mellanox.com, elibr@mellanox.com, dev@dpdk.org Date: Thu, 6 Aug 2020 13:36:31 +0300 Message-Id: <078b987cd79226d2e2f491d7b994bc7a421e8d3f.1596710212.git.dekelp@mellanox.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <6e8b7c61a92b51749b11ac3bfae5c0201352f9b3.1596550675.git.dekelp@mellanox.com> References: <6e8b7c61a92b51749b11ac3bfae5c0201352f9b3.1596550675.git.dekelp@mellanox.com> Subject: [dpdk-dev] [RFC v2] ethdev: add VLAN attributes to ETH and VLAN items X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In existing code the match on tagged/untagged packets is not explicit. Recent documentation update [1] describes the different patterns and clarifies the intended use of different patterns. This patch proposes an update to ETH and VLAN items struct, to clearly define the required characteristic of a packet, and enable precise match criteria. [1] https://mails.dpdk.org/archives/dev/2020-May/166257.html Signed-off-by: Dekel Peled --- lib/librte_ethdev/rte_flow.h | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index cf0eccb..0e0b8d4 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -723,14 +723,18 @@ struct rte_flow_item_raw { * If the @p type field contains a TPID value, then only tagged packets with the * specified TPID will match the pattern. * Otherwise, only untagged packets will match the pattern. - * If the @p ETH item is the only item in the pattern, and the @p type field - * is not specified, then both tagged and untagged packets will match the - * pattern. + * The field @p vlan_exist can be used to match specific packet types, instead + * of using the @p type field. + * This can be used to match any type of tagged packets. + * If the @p type and @p vlan_exist fields are not specified, then both tagged + * and untagged packets will match the pattern. */ struct rte_flow_item_eth { struct rte_ether_addr dst; /**< Destination MAC. */ struct rte_ether_addr src; /**< Source MAC. */ rte_be16_t type; /**< EtherType or TPID. */ + uint32_t vlan_exist:1; /**< At least one VLAN exist in header. */ + uint32_t reserved:31; /**< Reserved, must be zero. */ }; /** Default mask for RTE_FLOW_ITEM_TYPE_ETH. */ @@ -752,10 +756,16 @@ struct rte_flow_item_eth { * the preceding pattern item. * If a @p VLAN item is present in the pattern, then only tagged packets will * match the pattern. + * The field @p more_vlans_exist can be used to match specific packet types, + * instead of using the @p inner_type field. + * This can be used to match any type of tagged packets. */ struct rte_flow_item_vlan { rte_be16_t tci; /**< Tag control information. */ rte_be16_t inner_type; /**< Inner EtherType or TPID. */ + uint32_t more_vlans_exist:1; + /**< At least one more VLAN exist in header, following this VLAN. */ + uint32_t reserved:31; /**< Reserved, must be zero. */ }; /** Default mask for RTE_FLOW_ITEM_TYPE_VLAN. */ -- 1.8.3.1