From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5EECA054A; Tue, 25 Oct 2022 12:03:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 760B8427FF; Tue, 25 Oct 2022 12:03:40 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9ED2A41143 for ; Tue, 25 Oct 2022 12:03:39 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id EFD7166; Tue, 25 Oct 2022 13:03:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru EFD7166 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1666692219; bh=hUmAl9WnaWsLl6RP826nHV0E3RB1X5AdVxGkponqeek=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tKMLVPPrlJdLH4oM2pqPV+RVcM7pFT8c44hRIft3Yj9df5cvwx2spkOO5jGhDunFz iRqN+tME4XWAuzbcpRH/2nJBohs1M+SJHPNgsxSdissF2BdxgzUI/40QBYp+9U2R2A 6rtPBnDh/L1XIF8AxN42vDmUJ3p5D8OwDV0yZaPA= Message-ID: <07a1b986-3d74-a6cf-3f92-56431429cdf8@oktetlabs.ru> Date: Tue, 25 Oct 2022 13:03:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v11 15/18] net/idpf: add support for Rx offloading Content-Language: en-US To: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Xiaoyun Li References: <20221024130134.1046536-2-junfeng.guo@intel.com> <20221024131227.1062446-1-junfeng.guo@intel.com> <20221024131227.1062446-16-junfeng.guo@intel.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221024131227.1062446-16-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/24/22 16:12, Junfeng Guo wrote: > Add Rx offloading support: > - support CHKSUM and RSS offload for split queue model > - support CHKSUM offload for single queue model > > Signed-off-by: Beilei Xing > Signed-off-by: Xiaoyun Li > Signed-off-by: Junfeng Guo > --- > doc/guides/nics/features/idpf.ini | 2 + > drivers/net/idpf/idpf_ethdev.c | 9 ++- > drivers/net/idpf/idpf_rxtx.c | 122 ++++++++++++++++++++++++++++++ > 3 files changed, 132 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/features/idpf.ini b/doc/guides/nics/features/idpf.ini > index d4eb9b374c..c86d9378ea 100644 > --- a/doc/guides/nics/features/idpf.ini > +++ b/doc/guides/nics/features/idpf.ini > @@ -9,5 +9,7 @@ > [Features] > Queue start/stop = Y > MTU update = Y > +L3 checksum offload = P > +L4 checksum offload = P RSS hash missing > Packet type parsing = Y > Linux = Y > diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c > index 739cf31d65..d8cc423a23 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -94,7 +94,14 @@ idpf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > dev_info->max_mac_addrs = IDPF_NUM_MACADDR_MAX; > dev_info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP | > RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP; > - dev_info->rx_offload_capa = 0; > + > + dev_info->rx_offload_capa = > + RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | > + RTE_ETH_RX_OFFLOAD_UDP_CKSUM | > + RTE_ETH_RX_OFFLOAD_TCP_CKSUM | > + RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM | > + RTE_ETH_RX_OFFLOAD_RSS_HASH; As I understand you know mode here and you should not report offload which is not supported in current mode (RSS vs single queue). > + > dev_info->tx_offload_capa = RTE_ETH_TX_OFFLOAD_MULTI_SEGS; > > dev_info->default_rxconf = (struct rte_eth_rxconf) { [snip]