From: "David Harton (dharton)" <dharton@cisco.com>
To: "John Daley (johndale)" <johndale@cisco.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function
Date: Wed, 20 Jul 2016 02:05:34 +0000 [thread overview]
Message-ID: <07b37d524f3a45f598af74f3053d017f@XCH-RCD-016.cisco.com> (raw)
In-Reply-To: <1468968225-32717-1-git-send-email-johndale@cisco.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley (johndale)
> Sent: Tuesday, July 19, 2016 6:44 PM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com; John Daley (johndale) <johndale@cisco.com>
> Subject: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device
> configure function
>
> The configure function enicpmd_dev_configure() was not paying attention to
> the rxmode VLAN strip bit. Set the VLAN strip mode according to the bit.
>
> Fixes: fefed3d1e62c ("enic: new driver")
>
> Signed-off-by: John Daley <johndale@cisco.com>
> ---
>
> Although not critical, it is low risk and would be nice to have in 16_07.
>
> drivers/net/enic/enic_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/enic/enic_ethdev.c
> b/drivers/net/enic/enic_ethdev.c index 59082d2..47b07c9 100644
> --- a/drivers/net/enic/enic_ethdev.c
> +++ b/drivers/net/enic/enic_ethdev.c
> @@ -356,6 +356,7 @@ static int enicpmd_dev_configure(struct rte_eth_dev
> *eth_dev)
> eth_dev->data->dev_conf.rxmode.split_hdr_size);
> }
>
> + enicpmd_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK);
> enic->hw_ip_checksum = eth_dev->data-
> >dev_conf.rxmode.hw_ip_checksum;
> return 0;
> }
> --
> 2.7.0
Reviewed-by: David Harton <dharton@cisco.com>
Tested-by: David Harton <dharton@cisco.com>
next prev parent reply other threads:[~2016-07-20 2:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 22:43 John Daley
2016-07-20 2:05 ` David Harton (dharton) [this message]
2016-07-21 22:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b37d524f3a45f598af74f3053d017f@XCH-RCD-016.cisco.com \
--to=dharton@cisco.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).