From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id DBC2D4CE6 for ; Wed, 20 Jul 2016 04:05:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1418; q=dns/txt; s=iport; t=1468980336; x=1470189936; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iHe3CXj0cmaAIMla5BhQhr7qBbo9lptZbvrOHJl17ss=; b=asm5t4jO0/mLAEWNbUOFunY5qAMek4IxKW4rmTsHfx3jUodYtUsXdKk7 aSXbQi0/wev5AFgPqNFXZcq2AH63cDrQfMZjbWLQnm8KNhZQZ+Ji+qIL9 qiojjBOpVsLRKQPAq8SpZgEzLJTkLpOGG4Elfr01lhH76GX8A/UUJkwyj Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AAAgAO245X/4UNJK1dgz+BUga2WYIPg?= =?us-ascii?q?XqGGgKBNDgUAQEBAQEBAWUnhFwBAQUnEz8MBAIBCBEEAQEfCQcyFAkIAgQBDQU?= =?us-ascii?q?IiCi9NQEBAQEBAQEBAQEBAQEBAQEBAQEBARyGKoRNihsBBIYKkxoBjACCWo8+k?= =?us-ascii?q?B0BHjaCPoE1bocmfwEBAQ?= X-IronPort-AV: E=Sophos;i="5.28,392,1464652800"; d="scan'208";a="125965846" Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Jul 2016 02:05:35 +0000 Received: from XCH-RCD-008.cisco.com (xch-rcd-008.cisco.com [173.37.102.18]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id u6K25ZMP028602 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 20 Jul 2016 02:05:36 GMT Received: from xch-rcd-016.cisco.com (173.37.102.26) by XCH-RCD-008.cisco.com (173.37.102.18) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 19 Jul 2016 21:05:35 -0500 Received: from xch-rcd-016.cisco.com ([173.37.102.26]) by XCH-RCD-016.cisco.com ([173.37.102.26]) with mapi id 15.00.1210.000; Tue, 19 Jul 2016 21:05:35 -0500 From: "David Harton (dharton)" To: "John Daley (johndale)" , "dev@dpdk.org" CC: "bruce.richardson@intel.com" Thread-Topic: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function Thread-Index: AQHR4g8HCwwzU/wNkEqzMwWz4+uE16AgkYnA Date: Wed, 20 Jul 2016 02:05:34 +0000 Message-ID: <07b37d524f3a45f598af74f3053d017f@XCH-RCD-016.cisco.com> References: <1468968225-32717-1-git-send-email-johndale@cisco.com> In-Reply-To: <1468968225-32717-1-git-send-email-johndale@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.82.246.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 02:05:37 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley (johndale= ) > Sent: Tuesday, July 19, 2016 6:44 PM > To: dev@dpdk.org > Cc: bruce.richardson@intel.com; John Daley (johndale) > Subject: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device > configure function >=20 > The configure function enicpmd_dev_configure() was not paying attention t= o > the rxmode VLAN strip bit. Set the VLAN strip mode according to the bit. >=20 > Fixes: fefed3d1e62c ("enic: new driver") >=20 > Signed-off-by: John Daley > --- >=20 > Although not critical, it is low risk and would be nice to have in 16_07. >=20 > drivers/net/enic/enic_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/enic/enic_ethdev.c > b/drivers/net/enic/enic_ethdev.c index 59082d2..47b07c9 100644 > --- a/drivers/net/enic/enic_ethdev.c > +++ b/drivers/net/enic/enic_ethdev.c > @@ -356,6 +356,7 @@ static int enicpmd_dev_configure(struct rte_eth_dev > *eth_dev) > eth_dev->data->dev_conf.rxmode.split_hdr_size); > } >=20 > + enicpmd_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK); > enic->hw_ip_checksum =3D eth_dev->data- > >dev_conf.rxmode.hw_ip_checksum; > return 0; > } > -- > 2.7.0 Reviewed-by: David Harton Tested-by: David Harton