DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>, dev@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>,
	Didier Pallard <didier.pallard@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container
Date: Wed, 22 May 2019 16:57:09 +0100	[thread overview]
Message-ID: <07c05411-51bb-2a8c-c941-bc7483683c02@intel.com> (raw)
In-Reply-To: <20190522154143.8041-1-nicolas.dichtel@6wind.com>

On 22-May-19 4:41 PM, Nicolas Dichtel wrote:
> move_pages() is only used to get the numa node id, but this function
> is not allowed by default in docker (it needs CAP_SYS_NICE and an update of
> the seccomp profile).
> get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in
> the default seccomp profile.
> 
> Note that the returned value of move_pages() was not checked, thus some
> errors could be hidden (if the requested id was 0).
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> Reviewed-by: Didier Pallard <didier.pallard@6wind.com>
> ---

I can see the check for move_pages and it's a good fix, but what is the 
relation to docker init here? The patch by itself only enables handling 
of move_pages() failure and adds nothing else. The commit message 
doesn't match the patch in question IMO.

Also, Cc: stable and Fixes: ?

-- 
Thanks,
Anatoly

  reply	other threads:[~2019-05-22 15:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 15:41 Nicolas Dichtel
2019-05-22 15:57 ` Burakov, Anatoly [this message]
2019-05-22 16:08   ` Nicolas Dichtel
2019-05-23  8:48     ` Burakov, Anatoly
2019-05-23  8:56 ` Burakov, Anatoly
2019-05-23  9:00   ` David Marchand
2019-05-23  9:52     ` [dpdk-dev] [PATCH v2] mem: " Nicolas Dichtel
2019-05-23 14:29       ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-04 11:05         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07c05411-51bb-2a8c-c941-bc7483683c02@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).