From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com, jerinj@marvell.com,
stephen@networkplumber.org,
Nicolas Chautru <nicolas.chautru@intel.com>,
Somalapuram Amaranath <asomalap@amd.com>,
John Griffin <john.griffin@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Deepak Kumar Jain <deepak.k.jain@intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
Date: Tue, 6 Oct 2020 12:09:17 +0100 [thread overview]
Message-ID: <07c1fc99-0d82-a659-6d2a-c57e9de3d922@intel.com> (raw)
In-Reply-To: <4658008.ZccNZLbTaq@thomas>
On 10/6/2020 11:54 AM, Thomas Monjalon wrote:
> 06/10/2020 12:16, Ferruh Yigit:
>> On 10/5/2020 10:42 AM, Thomas Monjalon wrote:
>>> As decided in the Technical Board in November 2019,
>>> the kernel module igb_uio is moved to the dpdk-kmods repository
>>> in the /linux/igb_uio/ directory.
>
> [...]
>> Patch doesn't apply cleanly, not sure why, CI seems having same problem:
>> http://mails.dpdk.org/archives/test-report/2020-October/156378.html
>
> That's because I used --irreversible-delete to minimize the size of the patch.
>
> [...]
>>> If UEFI secure boot is enabled, the Linux kernel may disallow the use of
>>> UIO on the system. Therefore, devices for use by DPDK should be bound to the
>>> - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``.
>>> + ``vfio-pci`` kernel module rather than any UIO-based module.
>>> For more details see :ref:`linux_gsg_binding_kernel` below.
>>
>> Should we change the order of the kernel drivers, currently first section is
>> "UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio out
>> of the repo, should we list the "VfIO" first?
>
> Absolutely.
> In general we need to encourage more VFIO and remove some references
> to igb_uio. But I don't want to do such "marketing" change in this patch.
> The goal of this patch is just to move the code.
>
OK.
> [...]
>>> +* kernel: The module ``igb_uio`` has been moved to the git repository
>>> +``dpdk-kmods`` in a new directory ``linux/igb_uio``.
>>> +
>>
>> Doc build giving warning on this:
>> WARNING: Bullet list ends without a blank line; unexpected unindent.
>
> Probably a merge issue. That's fine on my side.
>
I can see it is wrong in the patch itself, please double check in your end to be
sure warning is not hidden in doc build.
I am good as long as there is no warning.
>> Except from above minor comments looks good to me,
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Do we agree I can merge without any change?
>
Agree if the above doc warning is gone.
next prev parent reply other threads:[~2020-10-06 11:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 22:50 [dpdk-dev] [PATCH] kernel: " Thomas Monjalon
2020-09-08 0:14 ` Thomas Monjalon
2020-09-08 8:25 ` Bruce Richardson
2020-09-08 9:27 ` Thomas Monjalon
2020-09-08 9:34 ` Bruce Richardson
2020-09-08 9:46 ` Thomas Monjalon
2020-09-08 12:06 ` Ferruh Yigit
2020-09-11 12:22 ` Thomas Monjalon
2020-09-11 15:54 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-09-11 16:22 ` Ferruh Yigit
2020-09-12 8:55 ` Thomas Monjalon
2020-09-14 9:47 ` Ferruh Yigit
2020-09-24 5:41 ` Stephen Hemminger
2020-10-05 8:57 ` Thomas Monjalon
2020-10-05 9:11 ` Maxime Coquelin
2020-10-05 9:56 ` Bruce Richardson
2020-10-10 7:23 ` 谢华伟(此时此刻）
2020-10-05 9:38 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2020-10-05 9:42 ` [dpdk-dev] [PATCH v4] kernel/linux: " Thomas Monjalon
2020-10-05 10:14 ` Andrew Rybchenko
2020-10-05 11:14 ` Jerin Jacob
2020-10-06 10:16 ` Ferruh Yigit
2020-10-06 10:54 ` Thomas Monjalon
2020-10-06 11:09 ` Ferruh Yigit [this message]
2020-10-06 12:49 ` Thomas Monjalon
2020-10-06 12:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c1fc99-0d82-a659-6d2a-c57e9de3d922@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=asomalap@amd.com \
--cc=david.marchand@redhat.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=fiona.trahe@intel.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=jerinj@marvell.com \
--cc=john.griffin@intel.com \
--cc=mdr@ashroe.eu \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.chautru@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).