From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 49FF11B597 for ; Fri, 29 Jun 2018 18:21:46 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE5DA7A7E5; Fri, 29 Jun 2018 16:21:45 +0000 (UTC) Received: from [10.36.112.15] (unknown [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B7322026D68; Fri, 29 Jun 2018 16:21:44 +0000 (UTC) To: Tiwei Bie Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org, mst@redhat.com, jasowang@redhat.com, wexu@redhat.com References: <20180622134327.18973-1-maxime.coquelin@redhat.com> <20180622134327.18973-3-maxime.coquelin@redhat.com> <20180629155145.GB31010@debian> From: Maxime Coquelin Message-ID: <07c68139-eec8-592d-ea5a-cbe4e2df3db3@redhat.com> Date: Fri, 29 Jun 2018 18:21:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180629155145.GB31010@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 29 Jun 2018 16:21:45 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 29 Jun 2018 16:21:45 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v5 02/15] vhost: add helpers for packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 16:21:46 -0000 On 06/29/2018 05:51 PM, Tiwei Bie wrote: > On Fri, Jun 22, 2018 at 03:43:14PM +0200, Maxime Coquelin wrote: >> From: Jens Freimann >> >> Add some helper functions to check descriptor flags >> and check if a vring is of type packed. >> >> Signed-off-by: Jens Freimann >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost.h | 6 ++++++ >> lib/librte_vhost/virtio-packed.h | 16 ++++++++++++++++ >> 2 files changed, 22 insertions(+) >> >> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h >> index bf2059198..34a614c97 100644 >> --- a/lib/librte_vhost/vhost.h >> +++ b/lib/librte_vhost/vhost.h >> @@ -319,6 +319,12 @@ struct virtio_net { >> struct vhost_user_extern_ops extern_ops; >> } __rte_cache_aligned; >> >> +static __rte_always_inline bool >> +vq_is_packed(struct virtio_net *dev) >> +{ >> + return dev->features & (1ull << VIRTIO_F_RING_PACKED); >> +} >> + >> #define VHOST_LOG_PAGE 4096 >> >> /* >> diff --git a/lib/librte_vhost/virtio-packed.h b/lib/librte_vhost/virtio-packed.h >> index 744b3991b..21fe5045b 100644 >> --- a/lib/librte_vhost/virtio-packed.h >> +++ b/lib/librte_vhost/virtio-packed.h >> @@ -19,4 +19,20 @@ struct vring_desc_packed { >> uint16_t flags; >> }; >> >> + >> +static inline int > > Better to return bool. Yes. >> +desc_is_avail(struct vring_desc_packed *desc, uint16_t wrap_counter) >> +{ >> + if (wrap_counter == 1) { >> + if ((desc->flags & VRING_DESC_F_AVAIL) && >> + !(desc->flags & VRING_DESC_F_USED)) >> + return 1; >> + } else { >> + if (!(desc->flags & VRING_DESC_F_AVAIL) && >> + (desc->flags & VRING_DESC_F_USED)) >> + return 1; >> + } >> + return 0; > > Maybe something like: > > return wrap_counter == !!(desc->flags & VRING_DESC_F_AVAIL) && > wrap_counter != !!(dsec->flags & VRING_DESC_F_USED); > > is better? Definitely! Thanks, Maxime > Best regards, > Tiwei Bie > >> +} >> + >> #endif /* __VIRTIO_PACKED_H */ >> -- >> 2.14.4 >>