From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 10F942C74 for ; Tue, 14 Feb 2017 16:51:29 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2017 07:51:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,161,1484035200"; d="scan'208";a="65666734" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 14 Feb 2017 07:51:28 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Feb 2017 07:51:28 -0800 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.230]) by fmsmsx101.amr.corp.intel.com ([169.254.1.198]) with mapi id 14.03.0248.002; Tue, 14 Feb 2017 07:51:27 -0800 From: "Wiles, Keith" To: "Richardson, Bruce" CC: "Yigit, Ferruh" , Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 17.05] test: move tests to separate folder Thread-Index: AQHShtT3KKBbMndgoUad9aqxkuP6OqFpKhKAgAACxQA= Date: Tue, 14 Feb 2017 15:51:27 +0000 Message-ID: <080F0ECF-A6F5-48E0-A2C8-56D51DCDF210@intel.com> References: <20170214151326.7554-1-ferruh.yigit@intel.com> <20170214154131.GA20524@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170214154131.GA20524@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.102.97] Content-Type: text/plain; charset="us-ascii" Content-ID: <527BD8C2DFD1B042972AA31C08282C92@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 17.05] test: move tests to separate folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 15:51:30 -0000 > On Feb 14, 2017, at 9:41 AM, Bruce Richardson wrote: >=20 > On Tue, Feb 14, 2017 at 03:13:26PM +0000, Ferruh Yigit wrote: >> Tests are part of app folder and compiled with library every time. >> Moving tests into a "test" folder which won't be compiled by default. >> To compile tests, need to give explicit "make test" command. >>=20 >> "make test" was previously used to run tests, which renamed to >> "make test_run" with this patch. >>=20 >> This makes default compilation ~30% faster, >> [clang, make -j8, old]: real 1m04.355s >> [clang, make -j8, new]: real 0m41.740s >>=20 >> For new case, test needs to built separately, which takes, >> [clang, make -j8 test]: real 0m24.293s >>=20 >> The point is tests are not required always and by every one. >>=20 >> Signed-off-by: Ferruh Yigit >> --- >=20 > Hi Ferruh, >=20 > I'm not sure I'm convinced by this, as I think there are advantages to > having the test code always compiled. Anything that is not compiled in > DPDK by default is more likely to be broken by patch submissions. The > speed boost to build is nice, but I'm not sure it's worth it. > However, I'm open to being convinced otherwise on this... >=20 > /Bruce I am kind of in the same boat as Bruce on the tests, but I was thinking the= other applications in the app directory pretty much use most of the APIs, = right? If that is the case then I would agree with Ferruh. Regards, Keith