From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0DC942AE4; Fri, 12 May 2023 13:57:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 835A042D1A; Fri, 12 May 2023 13:57:18 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2044.outbound.protection.outlook.com [40.107.94.44]) by mails.dpdk.org (Postfix) with ESMTP id 9597F40041 for ; Fri, 12 May 2023 13:57:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YQ6sy+mYPNW65O1st/ROWT0J1qh9jqPmrhpS4FbMKSsgpoP/WOwPQD9EGSudN1Z+ztdsVgduKIfy93byfIZtpIqjv9eT9JnPdZTGb/mmULEeYjQbViaGFC9C0c7zbhIUZfVey0zhHcWniVHooTidvxa8bmOI5XpOUe+TAgODIYEIrHeGua1bFnpiySpWcMvccOMd1MnX+yPcaXXPMgrFsXekps5bjr285G9KJNjr8hsewogsxG1xobGqZoCzMuTnlnAbFm/9Xv8w/J/FEDCM1g5pUjwYLvA6pLUdXDvVGxmDtKBBTcxl9BvDAHJWKgqbS0oc4sV7f1B71ej0gQxcQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mQY4Ngn53A4s96MtgsMWtVy0kKaAn8QR/ASV1wyy31E=; b=jvLerOij7bar/xF7aRJJMOXyXVuDViaCw+au1uPOfVnLN8VODL0VNs1JDpdeviOYrrOltgPIRFwD0z/64g9JzefWXo3DTim0lEGb4pybzl7uNuYDdu3Ob7LDEEsbxUOnCvw6TkCnX6+2XAXGbhNU0zIKx0dsqH8GE79L6KHZ0crJscEhArfm0B798mB+ufhs/qxsMDMAf1O+fEMYdyRgGNelyG+QOMsJnEvBb1QbUeqcoDAZIiWYPRCwHruWxRFnUqHV4CGSGMZFsJD0FEC130aWCIKsCC0Bw9dRQFzmQslhqI07xhij2SYxPdKFthRDHajFKtidvETmummcpV9aFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mQY4Ngn53A4s96MtgsMWtVy0kKaAn8QR/ASV1wyy31E=; b=fjZUHgAeQoZ7K2oGfzRSCkKGHQ4YOXWu75MKwTBc43sta6IkqegRNnoftCcKjYvHo8MXM0NHFqSYCYkULfwAnUkRnP2M17bYjf6w1/ELCCGBmp4z1cvxiEsoNP6sRSqXC4xne48Bq8NasP1aacBnKMS+P40kyOUYamLB9aT6MNY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6270.namprd12.prod.outlook.com (2603:10b6:208:3c2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.20; Fri, 12 May 2023 11:57:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6387.023; Fri, 12 May 2023 11:57:14 +0000 Message-ID: <080a8617-0f93-e1f0-afc6-de6503d572c6@amd.com> Date: Fri, 12 May 2023 12:57:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC PATCH v2 0/3] improve FEC API usage To: Denis Pryazhennikov , dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Thomas Monjalon , Andrew Rybchenko , "Min Hu (Connor)" , "Wei Hu (Xavier)" , Chengwen Feng , Chengchang Tang , Ajit Khaparde References: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> <20230508114707.89629-1-denis.pryazhennikov@arknetworks.am> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20230508114707.89629-1-denis.pryazhennikov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0004.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6270:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ee99319-8927-4495-631f-08db52e00677 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DC50cLQv4g8kA6/qZaOQaI4cIUzWhvgPQXsE19xw6qmBfHrBvcM472voafxDUlG+utHZY2nSga1idQo5AB7tNA9CHyE0COO7WsvNpTlxvwkCJbDu2ySkyCUkJxzvlSDlNU8AZC/JqzrszsIvZg898SEJmTKI5xrvA+kl7DZnwTeaxHqGlvufEnFeN9xcPHR5e0/PyKP6tlV6rwvGbDNyV3y6c6WC6oiHlWBtIM/HOiZQRHxWtkhUymqxHQmwbZMvUx5w2mpPJFhW8ttWuE74LL3lxPqMhHT3HnTZ7oDLbUfsO5G6R1LyyyFGboZjdy2aJTIZWgyDUg09MzPVs8IERgltkKNOd2CEr56yQWMbGevsp3llOpmK2iCb/WEJiIsMDYhfFvcKVRZJ2AUYFzXsniWvSfrYNtWxCUVyLL9u23nQ6orhQm3j2Gjb47yssDi/CXdyN66OegMo8mNaX40kAwGf/GyDp/pfafTD1OAkj0Vo/PywtiEt0fB5J5A6NbMHBmUSMLZIc/qxuDjqrF6ASWRj8ri0BbCuZS2JeHP8jjBO3xc8jzYSQQSqbAdrLWnAyYCWfaDtt7z/djRhwrBVFA6uOMdEMkQiMHpM0DT+2TCKsE0wcBkZd/mkSoETG/3Nuz2/3zdxdPduihP0/kty7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199021)(186003)(2616005)(2906002)(83380400001)(31696002)(38100700002)(86362001)(36756003)(6486002)(8936002)(41300700001)(316002)(8676002)(6666004)(7416002)(31686004)(5660300002)(478600001)(44832011)(54906003)(66476007)(4326008)(66946007)(66556008)(26005)(6512007)(6506007)(53546011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2VhU1kzcWlHT3p1b1I1K25aYkpvR2d0SE5GNmpyRENWVzVIU2NtM1JtVzdR?= =?utf-8?B?cUVxd0QyM0hiaUtMc3VsQlZDVTkvODhtWnlza1NSbi9FYVdLT0F4Z0JqOGxl?= =?utf-8?B?MU43Sk1lN2ViY01zSC9wWlJaYVVEVlVxZlphVUNaOXVEQk5CNnJxOWY3RmNE?= =?utf-8?B?K1N4WXI4QWNLcGFlRzgxaFMvYjhVZ3ozZTdFejUzMjhkejRLdTRwVnpsT3Rl?= =?utf-8?B?bjFhRnFDV2dVOUtMdG9yY2JodDZ6WHdwRUt6SDlmTmdzQ0tZbWRKc1QrYnBW?= =?utf-8?B?Qzl0UDYyVTVFWlB5dXZ1SWFiZ0Z1cHNmVjdrQmRlN3h5b0VCdFZEQmtYbkhk?= =?utf-8?B?Y1BQNjlPSmRIcHpHbGRSdzcySG5kdUJoU2FSNUltcll2YlVvZUczNG1pOUxo?= =?utf-8?B?U3BzZ1lBMkJPYnF6MjFvWjFQVkJYaUVlOEVzN3N5RGIrVlhlbk55NUxLbWVv?= =?utf-8?B?SVk5RWlSU1h5bm4vN1hYVUt5b3AvTGxSRWpkeGdQNlVmTWVqYUlqRU14dVhv?= =?utf-8?B?Q3JSUmhxajVMY2I4Unp5Q3ZNUjI0YlRkOXN1c01RRGZtTVlTMjdveHFIbnMz?= =?utf-8?B?bDJ2MEoyTW9BSmFBUlVIT3hsZ0orQWtLblNiQVoxYmd6K1NDcmJqbWdwckZm?= =?utf-8?B?M3ZZT01xekQ1eTZ6dmpKenlFYTNyOVREMWZNVkZ1LzZ5UmFSdnJFa2Mzc1hj?= =?utf-8?B?dGxMV1N1RnpXTzRWVEg5M20wNHU4NFBsSVg0SzZzeWlkejlRZFFVYndEbkY3?= =?utf-8?B?eTZ0UDM3RXRMcTFPTVovWmR1cVFNN3F4Z3ByOTEwQU52S0pZNkFEVVlUeEtY?= =?utf-8?B?LzllNVVWUFFjK0xHZnpIQVA0OE9Ba2VyLzFWUkw1NnJrMkNwWldyby8xOS9j?= =?utf-8?B?dkRPMVJuV2E4dTNlOXpDdU5CRGk2YmdjQ3BJNnFsV2R4MHkvMTJJM0xFdTZC?= =?utf-8?B?ckMrdXIySEgwbmxUM0tIb3ZTZllzS21WVnhORm9oSUtUamdmejR1eWxpY2g1?= =?utf-8?B?MThZT0tOT0kzQy91N0M4c1BvbmhQVzk2VW41RWd0OURDLzhDOWUrNE83L2tM?= =?utf-8?B?ejVqb0p4WDhPTWdPTmFsUmNlWWw2NXFkTFlDazU4K2syLytyVkNlTjM3SS9K?= =?utf-8?B?S0RJTWlabmlSamNvbis4YzRwTEl1SFhNcFVQSTN4NmVNTThRTTBsWjU2S0tE?= =?utf-8?B?dEw0M1FxdmU2SUlFTllkYSt0dmFmUElRMDJyQ1dCb0hMQVk4S0FCQWFCOVda?= =?utf-8?B?VDYwc2xZYkNNdUJQemNPKzVrcTlCREFoanNqRGhpSnZhTFFmY0ExdVZnQ1Fh?= =?utf-8?B?aVc5RHI1dmRPN25GZ0hJQ00wczY4ZHhIUzFwMWJYS0huMHF3b01hTzR3RDZi?= =?utf-8?B?QmRmZkNoSW5EU1B1MkdMZ2pCWTlmbHRGOHNITW1PRmdkQzcxVEdCblA3SDQ4?= =?utf-8?B?SU9KVEYvclVKcWZOQndKUnJyckV0Y3gyQkhZeE1KeERFd3JzQ0VNTHVKUFhl?= =?utf-8?B?OHZSTEJJNkV0MnphcUFvOU1EenorUzl4TmRHV2hIRlJwbGR0bkVYaVFiVGp2?= =?utf-8?B?SkFIL3JyMTBlT092eUYvM3VubGFGNEw2MjRXb2NhRE5WZ1h3YUN2UEZCSkZV?= =?utf-8?B?TlRkYkVIQ09VOS8rY3FZaG5QMENKVHd2RzkxTE9YajY5ajhuVGVzYTh5Q0FZ?= =?utf-8?B?SkNNb3ZyNlEwMlFxb3IvbXJjcGVBV1ZWcnhIVFVFTWExTUltOTc1REs4TXha?= =?utf-8?B?NGRMZ0VjdmpJdXV2S2ltNFVCSkZ2VDJDQVhYYzNTM0wrRkRlUW5wa25BcG4z?= =?utf-8?B?dkJkYnhqc2NrUkZud2t5elBrdFQzdjExalBPMTdOQnVJMGlFamFqSjJTa3lj?= =?utf-8?B?bjNSM2VkeDZRamkxSWdyelJWVEw2VHlTb2ExcUpmUjhhdDdhUlZtUlpHOWYw?= =?utf-8?B?Mmtkd3U3TksvMmQvNThVQVoxejdSMVRzakJRTHlqelQxV1BlQUJVcGg0NzY2?= =?utf-8?B?WFZPOGh3QW92OVZJYUxkR1JoRUpUQnlTb3FITEkvNGpGb2VWM2t1Z3hFS0dm?= =?utf-8?B?bzBsRGZVTTZsWmxJT05zNFhpRERDZjIxd3hvVVE3ZXVwNFJ3aEtETWFIK01r?= =?utf-8?Q?YY+uEhLdjWuitUH71mD0FXZqc?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee99319-8927-4495-631f-08db52e00677 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 11:57:14.0332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OOHL49D00Y1rBN/zQuV1zgnDBKwbWTEc7yWkAvC0bxykiVPs2v0Psq6sNsDZ7JoJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6270 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/8/2023 12:47 PM, Denis Pryazhennikov wrote: > The documentation for the FEC API is currently incomplete and contains > inaccuracies in its descriptions of function parameters. > Specifically, the semantics of the fec_capa parameter in rte_eth_fec_set() > is not well-defined. It does not provide information on what should > be done if only AUTO bit is set or one of the specified FEC modes is > not supported. Additionally, the fec_capa parameter in rte_eth_fec_get() > implies that more than one FEC mode can be obtained, but it is > wrong. Furthermore, the behaviour is undefined in > rte_eth_fec_set() when the fec_capa parameter is zero. > > To address these issues, a patch series has been created that updates > the FEC API documentation, renames one of the parameters to improve > its clarity and adds a check for zero fec_capability. > > v2: > * Update documentation for rte_eth_fec_set() to fix review comments. > * Don't rename the fec_capa parameter of rte_eth_fec_get() but > add a proper description instead. > > Denis Pryazhennikov (3): > ethdev: update documentation for API to set FEC > ethdev: check that at least one FEC mode is specified > ethdev: update documentation for API to get FEC > For series, Acked-by: Ferruh Yigit +cc Author and reviewer of original patch, if there is no objection I can proceed with the set. @Denis, can you please provide Fixes tags too? If you prefer you can send a new version with ack and fixes tags.