From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Zhang, Xiao" <xiao.zhang@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
dev@dpdk.org, "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset
Date: Mon, 11 Nov 2019 14:59:39 +0100 [thread overview]
Message-ID: <08143075-3803-4665-B916-3BA894FAE2AA@redhat.com> (raw)
In-Reply-To: <724A0BBE-66F4-40D3-A38E-8F4E9C09ECC5@redhat.com>
On 1 Nov 2019, at 9:12, Eelco Chaudron wrote:
<SNIP>
>>>>>>>>
>>>>>>>> + /*
>>>>>>>> + * Even though the device reset is successful disabling
>>>>>>>> promiscuous
>>>>>>>> + * mode might not always succeed, causing enabling it after
>>>>>>>> reset
>>>>>>>> to
>>>>>>
>>>>>> I think we need to root cause why fail to disable promiscuous
>>>>>> mode
>>>>>> and
>>>>>> try to fix it first.
>>>>>
>>>>> I’ve copied in Xiao who helped me identify the issue in your
>>>>> driver.
>>>>>
>>>>> The issue is because the change from kernel pf was not synced to
>>>>> DPDK
>>>>> vf during
>>>>> the closing period of reset, so we get this failure. Xiao can you
>>>>> add
>>>>> more details?
>>>>>
>>>>
>>>> The root cause is when kernel pf generate DPDK vf reset event, the
>>>> flag
>>>> vf->promisc_unicast_enabled will not be cleared but promiscuous
>>>> mode
>>>> is
>>>> disabled. When trying to enable promiscuous mode next time by
>>>> calling
>>>> i40evf_dev_promiscuous_enable won't work because it will check the
>>>> vf->promisc_unicast_enabled flag first.
>>>>
>>>> static int
>>>> i40evf_dev_promiscuous_enable(struct rte_eth_dev *dev)
>>>> {
>>>> ...
>>>> /* If enabled, just return */
>>>> if (vf->promisc_unicast_enabled)
>>>> return 0;
>>>> ...
>>>> }
>>>>
>>>> Hi Eelco,
>>>>
>>>> I think you may need add more detailed message in the commit log or
>>>> comments.
>>>
>>> My interpretation of the request was that Beilei wanted to know why
>>> disabling promiscuous mode in HW was failing. Beilei can you
>>> comment, is
>>> the additional description from Xiao enough?
>>
>> Yes, promisc_unicast_enabled flag is not cleared during vf reset
>> because fail to disable promiscuous mode,
>> So I think we need to root cause why fail to disable promiscuous
>> mode first.
>> This patch looks like a workaround but not a fix.
>>
>
> This was debugged together with Xiao and from what I understand is
> that DPDK fails to reset promiscuous mode in hardware as PF and VF
> operations are not synced between kernel and DPDK.
>
> Xiao told me this could not be fixed in another way, Xiao can you
> comment?
>
Xiao any update you can add to this so it’s more clear for Beilei?
Thanks,
Eelco
prev parent reply other threads:[~2019-11-11 13:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 7:40 Eelco Chaudron
2019-10-15 10:31 ` Eelco Chaudron
2019-10-17 6:34 ` Xing, Beilei
2019-10-25 9:23 ` Eelco Chaudron
2019-10-29 7:39 ` Zhang, Xiao
2019-10-29 7:47 ` Eelco Chaudron
2019-11-01 2:38 ` Xing, Beilei
2019-11-01 8:12 ` Eelco Chaudron
2019-11-06 4:58 ` Zhang, Xiao
2019-11-12 0:52 ` Zhang, Xiao
2019-11-12 11:09 ` Eelco Chaudron
2019-11-13 1:14 ` Zhang, Xiao
2019-11-19 13:55 ` Eelco Chaudron
2019-11-11 13:59 ` Eelco Chaudron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08143075-3803-4665-B916-3BA894FAE2AA@redhat.com \
--to=echaudro@redhat.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).