From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07BF6A00C2; Fri, 24 Apr 2020 11:12:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0906B1BF80; Fri, 24 Apr 2020 11:12:16 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 2D5A31BF67 for ; Fri, 24 Apr 2020 11:12:14 +0200 (CEST) IronPort-SDR: wmvxWcyLbiu8ge8koWqnQC/EkqlgPAU0J60kenyudKPV1MHCTzUSj6hx7GQ9ZxkzE8Vk7d2wdG LDkcRBwg0b+Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 02:12:13 -0700 IronPort-SDR: KcW5gVjKYiALxHZ7RUKO8gJ+pe3yHYL6qiEnHkkEfL3cx39meZsyWZ3XPX1qy6BIBy7KRyoag+ CRBNS71LBKpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,311,1583222400"; d="scan'208";a="256307347" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.212.61.196]) ([10.212.61.196]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2020 02:12:11 -0700 To: David Marchand Cc: Li Feng , dev , Kyle Zhang , Feng Li , fanyang@smartx.com References: <20200420070508.645533-1-fengli@smartx.com> <20200423154302.2217041-1-fengli@smartx.com> <9d6dc63b-34f7-36b3-5c3f-df74b71d961c@intel.com> From: "Burakov, Anatoly" Message-ID: <083d248a-77dd-0b07-cb8b-f2703e8503f5@intel.com> Date: Fri, 24 Apr 2020 10:12:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: add madvise to avoid dump memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 23-Apr-20 9:04 PM, David Marchand wrote: > On Thu, Apr 23, 2020 at 6:34 PM Burakov, Anatoly > wrote: >>> diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c >>> index cc7d54e0c..2d9564b28 100644 >>> --- a/lib/librte_eal/common/eal_common_memory.c >>> +++ b/lib/librte_eal/common/eal_common_memory.c >>> @@ -177,6 +177,20 @@ eal_get_virtual_area(void *requested_addr, size_t *size, >>> after_len = RTE_PTR_DIFF(map_end, aligned_end); >>> if (after_len > 0) >>> munmap(aligned_end, after_len); >>> + >>> + /* >>> + * Exclude this pages from a core dump. >>> + */ >>> + if (madvise(aligned_addr, *size, MADV_DONTDUMP) != 0) >>> + RTE_LOG(WARNING, EAL, "Madvise with MADV_DONTDUMP failed: %s\n", >>> + strerror(errno));> + } else { >>> + /* >>> + * Exclude this pages from a core dump. >>> + */ >>> + if (madvise(mapped_addr, map_sz, MADV_DONTDUMP) != 0) >>> + RTE_LOG(WARNING, EAL, "Madvise with MADV_DONTDUMP failed: %s\n", >>> + strerror(errno)); >>> } >>> >>> return aligned_addr; >>> >> >> For the contents of this patch, > > MADV_DONTDUMP does not seem POSIX, but as I said [1], there seems to > be a MADV_NOCORE option on FreeBSD. > 1: http://inbox.dpdk.org/dev/CAJFAV8y9YtT-7njUz+mD6U8+3XUqYrgp28KD7jy2923EpAcXrg@mail.gmail.com/ > > Oh, right, so this would probably not compile on FreeBSD. Perhaps this function would have to be OS-specific after all (or call into an OS-specific madvise() after reserving the memory area). >> >> Acked-by: Anatoly Burakov >> >> However, even though this is good to have, after some more thought, i >> believe the fix is incomplete, because this is not the only place we're >> reserving anonymous memory. We're also doing so in >> `eal_memalloc.c:free_seg()`, so an `madvise()` call should also be added >> there. >> >> @David, now that i think of it, the PROT_NONE patch also was incomplete, >> as we only set PROT_NONE to memory that's initially reserved, but not >> when it's unmapped and returned back to the pool of anonymous memory. >> So, eal_memalloc.c should also remap anonymous memory with PROT_NONE. > > I can't disagree if you say so :-). Nice to have that kind of power! *evil laugh* > >> >> @Li Feng, would you be so kind as to provide a patch replacing PROT_READ >> with PROT_NONE in eal_memalloc.c as well? Thank you very much! >> > > Once we have the proper fixes, I'd like to get this Cc: stable@dpdk.org. > Thanks. > > -- Thanks, Anatoly