From: "Raz Amir" <razamir22@gmail.com>
To: "'Bruce Richardson'" <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] pci: save list of detached devices, and re-probe during driver unload
Date: Tue, 10 Mar 2015 10:15:07 +0200 [thread overview]
Message-ID: <084e01d05b0a$52f28350$f8d789f0$@gmail.com> (raw)
In-Reply-To: <20150309102742.GA960@bricha3-MOBL3>
Sorry for that. Will send the new patch soon
-----Original Message-----
From: Bruce Richardson [mailto:bruce.richardson@intel.com]
Sent: 09 March 2015 12:28
To: Raz Amir
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] pci: save list of detached devices, and re-probe
during driver unload
On Mon, Mar 09, 2015 at 10:07:29AM +0200, Raz Amir wrote:
> Hi, gentle reminder about this patch...
>
> On Mar 4, 2015, at 1:15 PM, Raz Amir <razamir22@gmail.com> wrote:
>
> Added code that saves the pointers to the detached devices, during
> driver loading, and during driver unloading, go over the list, and
> re-attach them by calling device_probe_and_attach on each device.
>
> Signed-off-by: Raz Amir <razamir22@gmail.com>
> ---
> lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32
> ++++++++++++++++++++++++++++----
> 1 file changed, 28 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> index 5ae8560..78e4dea 100644
> --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$");
>
> #define MAX_BARS (PCIR_MAX_BAR_0 + 1)
>
> +#define MAX_DETACHED_DEVICES 128
> +static device_t detached_devices[MAX_DETACHED_DEVICES] = {}; static
> +int num_detached = 0;
>
> struct nic_uio_softc {
> device_t dev_t;
> @@ -289,16 +292,37 @@ nic_uio_load(void)
>
> dev = pci_find_bsf(bus, device, function);
> if (dev != NULL)
> - for (i = 0; i < NUM_DEVICES; i++)
> - if (pci_get_vendor(dev) == devices[i].vend &&
> - pci_get_device(dev) == devices[i].dev)
> - device_detach(dev);
> + continue;
Since we have changed the body to be a continue statement, I think the
condition above needs to be flipped.
/Bruce
next prev parent reply other threads:[~2015-03-10 8:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 6:33 [dpdk-dev] [PATCH] " Raz Amir
2015-03-01 13:48 ` Neil Horman
2015-03-01 14:21 ` Raz Amir
2015-03-01 17:16 ` Neil Horman
2015-03-02 8:18 ` Raz Amir
2015-03-02 11:36 ` Neil Horman
2015-03-02 11:58 ` Raz Amir
2015-03-02 13:29 ` Thomas Monjalon
2015-03-03 11:30 ` Raz Amir
2015-03-03 11:45 ` Bruce Richardson
2015-03-03 12:56 ` Raz Amir
2015-03-03 13:32 ` Bruce Richardson
2015-03-04 9:07 ` Raz Amir
2015-03-04 10:13 ` Bruce Richardson
2015-03-04 10:28 ` Raz Amir
2015-03-04 11:15 ` [dpdk-dev] [PATCH v3] " Raz Amir
2015-03-09 8:07 ` Raz Amir
2015-03-09 10:27 ` Bruce Richardson
2015-03-10 8:15 ` Raz Amir [this message]
2015-03-04 11:47 ` [dpdk-dev] [PATCH v2] " Raz Amir
2015-03-05 14:59 ` [dpdk-dev] [PATCH v4] " Raz Amir
2015-03-05 16:24 ` Raz Amir
2015-03-11 10:26 ` Bruce Richardson
2015-03-12 12:24 ` Raz Amir
2015-03-16 16:29 ` Thomas Monjalon
2015-07-08 22:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='084e01d05b0a$52f28350$f8d789f0$@gmail.com' \
--to=razamir22@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).