DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/i40e: fix Virtchnl Offload Caps missing
@ 2021-03-12  8:52 Robin Zhang
  2021-03-12  9:29 ` Guo, Jia
  0 siblings, 1 reply; 3+ messages in thread
From: Robin Zhang @ 2021-03-12  8:52 UTC (permalink / raw)
  To: dev; +Cc: beilei.xing, jia.guo, Robin Zhang

A new feature requesting additional queues from PF is added in iavf, before
sending VIRTCHNL_OP_REQUEST_QUEUES op code, the offload capability flag
VIRTCHNL_VF_OFFLOAD_REQ_QUEUES will be checked. And due to DPDK PF is
still used by some cases, so add this offload capability flag in i40e pf.

Fixes: cbdbd360f77f ("net/i40e: support AVF basic interface")

Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
 drivers/net/i40e/i40e_pf.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
index f3d6d899f6..9804ed4253 100644
--- a/drivers/net/i40e/i40e_pf.c
+++ b/drivers/net/i40e/i40e_pf.c
@@ -333,6 +333,10 @@ i40e_pf_host_process_cmd_get_vf_resource(struct i40e_pf_vf *vf, uint8_t *msg,
 
 	vf_res->vf_cap_flags = vf->request_caps &
 				   I40E_VIRTCHNL_OFFLOAD_CAPS;
+
+	if (vf->request_caps & VIRTCHNL_VF_OFFLOAD_REQ_QUEUES)
+		vf_res->vf_cap_flags |= VIRTCHNL_VF_OFFLOAD_REQ_QUEUES;
+
 	/* For X722, it supports write back on ITR
 	 * without binding queue to interrupt vector.
 	 */
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: fix Virtchnl Offload Caps missing
  2021-03-12  8:52 [dpdk-dev] [PATCH] net/i40e: fix Virtchnl Offload Caps missing Robin Zhang
@ 2021-03-12  9:29 ` Guo, Jia
  2021-03-25  8:15   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Guo, Jia @ 2021-03-12  9:29 UTC (permalink / raw)
  To: Zhang, RobinX, dev; +Cc: Xing, Beilei

Acked-by: Jeff Guo <jia.guo@intel.com>

> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Friday, March 12, 2021 4:52 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Zhang,
> RobinX <robinx.zhang@intel.com>
> Subject: [PATCH] net/i40e: fix Virtchnl Offload Caps missing
> 
> A new feature requesting additional queues from PF is added in iavf, before
> sending VIRTCHNL_OP_REQUEST_QUEUES op code, the offload capability
> flag VIRTCHNL_VF_OFFLOAD_REQ_QUEUES will be checked. And due to
> DPDK PF is still used by some cases, so add this offload capability flag in i40e
> pf.
> 
> Fixes: cbdbd360f77f ("net/i40e: support AVF basic interface")
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_pf.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index
> f3d6d899f6..9804ed4253 100644
> --- a/drivers/net/i40e/i40e_pf.c
> +++ b/drivers/net/i40e/i40e_pf.c
> @@ -333,6 +333,10 @@ i40e_pf_host_process_cmd_get_vf_resource(struct
> i40e_pf_vf *vf, uint8_t *msg,
> 
>  	vf_res->vf_cap_flags = vf->request_caps &
>  				   I40E_VIRTCHNL_OFFLOAD_CAPS;
> +
> +	if (vf->request_caps & VIRTCHNL_VF_OFFLOAD_REQ_QUEUES)
> +		vf_res->vf_cap_flags |=
> VIRTCHNL_VF_OFFLOAD_REQ_QUEUES;
> +
>  	/* For X722, it supports write back on ITR
>  	 * without binding queue to interrupt vector.
>  	 */
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: fix Virtchnl Offload Caps missing
  2021-03-12  9:29 ` Guo, Jia
@ 2021-03-25  8:15   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-03-25  8:15 UTC (permalink / raw)
  To: Guo, Jia, Zhang, RobinX, dev; +Cc: Xing, Beilei



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guo, Jia
> Sent: Friday, March 12, 2021 5:29 PM
> To: Zhang, RobinX <robinx.zhang@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix Virtchnl Offload Caps missing
> 
> Acked-by: Jeff Guo <jia.guo@intel.com>
> 
> > -----Original Message-----
> > From: Zhang, RobinX <robinx.zhang@intel.com>
> > Sent: Friday, March 12, 2021 4:52 PM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia
> > <jia.guo@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
> > Subject: [PATCH] net/i40e: fix Virtchnl Offload Caps missing
> >
> > A new feature requesting additional queues from PF is added in iavf,
> > before sending VIRTCHNL_OP_REQUEST_QUEUES op code, the offload
> > capability flag VIRTCHNL_VF_OFFLOAD_REQ_QUEUES will be checked. And
> > due to DPDK PF is still used by some cases, so add this offload
> > capability flag in i40e pf.
> >
> > Fixes: cbdbd360f77f ("net/i40e: support AVF basic interface")
> >
> > Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
> > ---

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-25  8:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12  8:52 [dpdk-dev] [PATCH] net/i40e: fix Virtchnl Offload Caps missing Robin Zhang
2021-03-12  9:29 ` Guo, Jia
2021-03-25  8:15   ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git