From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9888E9E4; Wed, 7 Mar 2018 12:51:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2018 03:51:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,435,1515484800"; d="scan'208";a="180638691" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga004.jf.intel.com with ESMTP; 07 Mar 2018 03:51:13 -0800 To: Alejandro Lucero , dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon References: <1519299039-2475-1-git-send-email-alejandro.lucero@netronome.com> From: Ferruh Yigit Message-ID: <08903494-e046-9282-9557-0ec733298c87@intel.com> Date: Wed, 7 Mar 2018 11:51:13 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519299039-2475-1-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix barrier location X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 11:51:17 -0000 On 2/22/2018 11:30 AM, Alejandro Lucero wrote: > The barrier needs to be after reading the DD bit. It has not been > a problem because the potential reads which can not happen before > reading the DD bit seem to be far enough, so the compiler is not > rescheduling them. However, a refactoring could make this problem > to arise. > > Fixes: b812daadad0d ("nfp: add Rx and Tx") Cc: stable@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks. Unrelated to this patch but nfp driver is still missing: 1- SPDX licensing tags 2- new offloading API. Can you please plan for them for this release? Specially second one is important because missing it may break the driver for this release. Thanks, ferruh