From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 051BE45923; Thu, 12 Sep 2024 03:14:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C23734027D; Thu, 12 Sep 2024 03:14:53 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id EF4B140267 for ; Thu, 12 Sep 2024 03:14:50 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4X3zxW65M2z20nrW; Thu, 12 Sep 2024 09:14:39 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 79ECF1401F2; Thu, 12 Sep 2024 09:14:46 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 12 Sep 2024 09:14:46 +0800 Message-ID: <08a264fe-4935-486c-ae84-ae19340b0d98@huawei.com> Date: Thu, 12 Sep 2024 09:14:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/2] power: introduce PM QoS API on CPU wide To: "lihuisong (C)" , CC: , , , , , , , , References: <20240320105529.5626-1-lihuisong@huawei.com> <20240809095012.16717-1-lihuisong@huawei.com> <20240809095012.16717-2-lihuisong@huawei.com> <77be0eac-5676-90af-9564-3c1a14779fd5@huawei.com> <23c6701f-9901-1ddd-ca24-c4ea12ace45a@huawei.com> Content-Language: en-US From: fengchengwen In-Reply-To: <23c6701f-9901-1ddd-ca24-c4ea12ace45a@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/9/10 17:32, lihuisong (C) wrote: > Hi Chengwen, > > Thanks for your review. > > 在 2024/9/10 10:00, fengchengwen 写道: >> Hi Huisong >> >> Please see comments inline. >> >> Thanks >> >> On 2024/8/9 17:50, Huisong Li wrote: >>> The deeper the idle state, the lower the power consumption, but the longer >>> the resume time. Some service are delay sensitive and very except the low >>> resume time, like interrupt packet receiving mode. >>> >>> And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs >>> interface is used to set and get the resume latency limit on the cpuX for >>> userspace. Each cpuidle governor in Linux select which idle state to enter >>> based on this CPU resume latency in their idle task. >>> >>> The per-CPU PM QoS API can be used to control this CPU's idle state >>> selection and limit just enter the shallowest idle state to low the delay >>> after sleep by setting strict resume latency (zero value). >>> >>> Signed-off-by: Huisong Li >>> Acked-by: Morten Brørup >>> --- >> ... >> ... >>> diff --git a/lib/power/version.map b/lib/power/version.map >>> index c9a226614e..4e4955a4cf 100644 >>> --- a/lib/power/version.map >>> +++ b/lib/power/version.map >>> @@ -51,4 +51,8 @@ EXPERIMENTAL { >>>       rte_power_set_uncore_env; >>>       rte_power_uncore_freqs; >>>       rte_power_unset_uncore_env; >>> + >>> +    # added in 24.11 >>> +    rte_power_qos_set_cpu_resume_latency; >>> +    rte_power_qos_get_cpu_resume_latency; >> order by alphabetic. > Ack >> >> another question, I think rename cpu with core maybe more accurate, despite sysfs export with cpu, but in DPDK it means core. >> and there are some rte_power_core_xxx name in rte_power library, I think better to keep the same. > Firstly, the rte_power_qos_set/get_cpu_resume_latency is just consistent with linux sysfs interface. Having the same name is more releative for user. > In addition, Sivaprasad Tummala is reworking power library and the name of rte_power_core_xxx also might be changed. ok >> >>>   }; >>> >> .