From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E6BBD108A for ; Wed, 8 Mar 2017 12:20:43 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2017 03:20:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,262,1486454400"; d="scan'208";a="233659875" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.176.34]) ([10.254.176.34]) by fmsmga004.fm.intel.com with ESMTP; 08 Mar 2017 03:20:40 -0800 To: Wei Zhao , dev@dpdk.org References: <1488516984-34702-1-git-send-email-wei.zhao1@intel.com> <1488516984-34702-4-git-send-email-wei.zhao1@intel.com> Cc: Wenzhuo Lu From: Ferruh Yigit Message-ID: <08c8c198-7202-f45c-80d9-580a15bc7569@intel.com> Date: Wed, 8 Mar 2017 11:20:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1488516984-34702-4-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: implement device reset on port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 11:20:44 -0000 On 3/3/2017 4:56 AM, Wei Zhao wrote: > Implement the device reset function on vf port. > This restart function will detach device then > attach device, reconfigure dev, re-setup the Rx/Tx queues. > > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu <...> > +static int i40evf_dev_uninit(struct rte_eth_dev *eth_dev); > +static int i40evf_dev_init(struct rte_eth_dev *eth_dev); > +static void i40evf_dev_close(struct rte_eth_dev *dev); > +static int i40evf_dev_start(struct rte_eth_dev *dev); > +static int i40evf_dev_configure(struct rte_eth_dev *dev); > +static int i40evf_handle_vf_reset(struct rte_eth_dev *dev); Some of them already seems declared, please avoid unnecessary or duplicate declarations. > + > > /* Default hash key buffer for RSS */ > static uint32_t rss_key_default[I40E_VFQF_HKEY_MAX_INDEX + 1]; > @@ -230,6 +237,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = { > .rss_hash_conf_get = i40evf_dev_rss_hash_conf_get, > .mtu_set = i40evf_dev_mtu_set, > .mac_addr_set = i40evf_set_default_mac_addr, > + .dev_reset = i40evf_handle_vf_reset, > }; > > /* > @@ -885,10 +893,13 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev, > args.out_buffer = vf->aq_resp; > args.out_size = I40E_AQ_BUF_SZ; > err = i40evf_execute_vf_cmd(dev, &args); > - if (err) > + if (err) { > PMD_DRV_LOG(ERR, "fail to execute command " > "OP_ADD_ETHER_ADDRESS"); > - > + goto DONE; Please prefer lowercase labels, also this is error exit, I would prefer other name than "done" > + } > + vf->vsi.mac_num++; > +DONE: > return; > } > <...> > +static int > +i40evf_handle_vf_reset(struct rte_eth_dev *dev) > +{ > + struct i40e_adapter *adapter = > + I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > + > + if (!dev->data->dev_started) > + return 0; > + > + adapter->reset_number = 1; > + i40e_vf_reset_dev(dev); What happens if user called this function for PF ? > + adapter->reset_number = 0; > + > + return 0; > +} > + <...>