From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8080F108D for ; Mon, 23 Jan 2017 13:22:52 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 23 Jan 2017 04:22:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,274,1477983600"; d="scan'208";a="1086254436" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga001.jf.intel.com with ESMTP; 23 Jan 2017 04:22:50 -0800 To: Wei Zhao , dev@dpdk.org References: <1485142340-49032-1-git-send-email-wei.zhao1@intel.com> Cc: zhao wei From: Ferruh Yigit Message-ID: <0909b05d-2058-b51a-f974-f2d686392a5d@intel.com> Date: Mon, 23 Jan 2017 12:22:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485142340-49032-1-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: add more check in n-tuple filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 12:22:52 -0000 On 1/23/2017 3:32 AM, Wei Zhao wrote: > Add more check on the mask of src_addr, dst_addr and next_proto_id > in n-tuple filter rule pattern parser.If do not add such check, > it maybe cause error in pattern parser. > > Signed-off-by: zhao wei > --- > drivers/net/ixgbe/ixgbe_flow.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c > index 82aceed..8f78eee 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -331,7 +331,10 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, > ipv4_mask->hdr.packet_id || > ipv4_mask->hdr.fragment_offset || > ipv4_mask->hdr.time_to_live || > - ipv4_mask->hdr.hdr_checksum) { > + ipv4_mask->hdr.hdr_checksum || > + !ipv4_mask->hdr.next_proto_id || > + !ipv4_mask->hdr.dst_addr || > + !ipv4_mask->hdr.src_addr ||) { The '||' at the end seems extra. Also can you please confirm your sign off? > rte_flow_error_set(error, > EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, > item, "Not supported by ntuple filter"); >