From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [PATCH 1/2] net/ngbe: fix debug log
Date: Mon, 21 Feb 2022 13:06:01 +0000 [thread overview]
Message-ID: <090d35bb-fbab-1572-d8da-94d5156c22e4@intel.com> (raw)
In-Reply-To: <20220221092121.2145802-2-jiawenwu@trustnetic.com>
On 2/21/2022 9:21 AM, Jiawen Wu wrote:
> Remove 'DEBUGFUNC' due to too many invalid debug log prints, unify the
> DEBUG level macros.
>
> Fixes: cc934df178ab ("net/ngbe: add log and error types")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
<...>
> @@ -91,7 +86,7 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw)
>
> if (i == timeout) {
> DEBUGOUT("Driver can't access the eeprom - SMBI Semaphore "
> - "not granted.\n");
> + "not granted.");
Not for this patch, but for future, preferred to not break
log messages, coding convention allows longer lines for log
messages.
The logic behid it is to let user able to search the log
she got from the console and easily find it in the code.
<...>
> @@ -590,18 +564,16 @@ s32 ngbe_init_rx_addrs(struct ngbe_hw *hw)
> /* Get the MAC address from the RAR0 for later reference */
> hw->mac.get_mac_addr(hw, hw->mac.addr);
>
> - DEBUGOUT(" Keeping Current RAR0 Addr =%.2X %.2X %.2X ",
> + DEBUGOUT(" Keeping Current RAR0 Addr =%.2X %.2X %.2X %.2X %.2X %.2X",
Not for this patch, but for future, there is 'RTE_ETHER_ADDR_PRT_FMT'
macro that can be used for MAC format. It is good to use
existing macro for consistent output.
next prev parent reply other threads:[~2022-02-21 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 9:21 [PATCH 0/2] Wangxun log fixes Jiawen Wu
2022-02-21 9:21 ` [PATCH 1/2] net/ngbe: fix debug log Jiawen Wu
2022-02-21 13:06 ` Ferruh Yigit [this message]
2022-02-21 9:21 ` [PATCH 2/2] net/txgbe: " Jiawen Wu
2022-02-21 13:10 ` Ferruh Yigit
2022-02-22 2:03 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=090d35bb-fbab-1572-d8da-94d5156c22e4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).