DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Singh, Aman Deep" <aman.deep.singh@intel.com>
To: Dongdong Liu <liudongdong3@huawei.com>, <dev@dpdk.org>,
	<ferruh.yigit@amd.com>, <thomas@monjalon.net>,
	<andrew.rybchenko@oktetlabs.ru>
Cc: <stable@dpdk.org>, <haijie1@huawei.com>,
	Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH 5/7] app/testpmd: add setting and querying of LLRS FEC mode
Date: Fri, 28 Apr 2023 12:20:19 +0530	[thread overview]
Message-ID: <0910b16e-ab94-1570-2924-f6169d41750e@intel.com> (raw)
In-Reply-To: <20230408022740.14522-6-liudongdong3@huawei.com>


On 4/8/2023 7:57 AM, Dongdong Liu wrote:
> From: Jie Hai <haijie1@huawei.com>
>
> This patch supports setting and querying of LLRS FEC mode.
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>

Acked-by: Aman Singh <aman.deep.singh@intel.com>

> ---
>   app/test-pmd/cmdline.c                      | 5 ++++-
>   app/test-pmd/config.c                       | 4 ++++
>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
>   3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 7b20bef4e9..38fa0f507c 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -11973,6 +11973,9 @@ cmd_show_fec_mode_parsed(void *parsed_result,
>   	case RTE_ETH_FEC_MODE_CAPA_MASK(RS):
>   		strlcpy(buf, "rs", sizeof(buf));
>   		break;
> +	case RTE_ETH_FEC_MODE_CAPA_MASK(LLRS):
> +		strlcpy(buf, "llrs", sizeof(buf));
> +		break;
>   	default:
>   		return;
>   	}
> @@ -12068,7 +12071,7 @@ cmd_set_port_fec_mode_parsed(
>   static cmdline_parse_inst_t cmd_set_fec_mode = {
>   	.f = cmd_set_port_fec_mode_parsed,
>   	.data = NULL,
> -	.help_str = "set port <port_id> fec_mode auto|off|rs|baser",
> +	.help_str = "set port <port_id> fec_mode auto|off|rs|baser|llrs",
>   	.tokens = {
>   		(void *)&cmd_set_port_fec_mode_set,
>   		(void *)&cmd_set_port_fec_mode_port,
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 096c218c12..f306d678f9 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -170,6 +170,10 @@ static const struct {
>   		.mode = RTE_ETH_FEC_RS,
>   		.name = "rs",
>   	},
> +	{
> +		.mode = RTE_ETH_FEC_LLRS,
> +		.name = "llrs",
> +	},
>   };
>   
>   static const struct {
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 8f23847859..fa1cea3ed6 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -1800,7 +1800,7 @@ Set fec mode
>   
>   Set fec mode for a specific port::
>   
> -  testpmd> set port (port_id) fec_mode auto|off|rs|baser
> +  testpmd> set port (port_id) fec_mode auto|off|rs|baser|llrs
>   
>   Config Sample actions list
>   ~~~~~~~~~~~~~~~~~~~~~~~~~~

  reply	other threads:[~2023-04-28  6:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-08  2:27 [PATCH 0/7] " Dongdong Liu
2023-04-08  2:27 ` [PATCH 1/7] net/hns3: fix fec mode for 200G ports Dongdong Liu
2023-04-08  2:27 ` [PATCH 2/7] net/hns3: fix fec mode check error Dongdong Liu
2023-04-08  2:27 ` [PATCH 3/7] net/hns3: fix missing FEC capability Dongdong Liu
2023-04-08  2:27 ` [PATCH 4/7] ethdev: introduce low latency RS FEC Dongdong Liu
2023-06-01  8:30   ` Ferruh Yigit
2023-04-08  2:27 ` [PATCH 5/7] app/testpmd: add setting and querying of LLRS FEC mode Dongdong Liu
2023-04-28  6:50   ` Singh, Aman Deep [this message]
2023-04-08  2:27 ` [PATCH 6/7] net/hns3: add LLRS FEC mode support for 200G ports Dongdong Liu
2023-04-08  2:27 ` [PATCH 7/7] net/hns3: support getting current FEC capability from firmware Dongdong Liu
2023-06-01  8:30 ` [PATCH 0/7] add setting and querying of LLRS FEC mode Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0910b16e-ab94-1570-2924-f6169d41750e@intel.com \
    --to=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=haijie1@huawei.com \
    --cc=liudongdong3@huawei.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).