From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE33142A12; Fri, 28 Apr 2023 08:50:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 788654113C; Fri, 28 Apr 2023 08:50:43 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 6C6E5406B5; Fri, 28 Apr 2023 08:50:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682664641; x=1714200641; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=T3SXAkNHFroINhDA4WhWZ6eq6oDbBFLNxOmscEVETEw=; b=ZlvY4MU9kTVn+owEJtXF9+K4hOHjECeEx/X9WoWeDjwxId72CQER/Pq9 SSqcleH5XPbahM2m9hFnIJt6xI/bCuWVd0vuT7T1TmcB4DULYWnkj4uAi 4dUocDjWwnO3HAVCvETJrOV3UmjuD1fJluqHIyfkcT4EyG+sEt1Ad/wjg 4dqjMvpqHJb4I64OshyN9LXAYbWef5hsdyEpJoc6ZPys4Uv+kQaHJUFLW od1miAxUnxDiDFvNw3O/L40FzcngtU+Z7FNFws47UuR1q6VB3m5xf7fZO YZTiG1J0Yn2ASQDby8rY6Mwpf0g69rTmcwP+JX8dm0UW1xw9ZZl969+Wy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="327289269" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="327289269" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 23:50:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="784079715" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="784079715" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 27 Apr 2023 23:50:38 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 23:50:38 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 23:50:38 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 23:50:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D1ns9T8Zl7j+7SjoTgVLStX6sAL7EMHHs32Dnt+HWiFtQ404riDWlZV0CJdsYaH/q+Q44AMAST2mM21rSED3G7oNFtYQ6CPDGGOSE9Blfo/DJYLNrulSUgEtBQuJe6oGrsp6yW80KrgpyRMBdhaHF70moPdDH2IPWpg1ik5zq6MU4RDSkIUuQtLjXvHQN2BXG6FE3vobYmtYn7sjQB0gcaTqyKPojG49SL2HEK88LjG83o8WAnG3TpapUHdBZRwDDUDs3Lx/HiBaGMMH66MeORgkkZp2eM0JBt6zmCXwUSmfaPaYSTy9/elvoVaNHu7Psv+deaXo4ZZg5IbvMoGijw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C6a5Z1TaYx1WX1Fmz+IUkjeR1IYSXLNhkcexAH3sqr0=; b=GDsv0NbBwuuTcS6lMxqlktimbrRA6mThoCN+X85fIyDcZxlrfyBbVTnuNGKwJylCLeO/IqXYe6ib4aLI0K9nWGBs9a4dgcPYoDplVFOzpQU32OWRQXNQlH6yftSym8pCm6gTe7EalNu3buzOtyLQEpqshOdvHz5AFGYqb+kCyP3uJAY/DooEFl07yYP4LTTZs7BQT15oeNlguq33HSjhHzNY2lHsn8t9NwFhAe5j+WBnXiwKrJUmZI8DvbZqq0ZfKn6uGyw8+/r517y6X5f+CG318gF7d02Zl7vfDU9McZmHQnyUYIwplDuzE/Wi7CxmeUuBskkUQXd1jMh6AMmUgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by SJ0PR11MB4976.namprd11.prod.outlook.com (2603:10b6:a03:2d7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Fri, 28 Apr 2023 06:50:31 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8d3b:6bb3:3e95:6c05]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8d3b:6bb3:3e95:6c05%5]) with mapi id 15.20.6319.033; Fri, 28 Apr 2023 06:50:30 +0000 Message-ID: <0910b16e-ab94-1570-2924-f6169d41750e@intel.com> Date: Fri, 28 Apr 2023 12:20:19 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 5/7] app/testpmd: add setting and querying of LLRS FEC mode Content-Language: en-US To: Dongdong Liu , , , , CC: , , Yuying Zhang References: <20230408022740.14522-1-liudongdong3@huawei.com> <20230408022740.14522-6-liudongdong3@huawei.com> From: "Singh, Aman Deep" In-Reply-To: <20230408022740.14522-6-liudongdong3@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0008.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:25::13) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|SJ0PR11MB4976:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f15b7bd-2423-43fd-0d80-08db47b4dafc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EHf4gFtxAXdNPS39/rYMe3Y0BV/wk8bGr8ssiutcT3lcxvP4fjLZ1ytWH3iLNxESQt10400WdpNuJiHihjggUEuDkCcBS1f1G34Yc/tV6g+w0oa8ZJUposYuHLlo6VSzSW4dhWYigBIKLF8r/HgOlbwpfuQvg4BcMfZAbbV35vgf5caGJOf4sawjOP760Fq1RT2bmBBFqyEKRwec5boqG4UfPEyfIRJzpNoJ425fq4Yzo+RkTeWz8JOOqIfJeAHfro9aQJ8MoqaVOlDTjk301heL7LJg6o9GBCY6laT9hSVvu+DcQOC4I9FLZcJHfHXM4+WYQZPLIGPyvFj8gLlIk11xOwZJEUNh/oEG7jgrQ4cHu0fwwTxGQn9qd9jvKVh+ZQq5xWSZSlxEsUFx4asbk9ted2yEvm4PZb3GXxHDkgzhjo+sLa3NGape9jdAZt/Ky0o0888gaAUhL7wVzIe0S61GJRcqhiMv4Ipb4d5I5JpJYGczJbfQ0bSFxaXo49OPKV+wVK+fD9UwQ9KGtOzKQHTIgqVxG2aH/xsPyvcBvvlpDgTxaPxTnr2HAitYoRReGMm1EGJmVXWQTxg2thxsxWFsGg54diNCBt5o3CEW/Xa1joPWjkzd7cBf5C8f8f/k7sMcPsvBx/7oL7itY6snwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(39860400002)(366004)(376002)(396003)(451199021)(6666004)(31686004)(82960400001)(478600001)(83380400001)(6486002)(186003)(38100700002)(316002)(2616005)(66946007)(66556008)(66476007)(4326008)(41300700001)(6512007)(6506007)(26005)(107886003)(53546011)(86362001)(8676002)(36756003)(8936002)(31696002)(2906002)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L29lcG9FUjNNbVF0MTE0VTRYYzlpbGFwalRVYmlFNjYyRnZVbXNuQUVrVElL?= =?utf-8?B?V2NSOW96c2VhRzMzWElxaTdveVQ1eDdROGFVWGNZMlZROUpSU2JxdXlSRTh6?= =?utf-8?B?cFZEalNnZDV5OHpuUThhOUc0K3BlNmxFejZjSExFMmVocVJicDBkKzNQdXN6?= =?utf-8?B?bDJvWC9IQWNaOFpXM1VOZlhHSGI4azFVTjVsdEY4VklDeC92RXQyTkZSdEZV?= =?utf-8?B?RVdaZEh0dEFUVjMyd3piTHp4ODNVWXlScU4yZmJCOGZDWEJZRENpVS9ZM0dT?= =?utf-8?B?SUNBd3BNR0J4S3Jja1k2aFFGOEFackNkUWt0QVhyQ0NqZE9JeStBdFV2NVR4?= =?utf-8?B?b3lTaTNZWjB5L3l2cHFicWMwNUNmVFZWeEhQRi9qNjZUNFRUeDlHT252THJu?= =?utf-8?B?TUtVSk56eWFCMGZ0RWw5U2YzUW9xVllUY1pMdXlyaEI2emx6WkVTSGt0TkZk?= =?utf-8?B?cHhOTG9MY2dIazFMQ0xrMlpYVDJSQ1VLZGExNmVRcTNZdFYxOFRQUVZ1ZUlW?= =?utf-8?B?M3g3a2xXL3hkRkdkMkFKWU1LV1hXNUlSS3BVR0ZkSklxbnlZWCsvUWQ3YTVY?= =?utf-8?B?UUpWdTI3djk4TE5nLzR2UnIrWUs0dzBpZ2pDWlpvQUxPQUtRREo0YTU5M3Z1?= =?utf-8?B?NnJKdnU5YnN6UDBGUDNVbTY3WlhTTFVTaXlkMTJGNk9VbzZwRmplTjYyK1lZ?= =?utf-8?B?SThhVjF5LzF1S2x1bXRmSXhMU1FkWk1KNVNLM1RiOW5vZG9RdVR4M2R1c1RK?= =?utf-8?B?dDBRZmRVQzdTVG5hQ283UWFmVDNEbEp6SHQzcjBuOVNhYXVvdG1xdzlJTjZl?= =?utf-8?B?Qk4vU2FMbUtsZjVZb1dabWh5RDhRWDQzREx3VGV6VkhVVHg2NWdvblhSTlk1?= =?utf-8?B?aXRCMDF6OU9hWk8rMHJRU29EMkkwaFFSMUpuQzRsV2E3aXoxemJQSEpBWmdR?= =?utf-8?B?QzBYcEhhWjVReGVQaFNQOG9qaW5IQSs5Y2hOclBwYW9GbUswVlcwa0VuWXdz?= =?utf-8?B?a0FTdmhzK1RiLytHam1oT3hML3ZZOTB3bTVNZ1RTU1d0bUtRRVdtSWMvcmZq?= =?utf-8?B?YTFVSmE1cDZjQlNXUWorWktMekZTcjMzYmk5ZlhjUktvOUlDbU5FTVdRSWRB?= =?utf-8?B?Y3ZEVEhVQmF3ZHlBa0FPekpFNkFQcTE0bWthRGtuRzZPZERXUlU5V3RCd21F?= =?utf-8?B?MlYzN1ZDckhmc295NGRDMFh6YVUxM2ZVd016aHF2WUZYbGR6czJpaFhnM2tH?= =?utf-8?B?QUNSRVNGNm1ndmlub01VUWRYSFo5SFNuWENwRXlKVVdEcGZRdWg4VGoveFpz?= =?utf-8?B?MUZrU0dvcGYyeCtXUVc5aE15NWRGQ0dGNWxmdWl1YU5MRlN4QUVOaDBrYU1j?= =?utf-8?B?SE1jU1FGQkpUQ2xVWGJKeVZ5YXRJdUVXSjFTWGt3bHBpMG5mNmFnMEQ2MEly?= =?utf-8?B?M2JpMkZTa0hXZWsrcGJPUWwzSXBiTVN3d3cwd3VlS3J2NlhQaXd2RzJsdE5t?= =?utf-8?B?a0NDOVFMbVhjNHBka2RIcncrTkFFRWI1S0R3d05PR0ZEdmYyczdvcHZFUC9L?= =?utf-8?B?Wkd3Zzdia0UxYzdNRnNTSjdRS3ZTUUdSMjM3azBpVFFjQkR0WFpXRGJzTlV1?= =?utf-8?B?TGZlV21MQWZ3bXBmSFZldEhqV09KYWo4Qk1iNmhkUkc4V1V0RUR2ZnBMTmhk?= =?utf-8?B?dzI0b3Y1aXpINS9paUh5c1JGQlVGT0E4ZzBtT2RoTU5rTTErT2ExMEs3MGZ1?= =?utf-8?B?c04zN0NJY3VlTUw3UGJ1ZnRMb3o5emxaZ1JtOXVacTFLSERyOFdKbzVqcGZh?= =?utf-8?B?bm5EeDAydkZQZWNzYnJPWHpxOU94d2RoWjV6ZjdQdmpreVRoU1lUaFY2VWd6?= =?utf-8?B?K0NndjgvOGpTcnlqN0pDT3JXa0NIdllsbWJUbzRHWE1PY3pmOGNFNVY0bUhV?= =?utf-8?B?eHNueVoybDBsaUp0R1R1RDFtZ2tlN3ZnS3JidnRqSmEzRWFGRnRnMEhnK1pC?= =?utf-8?B?Q1VBWXpsM1R1TVJ0WE8rQ0pYbmdRUGVnZG9GbHBQelJIeVpmNTNMN2ljRFdn?= =?utf-8?B?V01xcmNQcC8yZG55VTRUMnk3TlFvVmdNV0NvMnRNLzZ3TnBVS2JiRk9iU0pD?= =?utf-8?B?cXM1T1dqR1dDVmhEWlBza2lyTng0N29ZVktaeDUrQWx1NjFveW9FQTN4ZVg1?= =?utf-8?B?Rnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8f15b7bd-2423-43fd-0d80-08db47b4dafc X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 06:50:30.0147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JrYBKKdttu49X1FoqUedvzaDkwNwk6WVWEEkV/WoGZTtu2GAOAXTNyxenKsb3TRmQ7buIhBRj/ehRnfOyDYrvUMYG3FDTuSTwzOVreK2nLQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4976 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/8/2023 7:57 AM, Dongdong Liu wrote: > From: Jie Hai > > This patch supports setting and querying of LLRS FEC mode. > > Signed-off-by: Jie Hai > Signed-off-by: Dongdong Liu Acked-by: Aman Singh > --- > app/test-pmd/cmdline.c | 5 ++++- > app/test-pmd/config.c | 4 ++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 7b20bef4e9..38fa0f507c 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -11973,6 +11973,9 @@ cmd_show_fec_mode_parsed(void *parsed_result, > case RTE_ETH_FEC_MODE_CAPA_MASK(RS): > strlcpy(buf, "rs", sizeof(buf)); > break; > + case RTE_ETH_FEC_MODE_CAPA_MASK(LLRS): > + strlcpy(buf, "llrs", sizeof(buf)); > + break; > default: > return; > } > @@ -12068,7 +12071,7 @@ cmd_set_port_fec_mode_parsed( > static cmdline_parse_inst_t cmd_set_fec_mode = { > .f = cmd_set_port_fec_mode_parsed, > .data = NULL, > - .help_str = "set port fec_mode auto|off|rs|baser", > + .help_str = "set port fec_mode auto|off|rs|baser|llrs", > .tokens = { > (void *)&cmd_set_port_fec_mode_set, > (void *)&cmd_set_port_fec_mode_port, > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 096c218c12..f306d678f9 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -170,6 +170,10 @@ static const struct { > .mode = RTE_ETH_FEC_RS, > .name = "rs", > }, > + { > + .mode = RTE_ETH_FEC_LLRS, > + .name = "llrs", > + }, > }; > > static const struct { > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 8f23847859..fa1cea3ed6 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -1800,7 +1800,7 @@ Set fec mode > > Set fec mode for a specific port:: > > - testpmd> set port (port_id) fec_mode auto|off|rs|baser > + testpmd> set port (port_id) fec_mode auto|off|rs|baser|llrs > > Config Sample actions list > ~~~~~~~~~~~~~~~~~~~~~~~~~~