From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A0D7A04B5; Mon, 11 Jan 2021 21:26:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE0AD140CE6; Mon, 11 Jan 2021 21:26:51 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 12780140CDE for ; Mon, 11 Jan 2021 21:26:50 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id 15so403917pgx.7 for ; Mon, 11 Jan 2021 12:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Zv/eBPh1LoI3JEvnV/UbCuguR0PhWr6mIaIyBf7pLHs=; b=CqKVsQQUefBgbPvNnm5slIqGw4A6cF+Zwtu9ssDXJcY4xWYozGBjU/M6B3t9Bqc8j3 pL2eSkzCHbgOpM/5MP0O9WnWUFD1Rfa8F+2Cpg+toWnLqE7mKJNvfDFPvZVoC36GtJxe WcLjM2ZldXvrKkCyXv3RN55Bt8TtKG4boB2ntoC1iu6yMET5It4/aVvBssDDFltbtSpB 4/O7l7o6NUyCcb9avAtOcq1P3/pBxBVFs9r5xrlnhPoGW5mWQUHXI1+lBT6aocvNAVKA 5ScFfzi8Uhxk9evrRuoS/4TqK2TsrpogmEhH2FYUiq8Bvh+uYbi635WYSl8FXiSG93vQ /UAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Zv/eBPh1LoI3JEvnV/UbCuguR0PhWr6mIaIyBf7pLHs=; b=o03cKHOtcY0+gmg7KFA79VEFZaYLfBIiqWcz5OErTcZ4oxdCwIPKzUazajYg5ookk5 Q8qOJSC/eFhbuYZw6B8NIAVYRE2KxO/lj4c5nR2Ty5gfSkQHXDS7q9xM7IZksAfZLl4P UU7M4cvGRj7VVtHXd5ICH+Ive+37z6ZkI4e7+FvJ+pYCv/Cx2n1H4sSeCyL5daSZ/PZY Myn963w+/MQ6+tu6u3LbvM8N8w+bXsg1hgI7mDPaKZtjgexj2CKjh7ERiXveMdUjKukq NK5utTyf7ACZIMZSpn0boBUJw62xCWuXjIQps0LaU+DWbDraY7iqJjm+bZQqnmdZ6HQS ping== X-Gm-Message-State: AOAM5302xLIp+m3ntX0s7UCuzPJIItpqd0YadOmlEYfV0xtajwojALtZ RLARo5vHiyq/rsgvc0oPLsfoYQ== X-Google-Smtp-Source: ABdhPJym/2nZce/sN36OiL3rvoXTs0DjN24xgbXC5hmqg8EpaH/EM2pB6pqMqYuwdkZ8i0LC59LkUg== X-Received: by 2002:a63:1e1a:: with SMTP id e26mr1269331pge.66.1610396809187; Mon, 11 Jan 2021 12:26:49 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb? ([2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb]) by smtp.gmail.com with ESMTPSA id s13sm528207pfd.99.2021.01.11.12.26.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2021 12:26:48 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <1608724059-8562-4-git-send-email-juraj.linkes@pantheon.tech> Date: Mon, 11 Jan 2021 15:26:46 -0500 Cc: Bruce Richardson , Ruifeng.Wang@arm.com, Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com, Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com, ajit.khaparde@broadcom.com, ferruh.yigit@intel.com, dev@dpdk.org Content-Transfer-Encoding: quoted-printable Message-Id: <091AAEBB-8EF3-4E77-AE85-84925CD18BF2@pensando.io> References: <1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech> <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <1608724059-8562-4-git-send-email-juraj.linkes@pantheon.tech> To: =?utf-8?Q?Juraj_Linke=C5=A1?= X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH v14 03/12] build: reformat and move Arm config and comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Dec 23, 2020, at 6:47 AM, Juraj Linke=C5=A1 = wrote: >=20 > Change formatting so that it's more consistent and readable, = add/modify > comments/stdout messages, move configuration options to more = appropriate > places and make the order consistent according to these rules: > 1. First list generic configuration options, then list options that = may > be overwritten. List SoC-specific options last. > 2. For SoC-specific options, list number of cores before the number of > NUMA nodes, to make it consistent with config/meson.build. >=20 > Signed-off-by: Juraj Linke=C5=A1 > Reviewed-by: Honnappa Nagarahalli > --- > config/arm/arm64_armv8_linux_gcc | 12 +-- > config/arm/meson.build | 96 +++++++++++-------- > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 34 +++++++ > 3 files changed, 93 insertions(+), 49 deletions(-) >=20 > ... > @@ -22,69 +23,86 @@ flags_common =3D [ >=20 > ['RTE_SCHED_VECTOR', false], > ['RTE_ARM_USE_WFE', false], > + ['RTE_ARCH_ARM64', true], > + ['RTE_CACHE_LINE_SIZE', 128] > ] >=20 > +# implementer specific aarch64 flags, with middle priority > +# (will overwrite common flags) > flags_implementer_generic =3D [ > ['RTE_MACHINE', '"armv8a"'], > - ['RTE_MAX_LCORE', 256], > ['RTE_USE_C11_MEM_MODEL', true], > - ['RTE_CACHE_LINE_SIZE', 128]] > + ['RTE_CACHE_LINE_SIZE', 128], > + ['RTE_MAX_LCORE', 256] > +] > ... All of these other instances of [=E2=80=98RTE_CACHE_LINE_SIZE=E2=80=99, = 128] are just repeating the values from flags_common. Would it be = clearer to omit the duplicates? I can imagine a case where SoC uses 128, overriding implementer value of = 64, overriding default value of 128 - but is that worth worrying about? -Andrew=