DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Muhammad Bilal <m.bilal@emumba.com>, beilei.xing@intel.com
Cc: xiaolong.ye@intel.com, dev@dpdk.org, stable@dpdk.org,
	zijie.pan@6wind.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net/i40e: fixed misplaced arguments
Date: Tue, 14 Jul 2020 17:54:02 +0100
Message-ID: <093266f0-1938-026e-1d7e-71db9ee92499@intel.com> (raw)
In-Reply-To: <20200714155847.51442-1-m.bilal@emumba.com>

On 7/14/2020 4:58 PM, Muhammad Bilal wrote:
> Here I have corrected a misplaced argument of i40e_aq_get_phy_register()
> This was also evident after seeing the datatype of its arguments.
> 
> Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e")
> Cc: zijie.pan@6wind.com
> 
> Bugzilla ID: 506
> Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 970a31cb2..5fdfadf7b 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct rte_eth_dev *dev,
>  		}
>  		status = i40e_aq_get_phy_register(hw,
>  				I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
> -				addr, offset, 1, &value, NULL);
> +				addr, 1, offset, &value, NULL);
>  		if (status)
>  			return -EIO;
>  		data[i] = (uint8_t)value;
> 

Hi Muhammad,

This seems already fixed [1], can you please double check in the 'v20.08-rc1'?



[1]
https://git.dpdk.org/dpdk/commit/?id=2fc1d6da882563ab80786d69b6d7c9d0e4ce860a
https://patches.dpdk.org/patch/72827/

  reply	other threads:[~2020-07-14 16:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 15:58 [dpdk-dev] " Muhammad Bilal
2020-07-14 16:54 ` Ferruh Yigit [this message]
2020-07-16  4:58   ` [dpdk-dev] [dpdk-stable] " Muhammad Bilal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=093266f0-1938-026e-1d7e-71db9ee92499@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=m.bilal@emumba.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    --cc=zijie.pan@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git