DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses
@ 2020-09-18 18:53 Long Li
  2020-09-21 13:50 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  2020-09-21 16:04 ` [dpdk-dev] " Kevin Traynor
  0 siblings, 2 replies; 6+ messages in thread
From: Long Li @ 2020-09-18 18:53 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Long Li, stable

From: Long Li <longli@microsoft.com>

The address should be calculated before type cast, not after.

Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
Cc: stable@dpdk.org

Reported-by: Souvik Dey <sodey@rbbn.com>
Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/net/netvsc/hn_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index 813f8c3cc..70f8b8332 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
 
 	txd->queue_id = txq->queue_id;
 	txd->chim_index = NVS_CHIM_IDX_INVALID;
-	txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
-		+ idx * HN_RNDIS_PKT_ALIGNED;
+	txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
+		+ idx * HN_RNDIS_PKT_ALIGNED);
 }
 
 int
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-21 19:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 18:53 [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses Long Li
2020-09-21 13:50 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-09-21 16:04 ` [dpdk-dev] " Kevin Traynor
2020-09-21 16:06   ` Kevin Traynor
2020-09-21 16:19   ` Kevin Traynor
2020-09-21 19:09     ` Long Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).