From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1FD7D29C6 for ; Mon, 25 Feb 2019 08:40:42 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 0C42E400069; Mon, 25 Feb 2019 07:40:40 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Feb 2019 07:40:34 +0000 To: Ian Stokes , CC: References: <1550678275-4959-1-git-send-email-ian.stokes@intel.com> <1550678275-4959-2-git-send-email-ian.stokes@intel.com> From: Andrew Rybchenko Message-ID: <095ee887-0fcf-a5ad-ef8e-435e4b812ed9@solarflare.com> Date: Mon, 25 Feb 2019 10:40:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1550678275-4959-2-git-send-email-ian.stokes@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24452.000 X-TM-AS-Result: No-9.998200-8.000000-10 X-TMASE-MatchedRID: QW5G6BKkLToOwH4pD14DsPHkpkyUphL9BdebOqawiLt+YesuCgkiXFDc zN/SMpBYYQVxbe2ttf16PBB2sP26Z8XfVHU4nF20wCZxkTHxcclUENBIMyKD0dEsTITobgNENR5 689xTI1mI7qXZddSBHZGBRpo5jooJT/iRFWG2G/rBtFDYGmaWKpkShYcLpGH9H06W6rwtvNXN2W jbpqXgofa8+G6VxpdYgWg8WzvAdS0FrDF4OCzISamukiZOfPi2LZWWNVgH0Y3ZhqPLU/1bVd0pR IFbsjfbb7mJ6HbhlhGRk6XtYogiau9c69BWUTGwVnRXm1iHN1acfuxsiY4QFBGdYzl3S9k25JGk qfPzPcdIWey/n9awJ0snnGLyoCwbZuVw7nyaeozIcy+UrOgXJ2C/8I0TMaKZakQWjSyfJREsD5e QBuL2BMC+ksT6a9fy X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--9.998200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24452.000 X-MDID: 1551080440-CAbYn4VS3CYv Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 1/6] ethdev: add min/max MTU to device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 07:40:44 -0000 On 2/20/19 6:57 PM, Ian Stokes wrote: > From: Stephen Hemminger > > This addresses the usability issue raised by OVS at DPDK Userspace > summit. It adds general min/max mtu into device info. For compatiablity, > and to save space, it fits in a hole in existing structure. > > The initial version sets max mtu to normal Ethernet, it is up to > PMD to set larger value if it supports Jumbo frames. > > Also remove the deprecation notice introduced in 18.11 regarding this > change. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Ian Stokes > --- [...] > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index 0d192a24b..f089af94d 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -2527,6 +2527,8 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) > dev_info->rx_desc_lim = lim; > dev_info->tx_desc_lim = lim; > dev_info->device = dev->device; > + dev_info->min_mtu = ETHER_MIN_MTU; > + dev_info->max_mtu = ETHER_MTU; I think it should be set to UINT16_MAX to avoid breakage of jumbo frame support just after the patch. When all in tree drivers are updated, it can be set to ETHER_MTU, but it should in with UINT16_MAX value. with above issue fixed Acked-by: Andrew Rybchenko