From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 706F4A0096 for ; Wed, 5 Jun 2019 11:02:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88E201B9C5; Wed, 5 Jun 2019 11:02:25 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 58E491B9B8 for ; Wed, 5 Jun 2019 11:02:23 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id A9AC1700260; Wed, 5 Jun 2019 09:02:21 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 5 Jun 2019 10:02:16 +0100 To: Stephen Hemminger , References: <20190516180427.17270-1-stephen@networkplumber.org> <20190605010852.28395-1-stephen@networkplumber.org> <20190605010852.28395-5-stephen@networkplumber.org> From: Andrew Rybchenko Message-ID: <09ab16be-7e90-ffda-57a9-9be996e0289c@solarflare.com> Date: Wed, 5 Jun 2019 12:02:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190605010852.28395-5-stephen@networkplumber.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24658.003 X-TM-AS-Result: No-0.576300-8.000000-10 X-TMASE-MatchedRID: u1zqiMeMcrrmLzc6AOD8DfHkpkyUphL9E02Pr4CkNSM0edRJF+TkZOCM fQF3jikVS+Sdc1rSLVj28FBN5dldMCL4vLWMX3pxngIgpj8eDcC063Wh9WVqgjuUMbK1NdLP+gt Hj7OwNO2OhzOa6g8KrYWcJxJgu+0qnKHmbUF64jXPuiQLTigytdu3v8gQbtNppAEpAXow6KePgC DbAY3P7tVH8LonOSWy/S2A05ietQe2WKPzVcog4boOfFLgUu3n X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.576300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24658.003 X-MDID: 1559725342-tQoBbFOXAPme Subject: Re: [dpdk-dev] [PATCH v3 4/6] net/ether: use bitops to speedup comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/5/19 4:08 AM, Stephen Hemminger wrote: > Using bit operations like or and xor is faster than a loop > on all architectures. Really just explicit unrolling. > > Similar cast to uint16 unaligned is already done in > other functions here. > > Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko