DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Anoob Joseph <anoob.joseph@caviumnetworks.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
	dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues
Date: Mon, 8 Oct 2018 12:00:41 +0100	[thread overview]
Message-ID: <09bc1e17-661a-ab12-5ca0-215c7cdfe5ee@intel.com> (raw)
In-Reply-To: <1538995285-2040-1-git-send-email-anoob.joseph@caviumnetworks.com>

On 10/8/2018 11:41 AM, Anoob Joseph wrote:
> This patchset fixes multiple issues reported by checkpatch in l2fwd
> code base. These issues would be flagged for any new copy of the file
> and hence, fixing at the source.
> 
> Anoob Joseph (8):
>   examples/l2fwd: remove quoted white space before newline
>   examples/l2fwd: need space between two args
>   examples/l2fwd: else should follow close brace
>   examples/l2fwd: replace bare usage of 'unsigned'
>   examples/l2fwd: follow convention for block comments
>   examples/l2fwd: limit line to 80 char
>   examples/l2fwd: space required between elements
>   examples/l2fwd: remove null initialisation

Hi Anoob,

I am not sure if it is good idea to get syntax only fixes, I would prefer to get
syntax fixes when some other code touches that area.

Thanks,
ferruh

  parent reply	other threads:[~2018-10-08 11:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 10:41 Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 1/8] examples/l2fwd: remove quoted white space before newline Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 2/8] examples/l2fwd: need space between two args Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 3/8] examples/l2fwd: else should follow close brace Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 4/8] examples/l2fwd: replace bare usage of 'unsigned' Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 5/8] examples/l2fwd: follow convention for block comments Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 6/8] examples/l2fwd: limit line to 80 char Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 7/8] examples/l2fwd: space required between elements Anoob Joseph
2018-10-08 10:41 ` [dpdk-dev] [PATCH 8/8] examples/l2fwd: remove null initialisation Anoob Joseph
2018-10-08 11:00 ` Ferruh Yigit [this message]
2018-10-08 11:29   ` [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues Joseph, Anoob
2018-10-08 12:35     ` Ferruh Yigit
2018-10-29  2:19       ` Thomas Monjalon
2018-10-29  4:48         ` Joseph, Anoob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09bc1e17-661a-ab12-5ca0-215c7cdfe5ee@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=anoob.joseph@caviumnetworks.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=narayanaprasad.athreya@caviumnetworks.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).