From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E55D8A034F; Wed, 31 Mar 2021 14:27:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64009140EBD; Wed, 31 Mar 2021 14:27:08 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id CDAC3406A3 for ; Wed, 31 Mar 2021 14:27:06 +0200 (CEST) IronPort-SDR: uUWRAXigvM0Pg41xIOn0UFBVreQeYwXwsaWuEe4x8Wipx5zpH/dk89DCbw0sDBrksA6KfRtFjj d7ukIOP2qwIQ== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="191473286" X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="191473286" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 05:27:05 -0700 IronPort-SDR: Ol89l74DHU405/W8MW8sHPum1oFYSTsWzCk+1oUWgEKKtr5x18ARbWW4JFz6PNDLiNHplp9SN/ 6C2smUhh7XEg== X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="445664638" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.249.9]) ([10.213.249.9]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 05:27:04 -0700 To: "Burakov, Anatoly" , David Hunt , dev@dpdk.org Cc: jingjing.wu@intel.com, beilei.xing@intel.com References: <20210311115510.21066-1-david.hunt@intel.com> <3b43d8f4-baf1-8735-2381-cf19ed184581@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <09cfb299-70f8-17a3-0115-c593af60344d@intel.com> Date: Wed, 31 Mar 2021 13:27:01 +0100 MIME-Version: 1.0 In-Reply-To: <3b43d8f4-baf1-8735-2381-cf19ed184581@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] net/iavf: implement power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/11/2021 1:37 PM, Burakov, Anatoly wrote: > On 11-Mar-21 11:55 AM, David Hunt wrote: >> Implement support for the power management API by implementing a >> `get_monitor_addr` function that will return an address of an RX ring's >> status bit. >> >> This patch is basically a cut-and-paste of the changes already >> committed in ixgbe, i40e and ice drivers in 21.02. This extends >> the availability of the power-saving mechanism to the iavf driver, >> which is needed for those use-cases using virtual functions. >> >> Patch set where PMD Power Manamgement added in 21.02: >> http://patchwork.dpdk.org/project/dpdk/list/?series=14756 >> >> Signed-off-by: David Hunt >> --- > > LGTM as far as using the API correctly goes. > > Acked-by: Anatoly Burakov > The patch seems theoretically confirmed, but does it make sense to test the power feature on HW, what do you think? If tested already can it be possible to provide a tested-by tag for record?