From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Dean Marx <dmarx@iol.unh.edu>,
Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech,
probb@iol.unh.edu, paul.szczepanek@arm.com,
yoan.picchi@foss.arm.com, jspewock@iol.unh.edu,
bruce.richardson@intel.com
Cc: dev@dpdk.org
Subject: Re: dts: dynamic config test suite
Date: Thu, 1 Aug 2024 13:56:43 +0100 [thread overview]
Message-ID: <09d150ae-ab9c-4d12-a435-feab69e55fd8@arm.com> (raw)
In-Reply-To: <20240708190858.26583-4-dmarx@iol.unh.edu>
Can you please rebase this on the latest changes, as the code will look
different for sure?
Three comments in the meantime:
* Is there a reason for sleeping for 6 seconds? If so could you please
explain it?
* Please follow naming standards consistently, variables should be in
snake_case, referring to isPromisc -> is_promisc
* Please follow contributing guidelines when writing your commit
subject and body[1]
o Example I can spot are capitalisation of wording and the
non-imperative subject
Thanks,
Luca
[1]
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line
next prev parent reply other threads:[~2024-08-01 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 19:08 dts: dynamic config test suite implementation Dean Marx
2024-07-08 19:08 ` dts: add multicast set function to shell Dean Marx
2024-08-01 12:34 ` Luca Vizzarro
2024-07-08 19:08 ` dts: add toggle option to send and capture Dean Marx
2024-08-01 12:50 ` Luca Vizzarro
2024-07-08 19:08 ` dts: dynamic config test suite Dean Marx
2024-08-01 12:56 ` Luca Vizzarro [this message]
2024-07-08 19:08 ` dts: dynamic config conf schema Dean Marx
2024-08-01 12:57 ` Luca Vizzarro
2024-08-01 13:15 ` dts: dynamic config test suite implementation Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09d150ae-ab9c-4d12-a435-feab69e55fd8@arm.com \
--to=luca.vizzarro@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).