From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Wathsala Vithanage <wathsala.vithanage@arm.com>,
Thomas Monjalon <thomas@monjalon.net>,
Jakub Grajciar <jgrajcia@cisco.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, nd@arm.com, Liangxing Wang <liangxing.wang@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [PATCH V2] net/memif: fix extra mbuf refcnt update in zero copy Tx
Date: Wed, 14 Feb 2024 11:09:40 +0000 [thread overview]
Message-ID: <09d2db1b-ad4f-406f-8388-5841291b5100@amd.com> (raw)
In-Reply-To: <20240214003616.1382823-1-wathsala.vithanage@arm.com>
On 2/14/2024 12:36 AM, Wathsala Vithanage wrote:
> The refcnt update of stored mbufs in memif driver is redundant since
> those mbufs are only freed in eth_memif_tx_zc(). No other place can
> free those stored mbufs quietly. By removing this redundant update
> single core dpdk memif performance can be improved by 7.5%.
>
> testpmd stats on Arm Neoverse N1 (Ampere Altra)
> +-----------------------------+-----------------------+
> | | With refcnt update | Without refcnt update |
> +--------+--------------------+-----------------------+
> | Rx-pps | 2748851 | 2955487 |
> +--------+--------------------+-----------------------+
> | Tx-pps | 2748812 | 2955436 |
> +--------+--------------------+-----------------------+
>
> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> Cc: stable@dpdk.org
>
> Signed-off-by: Liangxing Wang <liangxing.wang@arm.com>
> Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2024-02-14 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 2:38 [PATCH v1] net/memif: remove " Liangxing Wang
2023-12-08 13:44 ` Ferruh Yigit
2024-02-08 1:06 ` Ferruh Yigit
2024-02-14 0:36 ` [PATCH V2] net/memif: fix " Wathsala Vithanage
2024-02-14 11:09 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09d2db1b-ad4f-406f-8388-5841291b5100@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jgrajcia@cisco.com \
--cc=liangxing.wang@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).