From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F06C43B30; Wed, 14 Feb 2024 12:09:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A35E940A7A; Wed, 14 Feb 2024 12:09:49 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061.outbound.protection.outlook.com [40.107.243.61]) by mails.dpdk.org (Postfix) with ESMTP id BF52940263 for ; Wed, 14 Feb 2024 12:09:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eLgQJjdBwH1K3JJstIjavMLKDJgdE4YBe6YAF2ah4nUvJ1bOFmVztDA87sBBN7hnWMqd+WjTRUkzA6EmH1MXk6N7fwyKsUyrvrCUxuzoaS1V2WmISEAcT6RDShnaUA2ksLR9HqgqWDHN/exCUGejRDJutJfg7Uw3UxFsdjdDWN/+vZMhliIKd3Se+0m5mgrPqOdrTSBkmIxmNL65tFCCqjQqz6q19MP0CsRxJG7PC/56zRGO/SnjvbTwrIgEuHEMjtbxBuK7K7ThTKeFkSsoWaV3b4j3G40h78gz19wcexM3pFgk6HOAN0ncBbloFxxPivbsvxI0+wPWIOiAPfyxMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ASDZvNvK0/rcQzR1CLPCx+4PlwKXdZFDS6J6FsslYa0=; b=O6E7R584B4VQU9QXunaZldj6Ghx1p+PrnRC7WDWNlTqcjSDcKm2a1cC2WU+pzI8RTF6UHgs707bgruYmD9v5MFWeHMccHSlVx0JHSvTVtFm8PknuX4qMdtYAz3ehCMgb9wSwNOoHBqTLLowC1jaksxMQMEl/4Sr02nqE9ESj6L4Wfyi6jrNV+CoQt1JRqnac2cklgSOwO6pZ7tMVm4FLE3OYRmGyWT7ptCf5vWYfyKJt6XdOe4K3JuZXeRNV5PqhvPhwnu7sHdFgHgLHG9nlBkFlUWC+VdBUP8PHTkBFo8XCRJfWOSfOXbdygCQjLBRPblB5U5cLaixzO9xtsWe2ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ASDZvNvK0/rcQzR1CLPCx+4PlwKXdZFDS6J6FsslYa0=; b=1HTyhe1BLiP6/qJPnxO5kXlMUdvLXEZQ6pkMdL3fwhz4ZNB/zhx9hgkG5olALhCOu9UFO6iwyZjaa8kWqwFa9XZsRerOlyXJ166P7wD3k2z+W0WOJP+THzqaulrzaZtvQbyGPIE7HRpUIg8aG0C5hnqey8ATJiK2VAVI4KKVqa4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB9423.namprd12.prod.outlook.com (2603:10b6:8:192::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25; Wed, 14 Feb 2024 11:09:44 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%4]) with mapi id 15.20.7292.028; Wed, 14 Feb 2024 11:09:44 +0000 Message-ID: <09d2db1b-ad4f-406f-8388-5841291b5100@amd.com> Date: Wed, 14 Feb 2024 11:09:40 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] net/memif: fix extra mbuf refcnt update in zero copy Tx To: Wathsala Vithanage , Thomas Monjalon , Jakub Grajciar , Ferruh Yigit Cc: dev@dpdk.org, nd@arm.com, Liangxing Wang , Ruifeng Wang References: <20231208023801.3156065-1-liangxing.wang@arm.com> <20240214003616.1382823-1-wathsala.vithanage@arm.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240214003616.1382823-1-wathsala.vithanage@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR05CA0058.eurprd05.prod.outlook.com (2603:10a6:10:2e::35) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB9423:EE_ X-MS-Office365-Filtering-Correlation-Id: de2e17fb-8969-4925-b7eb-08dc2d4d72d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mzLh1Ik832Bn8lYqFfjYFY9RAhVmoXy5Ra4KqQHbq4/WvCNO7Ll022CMXeHNpoN6MmoM5biYKi45hLvl4rARmIYfHHwu0k85nD3rW4ZM5JCx862zp0gHRl3xM/LEU7vOL/Iajtv0jhhqwA1/Q69pPwClVQFoJ7Zan1fh5GGGsNTEuNB8kraXCiEPf8MM+e2Nme/K3kjLbziPyBoH89ZzYxaExkTIZ7ojDbvuk+OQ2lfTjIviE4k422EZ14xBbCx1oBQY/u6FO8r0u/pnBCYcrW/oX3Eu6pkKBUSe38xiPPtfnhiWi2MOZxLcc4rIXBlF42k446cpO1tmf8YRoKjUxXcHCsgjag79bet+bKa474YPCCFLZfFrBUuBqfVf8HmzLZYuTJAr9GL7aczeY2BlAQS0V4wPWuXR84PdmRcUk95QFlZ81zroawllrfUEdBW2bKpN5+GfGErY1lwtWlm6DOxU7bzeE88yXmcKRfhf6v3L+WmglGEvVXA/Yl5m+qhxZloqR6Bv9x97Al+Vv2O50hLm+aYDThz2Bw8i45q9rkmeLZPAZgKy/Gs13IUX8TcV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39850400004)(366004)(396003)(346002)(136003)(376002)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(6512007)(53546011)(6666004)(6486002)(6506007)(31686004)(2906002)(44832011)(15650500001)(5660300002)(110136005)(54906003)(316002)(41300700001)(8676002)(478600001)(8936002)(66556008)(66946007)(4326008)(66476007)(26005)(2616005)(83380400001)(31696002)(86362001)(38100700002)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0NwUW42bnlCTWJrTXRHUmluV3NwTHJBL1BqbzFHUHN2aGRoTEFRaGdncXhL?= =?utf-8?B?ZXpVUmVtRmdWYmRweHhOckdKMTB5dUkyY2dlOGlKQWkrclY4ckRHbDJ3MS9J?= =?utf-8?B?Zk9lNW9Ea2VTZjNmV2tpR2V5T2F1SXJkY3RrTzYzSGo1MncvcHdUaVJQeStw?= =?utf-8?B?bHBvNE1rZ25HWDNtZzhWaVBiOEtwL25BOXRSTVQ2SUU3YVBJOTVQaWo4NDAw?= =?utf-8?B?MGFmMTFoK0EyN1NMakdxQ1hyRStBNnhLK3RiNzNwS3Z3YnZ5TENVQmJBekF1?= =?utf-8?B?S1h4QkFPSnlqSHhJbzdFZzVmTC9lL25FaCtVUFdUV212cXlLUHU5Z3h1WVNU?= =?utf-8?B?T2ZJSnZpbS8xUmJzSU5wS3BCaVl5RjVsOS9Va1NmWjdodXBEaHdLOVRtak8v?= =?utf-8?B?K1BYOXdsMkxodHU4VHAxS1h6S2VDU2VhRkRJQVF6ME82RWdMa2R1d2x5clJq?= =?utf-8?B?UkdCcFg0T2ROaG9veHFuOVlwRFk3MWxlTTNlRHM3SGpXMGRHeit5U0pTdm5m?= =?utf-8?B?TCswYXFxOWpibm9GN0xhSFNkczRCc3pEa1kzRFhoM3VWNEdmeWNZN3E0MFNh?= =?utf-8?B?bU5pRUJTUUZ2YzRLQ0RQMlJOYk52NnJLZEFQRU9pUTQrbW93NDg3VFlyUWJy?= =?utf-8?B?T1I1Z0RDcXhnVzByL1FyNWJ5ay85SjBXdXZwZ3VSa2daRVh6Z29YK1NxNXVY?= =?utf-8?B?UFhhRWFMTTZyVjAwalZWMXJEZGtwME1FUW9LdGtEL2lGNEZGRFF4VGJwTDRV?= =?utf-8?B?Nkl3dXVCOVh1Y05UQkU4a2RIdWhhSEhwb0c0c2dGR2p5RDhJeHUybThjWHdu?= =?utf-8?B?UlJIMjU0VjRieWozWjBLWXRSZS9KT0lWVnBOTG5iSHJPY1I3aWZBbEdodHZI?= =?utf-8?B?bys1UlBkaG5yWWVkL29oS0ZxL0h2WGZvbGowdXlBLytTejd0UUdDK1pjZ3gy?= =?utf-8?B?dTZqZVhsVitERUhzZXdyZFh5M0tvcDV3akNYTXZIZk9Vc25XbDBOaWVLaFlQ?= =?utf-8?B?VzQ1bWpxMXJXS1Blb0pyRnlZZ3NYVi8vYkJOT1FUbWV6Y1E3OEtSeHh1bFpH?= =?utf-8?B?R2EwdytiZ2hvQTBjQ0tjVHpOSk5kZWEzVFAwa1BMNGJ0Z3h1cDY5N2RjVFBY?= =?utf-8?B?M3l3K28rY2NxVUpySlh6ZWxFOU9zbFYvMzlST0tQcXlzdmxQUExiKzhEYmVW?= =?utf-8?B?ZW43aFJiZjZHSkZydUNHY0h4MzQ0TW13TmRTazdFR1puUngwM0hIaEg0ZThS?= =?utf-8?B?Y3JCb1lUWUMxbDMwOE14QTBhek9lOUhHZmFiYUIycDRpQ0gzOGppOW1TTk5i?= =?utf-8?B?TUg0bVNNc3lBeHBMVGpEZThrS2FkN1dQMFdxeFYwcnphT2ZaaHFlZW9lQW1K?= =?utf-8?B?dUZaNjRPczQwUjZQOWZFNGM4RWJ5QVlSTG1EZG5SbnNPcVBVSXJ0R085aVgy?= =?utf-8?B?RDc3UFZWN1NSQ3I4T284MkdibGo3eUhkSGluMW0vTmtHQThuVkIyczEwblVq?= =?utf-8?B?ejlTdGFUenhMcXNFSEN0a2FkWGVlc2R0TDRqQXo2Wnp3aDJ0N2FTM0tjY1pP?= =?utf-8?B?clRGK3VDUUhwRGVwenIxbzhlVGtQLzZDV0laSHBxSkhaaVA5Nm84NS81RTRa?= =?utf-8?B?TGZDYmw5YlE2VGp3QzN5VE40ZUN2WVRjdkVZOHliRUIvOHZoOFlPUitkeGlK?= =?utf-8?B?bnd6bVp3SDVRVnozQUY3S1NjVEpaTDlES0JGZjZRZUdvZnVIQ1RxV3BXRG9Q?= =?utf-8?B?M0ZxYWcyanRwYzErUkxNTUMrdDB4NWFqSitjWWNpMUJ2dXBSQzAvSTh1dVcy?= =?utf-8?B?elJQWWU1RnVEL09hQVJ3ZXNxYTA0cXlqVUlFNjk1Q0k2ZmwzamRvckJFMXp0?= =?utf-8?B?NzhXNGhzaE9LNHpNaUF1WkViYTJjaVBRVVJDQk93U3RRNkI0WEdUKzJyd2Uz?= =?utf-8?B?WDRzQnMrN1laVllGWThBNjJzaERsMzMyemRhdVg5UkZ6RStRbTNVaVpMTjBE?= =?utf-8?B?YW52YzF5L1ZTUjJjQmRUUVpXcU5nNmhJckhKNnRoemt1cElQT0hJb0QvTjBS?= =?utf-8?B?SXdzYi9OQzdLYmN5UkhBejRjTHB5cU1rOFJXZTZEejJsTE83ZUZPdXl5QlRi?= =?utf-8?Q?MzckK4XzS1Lbl2EPfhVUvso+k?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: de2e17fb-8969-4925-b7eb-08dc2d4d72d1 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 11:09:44.4316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: orzX8xYHaf3AuwoebV0EaDc6rfZ6RcXrZnCY0cTVY+NVkDbKew5GEAqQpYLetN2x X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9423 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2024 12:36 AM, Wathsala Vithanage wrote: > The refcnt update of stored mbufs in memif driver is redundant since > those mbufs are only freed in eth_memif_tx_zc(). No other place can > free those stored mbufs quietly. By removing this redundant update > single core dpdk memif performance can be improved by 7.5%. > > testpmd stats on Arm Neoverse N1 (Ampere Altra) > +-----------------------------+-----------------------+ > | | With refcnt update | Without refcnt update | > +--------+--------------------+-----------------------+ > | Rx-pps | 2748851 | 2955487 | > +--------+--------------------+-----------------------+ > | Tx-pps | 2748812 | 2955436 | > +--------+--------------------+-----------------------+ > > Fixes: 43b815d88188 ("net/memif: support zero-copy slave") > Cc: stable@dpdk.org > > Signed-off-by: Liangxing Wang > Signed-off-by: Wathsala Vithanage > Reviewed-by: Ruifeng Wang > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.