DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	Xiaozhen Ban <benhaz1024@gmail.com>,
	"Guo, Jia" <jia.guo@intel.com>,
	"Wang, Haiyue" <haiyue.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value
Date: Tue, 20 Apr 2021 09:08:57 +0100	[thread overview]
Message-ID: <09dce07d-04a4-cfb8-ab1f-5887a5a5d0d2@intel.com> (raw)
In-Reply-To: <289fcebe24c8414bb28c949ef87dd349@intel.com>

On 3/25/2021 8:46 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaozhen Ban
>> Sent: Friday, March 19, 2021 12:08 PM
>> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
>>
>>>> -----Original Message-----
>>>> From: Xiaozhen Ban <benhaz1024 at gmail.com>
>>>> Sent: Thursday, March 18, 2021 19:44
>>>> To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
>>>> intel.com>
>>>> Cc: dev at dpdk.org; stable at dpdk.org
>>>> Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
>>>>
>>>> OK, but I think this bug affects all stable release about 6 years before today.
>>
>>> I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
>>> always use RTE_ETH_FILTER_GENERIC. ;-)
>>
>> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application developer
>> know how to use the parameter filter_type correctly, it's OK.
>> otherwise he will get rte_eth_dev_filter_ctrl() return value is success but
>> actually is failed.
> 
> After check with Haiyue, we think the patch is still needed for LTS <= 19.11, so
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Applied to dpdk-next-net-intel.
> 

What is the status of this patch?
It seems it did not applied, and the status in the patchwork is "Superseded".

  reply	other threads:[~2021-04-20  8:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  8:10 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024
2020-12-08  9:04 ` Wang, Haiyue
2020-12-08  9:58   ` haz ben
2020-12-08 10:40     ` Wang, Haiyue
2020-12-08 11:05     ` Wang, Haiyue
2021-03-17  9:15 ` [dpdk-dev] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
2021-03-17 11:23   ` Wang, Haiyue
2021-03-18 11:44     ` Xiaozhen Ban
2021-03-18 15:28       ` Wang, Haiyue
2021-03-19  4:08         ` Xiaozhen Ban
2021-03-25  8:46           ` Zhang, Qi Z
2021-04-20  8:08             ` Ferruh Yigit [this message]
2021-04-20  9:54               ` [dpdk-dev] [dpdk-stable] " Zhang, Qi Z
2021-04-20 14:33                 ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09dce07d-04a4-cfb8-ab1f-5887a5a5d0d2@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=benhaz1024@gmail.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=jia.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).