From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D718FA0547; Tue, 20 Apr 2021 10:09:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C248B415D7; Tue, 20 Apr 2021 10:09:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 0CEAD40138; Tue, 20 Apr 2021 10:09:06 +0200 (CEST) IronPort-SDR: ePqFI4qylccR2VOFASWVvjpoYAKbPSOWWUQ0gOz2tXIOFdCr2Z0CIN3RsnazMkr4yReSZZpJU3 eAs0Gfw6oQAQ== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="280793744" X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="280793744" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 01:09:03 -0700 IronPort-SDR: kJhPZC5PhIaJC3kVUoaWLBdDQo6xDPVpX+Md55YNJUBsp1qkwuzTr3AsmnNdDMgBH86gEwloQ3 GsvwTaqE2Kzg== X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="420313852" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.207.27]) ([10.213.207.27]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 01:09:01 -0700 To: "Zhang, Qi Z" , Xiaozhen Ban , "Guo, Jia" , "Wang, Haiyue" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20210319040817.64143-1-benhaz1024@gmail.com> <289fcebe24c8414bb28c949ef87dd349@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <09dce07d-04a4-cfb8-ab1f-5887a5a5d0d2@intel.com> Date: Tue, 20 Apr 2021 09:08:57 +0100 MIME-Version: 1.0 In-Reply-To: <289fcebe24c8414bb28c949ef87dd349@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/2021 8:46 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: dev On Behalf Of Xiaozhen Ban >> Sent: Friday, March 19, 2021 12:08 PM >> To: Guo, Jia ; Wang, Haiyue >> Cc: dev@dpdk.org; stable@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value >> >>>> -----Original Message----- >>>> From: Xiaozhen Ban >>>> Sent: Thursday, March 18, 2021 19:44 >>>> To: Guo, Jia ; Wang, Haiyue >>> intel.com> >>>> Cc: dev at dpdk.org; stable at dpdk.org >>>> Subject: RE: RE: [PATCH] net/e1000: fix filter control return value >>>> >>>> OK, but I think this bug affects all stable release about 6 years before today. >> >>> I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get' >>> always use RTE_ETH_FILTER_GENERIC. ;-) >> >> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application developer >> know how to use the parameter filter_type correctly, it's OK. >> otherwise he will get rte_eth_dev_filter_ctrl() return value is success but >> actually is failed. > > After check with Haiyue, we think the patch is still needed for LTS <= 19.11, so > > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. > What is the status of this patch? It seems it did not applied, and the status in the patchwork is "Superseded".